-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OADP-935: Incorrect Backup apiVersion in "Using Data Mover for CSI snapshots" #53198
Conversation
🤖 Build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/4135 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@PrasadJoshi12: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label OADP |
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
/remove-label peer-review-in-progress |
/oadp |
@weshayutin Please merge on Monday. Tuesday is OK, too. |
@RichardHoch I do not have merge rights here. |
@RichardHoch Handling this now. Just a reminder. We are no longer updating documentation for 4.6 and 4.7. Those versions are EOL. I will merge this into 4.8+. I updated the first comment in the PR to reflect that. |
/cherrypick enterprise-4.12 |
/cherrypick enterprise-4.11 |
/cherrypick enterprise-4.10 |
/cherrypick enterprise-4.9 |
/cherrypick enterprise-4.8 |
@mjpytlak: new pull request created: #53467 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mjpytlak: new pull request created: #53468 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mjpytlak: new pull request created: #53469 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mjpytlak: new pull request created: #53470 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mjpytlak: #53198 failed to apply on top of branch "enterprise-4.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@RichardHoch I believe the CP back to 4.8 failed because the module you updated does not exist in 4.8. I believe this is what Please verify that the module does exist in 4.8. |
@mjpytlak Thanks! Double-checking with the SME that we do want this for 4.8 (4.9+ may be enough). If so, will check on the module. If needed, I'll CP and submit the PR. If not, I'll let you know. |
Confirmed that this CP to 4.8 failed because when the original author of the module added to the doc doc, they added it to 4.9+ only. [1] I have spoken to @RichardHoch and he will double check with the SME and the original author to determine if this content should live in 4.8, as well. If so, Richard will open a separate PR to track this work. I have removed the [1] #48619 |
@mjpytlak Thanks for the great advice and support! |
OADP 1.0.6; OCP 4.9+
Bug reported by QE; PR approived by QE.
Resolves https://issues.redhat.com/browse/OADP-935 by changing the Backup apiVersion in the Back GR codeblock in "Using Data Mover for CSI snapshots."
Preview: See step 3a in https://53198--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/backing_up_and_restoring/backing-up-applications.html#oadp-using-data-mover-for-csi-snapshots_backing-up-applications