Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ2149119: Cron job limitation in_MTC 1.7.6 #53871

Conversation

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2022
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 15, 2022

🤖 Updated build preview is available at:
https://53871--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/23751

@sbeskin-redhat
Copy link
Contributor Author

@pranavgaikwad Please review this PR.

Copy link

@stillalearner stillalearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RichardHoch
Copy link
Contributor

LGTM

@RichardHoch
Copy link
Contributor

/label MTC
/peer-review-needed

@openshift-ci openshift-ci bot added the MTC Label for all MTC PRs label Jan 11, 2023
@RichardHoch
Copy link
Contributor

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 11, 2023
@adellape adellape added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jan 11, 2023
@adellape adellape self-requested a review January 11, 2023 17:10
@@ -25,3 +25,4 @@ This release has the following known issues:
* `MigPlan` custom resource does not display a warning when an AWS gp2 PVC has no available space. (link:https://bugzilla.redhat.com/show_bug.cgi?id=1963927[*BZ#1963927*])
* Direct and indirect data transfers do not work if the destination storage is a PV that is dynamically provisioned by the AWS Elastic File System (EFS). This is due to limitations of the AWS EFS Container Storage Interface (CSI) driver. (link:https://bugzilla.redhat.com/show_bug.cgi?id=2085097[*BZ#2085097*])
* Block storage for IBM Cloud must be in the same availability zone. See the link:https://cloud.ibm.com/docs/vpc?topic=vpc-block-storage-vpc-faq[IBM FAQ for block storage for virtual private cloud].
* MTC 1.7.6 cannot migrate cron jobs from source clusters that support v1beta1 CronJob to OCP 4.12+ clusters, which do not support v1beta1 CronJob. (link:https://bugzilla.redhat.com/show_bug.cgi?id=2149119[*BZ#2149119*])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OCP 4.12+

->

{product-title} 4.12 and later

@@ -25,3 +25,4 @@ This release has the following known issues:
* `MigPlan` custom resource does not display a warning when an AWS gp2 PVC has no available space. (link:https://bugzilla.redhat.com/show_bug.cgi?id=1963927[*BZ#1963927*])
* Direct and indirect data transfers do not work if the destination storage is a PV that is dynamically provisioned by the AWS Elastic File System (EFS). This is due to limitations of the AWS EFS Container Storage Interface (CSI) driver. (link:https://bugzilla.redhat.com/show_bug.cgi?id=2085097[*BZ#2085097*])
* Block storage for IBM Cloud must be in the same availability zone. See the link:https://cloud.ibm.com/docs/vpc?topic=vpc-block-storage-vpc-faq[IBM FAQ for block storage for virtual private cloud].
* MTC 1.7.6 cannot migrate cron jobs from source clusters that support v1beta1 CronJob to OCP 4.12+ clusters, which do not support v1beta1 CronJob. (link:https://bugzilla.redhat.com/show_bug.cgi?id=2149119[*BZ#2149119*])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a mixture of "cron jobs" and "CronJob". You could change them all to lower case "cron job(s)" (no markup) as a general reference, or for the later ones that mention the API version you could do "v1beta1 CronJob objects". See general reference vs object reference in the API object formatting repo guidelines.

You might also consider marking up v1beta1, as I see it often is elsewhere in the repo. E.g., "that support the v1beta1 API version of CronJob objects".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adellape Thank you! Please take a look now.

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.12 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 11, 2023
@sbeskin-redhat sbeskin-redhat force-pushed the BZ2149119_CronJob_limitation_in_MTC_176 branch from af2b1e8 to 6085034 Compare January 12, 2023 09:02
@kalexand-rh kalexand-rh added this to the Continuous Release milestone Jan 16, 2023
@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.13 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.12. And any PR going into main must also target the latest version branch (enterprise-4.13).

If the update in your PR does NOT apply to version 4.13 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@sbeskin-redhat
Copy link
Contributor Author

@bergerhoffer Can this PR be merged?

@bergerhoffer
Copy link
Contributor

@sbeskin-redhat Can you add the 'merge-review-needed' label when you're ready for this to be merged? I can see that there are 4 commits though, so you'll need to squash at least before sending it. Thanks!

@kalexand-rh
Copy link
Contributor

The branch/enterprise-4.14 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.13. And any PR going into main must also target the latest version branch (enterprise-4.14).

If the update in your PR does NOT apply to version 4.14 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 15, 2023
@sbeskin-redhat
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 6, 2023
@sbeskin-redhat sbeskin-redhat force-pushed the BZ2149119_CronJob_limitation_in_MTC_176 branch from b035560 to 316e294 Compare September 6, 2023 07:45
@sbeskin-redhat
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 6, 2023
@mjpytlak mjpytlak added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 6, 2023
@mjpytlak
Copy link
Contributor

mjpytlak commented Sep 6, 2023

@sbeskin-redhat did you get approval from @pranavgaikwad outside of this PR? Looks like we are still waiting on it here.

@sbeskin-redhat
Copy link
Contributor Author

@mjpytlak
He just approved it.

@mjpytlak mjpytlak merged commit 24e12d4 into openshift:main Sep 6, 2023
1 check passed
@mjpytlak
Copy link
Contributor

mjpytlak commented Sep 6, 2023

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@mjpytlak: new pull request created: #64386

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak
Copy link
Contributor

mjpytlak commented Sep 6, 2023

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@mjpytlak: new pull request created: #64387

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjpytlak
Copy link
Contributor

mjpytlak commented Sep 6, 2023

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@mjpytlak: new pull request created: #64388

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 merge-review-in-progress Signifies that the merge review team is reviewing this PR MTC Label for all MTC PRs peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet