Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV-19923: remove the module about configuring file system overhead #54362

Merged
merged 1 commit into from
Apr 17, 2023
Merged

CNV-19923: remove the module about configuring file system overhead #54362

merged 1 commit into from
Apr 17, 2023

Conversation

sabrinajess
Copy link
Contributor

@sabrinajess sabrinajess commented Jan 9, 2023 •
edited

Version(s): 4.9, 4.10

Issue: CNV-19923

Link to docs preview: http://file.rdu.redhat.com/sjess/CNV19923-1/virt/about-virt.html

QE review: Kevin Goldblatt

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 9, 2023
@sabrinajess sabrinajess force-pushed the CNV19923-1 branch 2 times, most recently from 3fb8aac to e694464 Compare January 13, 2023 19:22
@maya-r
Copy link

maya-r commented Jan 14, 2023

lgtm

kgoldbla
kgoldbla approved these changes Jan 15, 2023
View reviewed changes
Copy link

@kgoldbla kgoldbla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apinnick apinnick linked an issue Jan 15, 2023 that may be closed by this pull request
[enterprise-4.9] Issue in file virt/virtual_machines/virtual_disks/virt-reserving-pvc-space-fs-overhead.adoc #40119
Closed
@apinnick apinnick added peer-review-needed Signifies that the peer review team needs to review this PR qe-approved Signifies that QE has signed off on this PR branch/enterprise-4.9 branch/enterprise-4.10 and removed QE Required labels Jan 15, 2023
@aireilly
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jan 16, 2023
@aireilly
Copy link
Contributor

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 16, 2023
aireilly
aireilly reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - However, I don't see a preview for this change, can you post the preview link.

@aireilly
Copy link
Contributor

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 16, 2023
@emarcusRH emarcusRH mentioned this pull request Jan 17, 2023
Closed
1 task
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 30, 2023 •
edited by openshift-ci bot

@sabrinajess: This pull request references CNV-19923 which is a valid jira issue.

In response to this:

Version(s): 4.9, 4.10

Issue: CNV-19923

Link to docs preview: http://file.rdu.redhat.com/sjess/CNV19923-1/virt/about-virt.html

QE review: Kevin Goldblatt

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sabrinajess
Copy link
Contributor Author

@aireilly Preview added (no direct link since PR is for removing content).

@sabrinajess
Copy link
Contributor Author

@aireilly Is this OK to move to merge review?

@aireilly
Copy link
Contributor

aireilly commented Feb 3, 2023

Sorry! Yep go for it.

@aireilly
Copy link
Contributor

aireilly commented Feb 3, 2023

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Feb 3, 2023
@apinnick apinnick merged commit f25b846 into openshift:enterprise-4.9 Apr 17, 2023
@apinnick
Copy link
Contributor

/cherrypick enterprise-4.10

@openshift-cherrypick-robot
Copy link

@apinnick: #54362 failed to apply on top of branch "enterprise-4.10":

Applying: 4.9 edits for 19923
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
M	virt/virtual_machines/virtual_disks/virt-creating-data-volumes.adoc
Falling back to patching base and 3-way merge...
Removing virt/virtual_machines/virtual_disks/virt-reserving-pvc-space-fs-overhead.adoc
Auto-merging virt/virtual_machines/virtual_disks/virt-creating-data-volumes.adoc
CONFLICT (content): Merge conflict in virt/virtual_machines/virtual_disks/virt-creating-data-volumes.adoc
Removing modules/virt-overriding-default-fs-overhead-value.adoc
Removing modules/virt-how-fs-overhead-affects-space-vm-disks.adoc
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 4.9 edits for 19923
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@apinnick apinnick mentioned this pull request Apr 17, 2023
Merged
@apinnick apinnick added the CNV Label for all CNV PRs label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maya-r maya-r maya-r left review comments

@aireilly aireilly aireilly left review comments

@kgoldbla kgoldbla kgoldbla approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.9 branch/enterprise-4.10 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[enterprise-4.9] Issue in file virt/virtual_machines/virtual_disks/virt-reserving-pvc-space-fs-overhead.adoc
7 participants
@sabrinajess @maya-r @aireilly @openshift-ci-robot @apinnick @openshift-cherrypick-robot @kgoldbla