Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSMDOC-738 Fixed noun/verb agreement. #54384

Merged
merged 1 commit into from Jan 9, 2023

Conversation

gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Jan 9, 2023

Updated sentence "Sidecar proxies manage inbound and outbound communication to the workload instance it is attached to" so it reads "Sidecar proxies manage inbound and outbound communication for their workload instance."

Version(s):
4.8+

Issue:
https://issues.redhat.com/browse/OSSMDOC-738

Link to docs preview:

QE review:
Not required.

Additional information:

My first Red Hat PR! Hoping I didn't miss a step.

Updated sentence "Sidecar proxies manage inbound and outbound communication to the workload instance it is attached to" so it reads "*Sidecar proxies* manage inbound and outbound communication for their workload instance."
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2023
@gwynnemonahan
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2023

@gwynnemonahan: Can not set label peer-review-needed: Must be member in one of these teams: [team-red-hat]

In response to this:

/label peer-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ocpdocs-previewbot
Copy link

@bburt-rh
Copy link
Contributor

bburt-rh commented Jan 9, 2023

This looks good to me, @gwynnemonahan. Congrats on your first PR. It's a true milestone!

  • Can you please add OSSMDOC-738 to the beginning of the PR title? This way, a link to the PR will automatically populate in the "Links" section of the Jira issue.
  • We also normally include in the description a doc preview link that goes directly to the section in the docs that the PR updates. That way the reviewer doesn't have to dig through the entire doc set looking for the content that the PR changes. So if you could add that link to the description in your next PR, that would be wonderful. I went ahead and looked at the Jira and found the specific section so that I could check that the preview rendered correctly: https://54384--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-architecture.html#ossm-architecture_ossm-architecture
  • Normally, QE approval is required for all PRs, except those that do not change any technical content (such as typo and grammatical fixes). Because this PR only fixes a grammatical issue and doesn't change any technical content, no QE review is required. When this is the case, you should include a note to this effect in the description so that the peer or merge reviewer knows that this is an exception and that the PR doesn't require QE review and approval.

That's it. Good work! Let me know if you have any questions, and when you're ready for this to be merged, request a merge in our Slack channel.

@gwynnemonahan gwynnemonahan changed the title Fixed noun/verb agreement. OSSMDOC-738 Fixed noun/verb agreement. Jan 9, 2023
@bburt-rh bburt-rh added peer-review-done Signifies that the peer review team has reviewed this PR dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.12 labels Jan 9, 2023
@bburt-rh bburt-rh added this to the Continuous Release milestone Jan 9, 2023
@bburt-rh bburt-rh merged commit 215624e into openshift:main Jan 9, 2023
@bburt-rh
Copy link
Contributor

bburt-rh commented Jan 9, 2023

/cherrypick enterprise-4.8

@bburt-rh
Copy link
Contributor

bburt-rh commented Jan 9, 2023

/cherrypick enterprise-4.9

@bburt-rh
Copy link
Contributor

bburt-rh commented Jan 9, 2023

/cherrypick enterprise-4.10

@bburt-rh
Copy link
Contributor

bburt-rh commented Jan 9, 2023

/cherrypick enterprise-4.11

@bburt-rh
Copy link
Contributor

bburt-rh commented Jan 9, 2023

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@bburt-rh: new pull request created: #54391

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bburt-rh: new pull request created: #54392

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bburt-rh: new pull request created: #54393

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bburt-rh: new pull request created: #54394

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bburt-rh: new pull request created: #54395

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.12 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants