Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-4740: Added new features for pipelines 1.9 RN #54491

Merged
merged 1 commit into from
Jan 18, 2023
Merged

RHDEVDOCS-4740: Added new features for pipelines 1.9 RN #54491

merged 1 commit into from
Jan 18, 2023

Conversation

shipsing
Copy link
Contributor

@shipsing shipsing commented Jan 11, 2023 •
edited

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 11, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 11, 2023 •
edited

🤖 Updated build preview is available at:
https://54491--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/7333

@shipsing shipsing force-pushed the RHDEVDOCS-4740 branch 2 times, most recently from ffd8be4 to 1b2f833 Compare January 12, 2023 10:04
@shipsing
Copy link
Contributor Author

shipsing commented Jan 12, 2023 •
edited

@vdemeester @khrm @piyush-garg @sm43 @PuneetPunamiya @savitaashture @concaf, Could you please help with SME review of this PR?

Also, please have a look at the OCP versions for cherrypicking in the PR description section and the availability of the components as TP or GA.
In the RN preview, the availabilty of the components shows:

  • Pipelines: GA
  • Triggers: GA
  • CLI: GA
  • Operator: GA
  • Tekton Chains: TP
  • Tekton Hub: TP
  • PAC: GA

@shipsing shipsing force-pushed the RHDEVDOCS-4740 branch 2 times, most recently from a485ac8 to 891322a Compare January 13, 2023 10:34
@shipsing
Copy link
Contributor Author

@chmouel incorporated your suggestions. Thanks

@shipsing
Copy link
Contributor Author

@vdemeester @khrm @piyush-garg @sm43 @PuneetPunamiya @savitaashture @concaf, please review the changes and share your feedback. Thanks

@PuneetPunamiya
Copy link

For Tekton Hub the changes LGTM

ppitonak
ppitonak approved these changes Jan 18, 2023
View reviewed changes
Copy link

@ppitonak ppitonak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
@savitaashture
Copy link

LGTM

gabriel-rh
gabriel-rh reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

I have only 2 concerns - the "alpha preview" terminology and the reference to "4.13"

modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-tkn-pipelines-compatibility-support-matrix.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
@shipsing
Copy link
Contributor Author

Thank you @gabriel-rh for the quick review. I have incorporated all your suggestions. Please verify and confirm. Thanks

gabriel-rh
gabriel-rh approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Great work under pressure!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
@ppitonak
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
@gabriel-rh gabriel-rh merged commit f52ee8f into openshift:main Jan 18, 2023
@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.11

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 18, 2023
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #54860

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 18, 2023
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #54861

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Preeticp
Copy link
Contributor

/cherry-pick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 19, 2023
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #54895

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@chmouel chmouel chmouel left review comments

@ppitonak ppitonak ppitonak approved these changes

@savitaashture savitaashture savitaashture left review comments

@Preeticp Preeticp Preeticp left review comments

@piyush-garg piyush-garg piyush-garg left review comments

@pratap0007 pratap0007 pratap0007 left review comments

@sounix000 sounix000 sounix000 left review comments

@khrm khrm khrm approved these changes

@concaf concaf concaf approved these changes

@sm43 sm43 sm43 approved these changes

@gabriel-rh gabriel-rh gabriel-rh approved these changes

Assignees

@ppitonak ppitonak

@gabriel-rh gabriel-rh

Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet