Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-4350-fix-for-monitoring-persistent-storage-requirements #54677

Merged
merged 1 commit into from Jan 18, 2023
Merged

RHDEVDOCS-4350-fix-for-monitoring-persistent-storage-requirements #54677

merged 1 commit into from Jan 18, 2023

Conversation

bburt-rh
Copy link
Contributor

@bburt-rh bburt-rh commented Jan 13, 2023 •
edited

Summary: This PR fixes an issue where the wrong storage type was listed for setting up persistent storage for the OCP monitoring stack.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 13, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 13, 2023 •
edited

🤖 Updated build preview is available at:
https://54677--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/7213

@bburt-rh bburt-rh requested a review from juzhao January 13, 2023 18:27
@bburt-rh bburt-rh force-pushed the RHDEVDOCS-4350-fix-for-monitoring-persistent-storage-requirements branch from a495cb0 to e8dd319 Compare January 16, 2023 15:30
@bburt-rh bburt-rh requested a review from juzhao January 16, 2023 15:34
@juzhao
Copy link

juzhao commented Jan 17, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023
@bburt-rh bburt-rh force-pushed the RHDEVDOCS-4350-fix-for-monitoring-persistent-storage-requirements branch from e8dd319 to a801ceb Compare January 17, 2023 16:49
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2023

New changes are detected. LGTM label has been removed.

rolfedh
rolfedh approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rolfedh rolfedh added the peer-review-done Signifies that the peer review team has reviewed this PR label Jan 17, 2023
@bburt-rh bburt-rh added the qe-approved Signifies that QE has signed off on this PR label Jan 17, 2023
@bburt-rh bburt-rh added this to the Continuous Release milestone Jan 17, 2023
@bburt-rh bburt-rh merged commit 4deaf4e into openshift:main Jan 18, 2023
@bburt-rh
Copy link
Contributor Author

/cherrypick enterprise-4.13

@bburt-rh
Copy link
Contributor Author

/cherrypick enterprise-4.12

@bburt-rh
Copy link
Contributor Author

/cherrypick enterprise-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 18, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #54846

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 18, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #54847

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 18, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #54848

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jan 18, 2023
Merged
Merged
Merged
@bburt-rh bburt-rh deleted the RHDEVDOCS-4350-fix-for-monitoring-persistent-storage-requirements branch June 6, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfedh rolfedh rolfedh approved these changes

@juzhao juzhao Awaiting requested review from juzhao

Assignees

@juzhao juzhao

Labels
branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bburt-rh @ocpdocs-previewbot @juzhao @openshift-cherrypick-robot @rolfedh