Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHDEVDOCS-4741: Added information in various sections of 1.9 Pipeline… #54712

Closed
wants to merge 0 commits into from

Conversation

Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented Jan 16, 2023

Purpose: To resolve the following issues:

https://issues.redhat.com/browse/RHDEVDOCS-4741
https://issues.redhat.com/browse/RHDEVDOCS-4743
https://issues.redhat.com/browse/RHDEVDOCS-4742
Aligned team: DevTools

OCP version this PR applies to (cherrypicking): enterprise 4.11 and later

Content for preview: https://54712--docspreview.netlify.app/openshift-enterprise/latest/welcome/index.html

SME review : @vdemeester @khrm @piyush-garg @sm43 @PuneetPunamiya @savitaashture @concaf

QE review: @ppitonak

Peer review: @gabriel-rh

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 16, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 16, 2023

🤖 Updated build preview is available at:
https://54712--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/7396

@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-4741 branch 3 times, most recently from 6072f90 to fb2110b Compare January 17, 2023 06:50
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-4741 branch 3 times, most recently from f3e157e to 8a51272 Compare January 18, 2023 12:29
@savitaashture
Copy link

LGTM

@piyush-garg
Copy link

LGTM

@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-4741 branch 2 times, most recently from bae5840 to 9083ab7 Compare January 18, 2023 13:31
@rupalibehera
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Some suggestions to improve readability and to ensure consistency in tense

modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2023
@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-4741 branch 2 times, most recently from 4a436eb to 983f998 Compare January 18, 2023 17:30
@rupalibehera
Copy link

@ppitonak could you please take a final look, thanks

@rupalibehera
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2023

New changes are detected. LGTM label has been removed.

Copy link

@VeereshAradhya VeereshAradhya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@savitaashture @sm43 https://issues.redhat.com/browse/SRVKP-2549 should also be included in release notes right as it is an important feature?
cc: @concaf @ppitonak @vdemeester

modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
@sm43
Copy link

sm43 commented Jan 19, 2023

@VeereshAradhya
https://issues.redhat.com/browse/SRVKP-2549 should also be included in release notes right as it is an important feature?

its there in operator section

With this update, you can also modify Pipelines as Code configurations in the TektonConfig CRD.

is that what you mean?

@VeereshAradhya
Copy link

Yes. If it is present in operator section we can ignore this comment :)

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 19, 2023
@Dhruv-Soni11
Copy link
Contributor Author

Content from this PR has been merged in another PR due to a rebase conflict arising in this. Link for reference purposes is as follows: #54896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet