Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates regarding RHDEVDOCS-4758 #55298

Merged
merged 1 commit into from Jan 31, 2023

Conversation

shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Jan 30, 2023

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 30, 2023

🤖 Updated build preview is available at:
https://55298--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/7966

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@hemantsaini-7
Copy link

lgtm

Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shreya. Nice work. I've offered a couple of suggestions and related guidelines.


.Procedure

. In the *Administrator* perspective, navigate to *Administration* -> *Cluster Settings*.
. Select the *Configuration* tab and click the *Console (operator.openshift.io)* resource.
. Click *Actions* -> *Customize*.
. In the respective sections, enable or disable the items in the list.
. In the *Pre-pinned navigation items*, *Add page*, and *Developer Catalog* sections, enable or disable the items in the list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

Suggested change
. In the *Pre-pinned navigation items*, *Add page*, and *Developer Catalog* sections, enable or disable the items in the list.
. Enable or disable items in the *Pre-pinned navigation items*, *Add page*, and *Developer Catalog* sections.

@@ -27,6 +28,11 @@ image::odc_customizing_developer_catalog.png[]

[NOTE]
====
As an administrator, you can define which navigation items will display by default for all users. You can also reorder the navigation items.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As an administrator, you can define which navigation items will display by default for all users. You can also reorder the navigation items.
As an administrator, you can define the navigation items that appear by default for all users. You can also reorder the navigation items.
  • IBM Style: "Write in the simple present tense as much as possible."
  • IBM Style: "display verb: Use only as a transitive verb. For example, write "the system displays a message" or "the message is displayed" (not "the message displays")."

@rolfedh
Copy link
Contributor

rolfedh commented Jan 31, 2023

Pre-approved to expedite.

@bburt-rh bburt-rh added peer-review-done Signifies that the peer review team has reviewed this PR dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs qe-approved Signifies that QE has signed off on this PR branch/enterprise-4.13 labels Jan 31, 2023
@bburt-rh bburt-rh merged commit bd2f1d1 into openshift:main Jan 31, 2023
@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@bburt-rh: new pull request created: #55376

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bburt-rh bburt-rh added this to the Planned for 4.13 GA milestone Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.13 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants