Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS 7281: Adding pod security admission enforcement to the TechPr… #55880

Merged
merged 1 commit into from Mar 21, 2023
Merged

OCPBUGS 7281: Adding pod security admission enforcement to the TechPr… #55880

merged 1 commit into from Mar 21, 2023

Conversation

bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Feb 14, 2023 •
edited

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 14, 2023
@openshift-ci-robot
Copy link

@bergerhoffer: This pull request references Jira Issue OCPBUGS-7281, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…eviewNoUpgrade feature set

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-7281

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer changed the title OCPBUGS-7281: Adding pod security admission enforcement to the TechPr… OCPBUGS 7281: Adding pod security admission enforcement to the TechPr… Feb 14, 2023
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 14, 2023
@openshift-ci-robot
Copy link

@bergerhoffer: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

…eviewNoUpgrade feature set

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-7281

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer added this to the Continuous Release milestone Feb 14, 2023
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 14, 2023 •
edited

🤖 Updated build preview is available at:
https://55880--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/11186

@bergerhoffer
Copy link
Contributor Author

@stlaz Can you please review when you get a chance?

Preview: https://55880--docspreview.netlify.app/openshift-enterprise/latest/nodes/clusters/nodes-cluster-enabling-features.html#nodes-cluster-enabling-features-about_nodes-cluster-enabling

@bergerhoffer bergerhoffer force-pushed the OCPBUGS-7281 branch 2 times, most recently from 82847ae to 2abafdf Compare March 1, 2023 14:27
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 1, 2023
@stlaz
Copy link
Member

stlaz commented Mar 1, 2023

lgtm!

@bergerhoffer bergerhoffer added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 1, 2023
@bergerhoffer
Copy link
Contributor Author

@gkarager Can you please QE review?

Preview: https://55880--docspreview.netlify.app/openshift-enterprise/latest/nodes/clusters/nodes-cluster-enabling-features.html#nodes-cluster-enabling-features-about_nodes-cluster-enabling

We will wait to merge this until whatever z-stream this lands in goes out

@ousleyp ousleyp added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 1, 2023
@mburke5678
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2023
ousleyp
ousleyp reviewed Mar 1, 2023
View reviewed changes
Copy link
Member

@ousleyp ousleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes LGTM, but there are a couple of things you might want to fix while you're in here, and one suggestion for future improvements. Thanks!

modules/nodes-cluster-enabling-features-about.adoc Outdated Show resolved Hide resolved
modules/nodes-cluster-enabling-features-about.adoc Show resolved Hide resolved
modules/nodes-cluster-enabling-features-about.adoc Show resolved Hide resolved
@ousleyp ousleyp added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 1, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2023

New changes are detected. LGTM label has been removed.

@bergerhoffer
Copy link
Contributor Author

@gkarager Updated, let me know how it looks to you now. Thanks!

@gkarager
Copy link

/lgtm from QE

@bergerhoffer bergerhoffer merged commit 9c59279 into openshift:main Mar 21, 2023
1 check passed
@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 21, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #57479

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer mentioned this pull request Apr 18, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlaz stlaz stlaz left review comments

@ousleyp ousleyp ousleyp left review comments

@gkarager gkarager gkarager left review comments

Assignees

@mburke5678 mburke5678

Labels
branch/enterprise-4.13 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@bergerhoffer @openshift-ci-robot @ocpdocs-previewbot @stlaz @mburke5678 @gkarager @openshift-cherrypick-robot @ousleyp