Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document GitOps v1.8 RN #55921

Merged
merged 1 commit into from Mar 16, 2023
Merged

Document GitOps v1.8 RN #55921

merged 1 commit into from Mar 16, 2023

Conversation

Srivaralakshmi
Copy link
Member

@Srivaralakshmi Srivaralakshmi commented Feb 15, 2023 •
edited

RHDEVDOCS-4961: GitOps 1.8 release notes
RHDEVDOCS-5030: Update instances of kam to reflect the correct usage

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 15, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 15, 2023 •
edited

🤖 Updated build preview is available at:
https://55921--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/11190

@Srivaralakshmi
Copy link
Member Author

Hi @iam-veeramalla @jaideepr97 @varshab1210: PTAL at this PR and provide feedback. Thanks!

@Srivaralakshmi
Copy link
Member Author

Hi @jaideepr97: PTAL at the revised PR and provide your feedback. Thanks!

@jaideepr97
Copy link

LGTM after we address @varshab1210's point

@Srivaralakshmi
Copy link
Member Author

Srivaralakshmi commented Feb 16, 2023 •
edited

LGTM after we address @varshab1210's point

@jaideepr97 Thanks for the LGTM.

I have a question: I see that GITOPS-2459 is tagged with the release-note-item label and the Release Note Text on Jan 17, 2023. Given that, ideally, we link the issue that has these two aforementioned items with the OCP RN text items.

Request to help me understand better why we need to link this issue GITOPS-2457 instead.
CC: @varshab1210

@jaideepr97
Copy link

LGTM thanks @Srivaralakshmi

@varshab1210
Copy link

varshab1210 commented Feb 16, 2023 •
edited

LGTM
Thanks!

@Srivaralakshmi Srivaralakshmi changed the title Document GitOps v1.8 RN [WIP] Document GitOps v1.8 RN Feb 17, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2023
rolfedh
rolfedh approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rolfedh rolfedh added the peer-review-done Signifies that the peer review team has reviewed this PR label Feb 17, 2023
deerskindoll
deerskindoll approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Srivaralakshmi
Copy link
Member Author

@varshab1210 @jaideepr97 @iam-veeramalla @ciiay @rolfedh @deerskindoll : Requesting LGTM from you. Thanks!

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2023
@Srivaralakshmi Srivaralakshmi mentioned this pull request Mar 3, 2023
Merged
@harrietgrace
Copy link

Looking at the future timeline for OCP support and our 1.8 release, it looks like we'll need to support OCP 4.10 on that as well. OCP 4.10 will still be supported for a month after 1.7 goes EOL, and we need to have at least one supported version of GitOps on every supported version of OCP.

I've updated the component matrix on confluence with this addition, and for your reference here's the spreadsheet where I figure all this out: https://docs.google.com/spreadsheets/d/1uHORNoJR5nbx8Oa2bwCjOkht7ZvoQ9b2F514UG_Pe5c/edit#gid=114872730

Thanks for your patience with all these changes, I really appreciate your help @Srivaralakshmi! 🙇🏻

@Srivaralakshmi
Copy link
Member Author

@iam-veeramalla @harrietgrace @varshab1210 I have added the feature names for multiple resources and Application set Progressive rollout strategy to the OCP GitOps v1.8 RN TP table. Also added the Release note item for the Application set Progressive rollout strategy feature and included OCP 4.10 to the list of OCP versions. PTAL and provide feedback.

@iam-veeramalla
Copy link

@Srivaralakshmi Thanks for the release notes. A couple of things more need to be added.
GITOPS-1688 - Adds support to Run GitOps operator on ARM architecture -
@Regina Scott can you please add release notes item.
GITOPS-2570 - Please refer to the release note item section.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 9, 2023
@Srivaralakshmi
Copy link
Member Author

Srivaralakshmi commented Mar 9, 2023 •
edited

@Srivaralakshmi Thanks for the release notes. A couple of things more need to be added. GITOPS-1688 - Adds support to Run GitOps operator on ARM architecture - @Regina Scott can you please add release notes item. GITOPS-2570 - Please refer to the release note item section.

@iam-veeramalla , @reginapizza , @varshab1210 , @harrietgrace: I have added the feature name for the must-gather tool to the OCP GitOps v1.8 RN TP table. I also added the Release note item for GITOPS-1688 and GITOPS-2570.

PTAL at the revised PR and provide feedback.

@Srivaralakshmi
Copy link
Member Author

@iam-veeramalla , @reginapizza , @varshab1210 , @harrietgrace: Removed the must-gather content from RN.

Please provide LGTM to confirm and approve this RN and that there are no more incoming changes to the RN PR now. Thanks!

@Srivaralakshmi
Copy link
Member Author

Srivaralakshmi commented Mar 14, 2023 •
edited

@reginapizza Incorporated your comments. PTAL and approve.

@harrietgrace
Copy link

Looks good! 👍

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
@Srivaralakshmi
Copy link
Member Author

Srivaralakshmi commented Mar 15, 2023 •
edited

@varshab1210 , @iam-veeramalla, and @ciiay : Added the Known Issue. PTAL and approve.

@harrietgrace As per our discussion the last day, I have made the following changes in the TP table:

  • Removal of kam from TP table as it is a component and not a feature and is already captured in the matrix table
  • Update to TP table with GitOps versions

PTAL at the revised PR and approve.

shipsing
shipsing approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@shipsing shipsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
@varshab1210
Copy link

LGTM, Thanks @Srivaralakshmi

@harrietgrace
Copy link

Nice! Looks great, thanks @Srivaralakshmi!

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2023

New changes are detected. LGTM label has been removed.

@ciiay
Copy link

ciiay commented Mar 15, 2023

LGTM
Thanks @Srivaralakshmi 👏

@Srivaralakshmi
Document GitOps v1.8 RN
5a72be4 
Fixing nitpick

Fixing SME review comments

Minor updates

Fixing nitpicks

Fixing  usage

Minor edits to language

Adding new updates

Adding new updates

Adding kam to TP table

Removing must-gather content from RN

Fixing SME comments

Fixing nitpick

Fixing nitpick

Fixing peer-review ocmment

Adding Known issue for GITOPS-2736 and TP table modification to add GitOps versions and removing kam CLI out of TP table

Fixing SME comments
@Srivaralakshmi Srivaralakshmi changed the title [WIP] Document GitOps v1.8 RN Document GitOps v1.8 RN Mar 15, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2023
@rolfedh rolfedh merged commit e99c383 into openshift:main Mar 16, 2023
1 check passed
@rolfedh
Copy link
Contributor

rolfedh commented Mar 16, 2023

/cherrypick enterprise-4.10

@rolfedh
Copy link
Contributor

rolfedh commented Mar 16, 2023

/cherrypick enterprise-4.11

@rolfedh
Copy link
Contributor

rolfedh commented Mar 16, 2023

/cherrypick enterprise-4.12

@rolfedh
Copy link
Contributor

rolfedh commented Mar 16, 2023

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 16, 2023
Merged
@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #57302

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 16, 2023
Merged
@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #57303

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 16, 2023
Merged
@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #57304

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 16, 2023
Merged
@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #57305

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrietgrace harrietgrace harrietgrace left review comments

@jaideepr97 jaideepr97 jaideepr97 left review comments

@iam-veeramalla iam-veeramalla iam-veeramalla left review comments

@varshab1210 varshab1210 varshab1210 left review comments

@rolfedh rolfedh rolfedh approved these changes

@ciiay ciiay ciiay approved these changes

@reginapizza reginapizza reginapizza approved these changes

@deerskindoll deerskindoll deerskindoll approved these changes

@shipsing shipsing shipsing approved these changes

Assignees

@iam-veeramalla iam-veeramalla

@shipsing shipsing

Labels
peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet