-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS-4861: Updated GitOps1.7 RN for an inaccuracy #55985
Conversation
@shipsing: This pull request references RHDEVDOCS-4861 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@shipsing: This pull request references RHDEVDOCS-4861 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@shipsing: This pull request references RHDEVDOCS-4861 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@shipsing: This pull request references RHDEVDOCS-4861 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/9160 |
@jaideepr97 @harrietgrace @wtam2018 @RickJWagner @varshab1210 @pmkovar @Preeticp, Could you please review this PR and share your feedback? Thanks |
@shipsing: This pull request references RHDEVDOCS-4861 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM thanks @shipsing |
LGTM |
@ishitasequeira Please confirm the correction is correct It changes quite a bit from the original note. |
/label px-approved |
LGTM! Thanks! |
/lgtm |
Looks good! |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shipsing PTAL at the suggestions. Thanks!
163e7de
to
4383685
Compare
Thank you @Srivaralakshmi, incorporated your suggestions. Could you please verify and confirm? |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shipsing Approved!
@shipsing: This pull request references RHDEVDOCS-4861 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.9 |
/cherrypick enterprise-4.10 |
/cherrypick enterprise-4.11 |
/cherrypick enterprise-4.12 |
/cherrypick enterprise-4.13 |
@bburt-rh: new pull request created: #56124 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bburt-rh: #55985 failed to apply on top of branch "enterprise-4.10":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bburt-rh: new pull request created: #56125 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bburt-rh: new pull request created: #56126 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bburt-rh: new pull request created: #56127 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Aligned team: Dev Tools
Purpose: To resolve the following issue:
https://issues.redhat.com/browse/RHDEVDOCS-4861
OCP version this PR applies to: enterprise 4.9 and later
Link to docs preview: https://55985--docspreview.netlify.app/openshift-enterprise/latest/cicd/gitops/gitops-release-notes.html#new-features-1-7-0_gitops-release-notes
Change Management
Need an ACK from Eng: @jaideepr97
Need an ACK from PM: @harrietgrace @wtam2018
Need an ACK from Product experience: @RickJWagner
Need an ACK from QE: @varshab1210
Need an ACK from DPM: @pmkovar
Need an ACK from CS: @Preeticp
Peer review: @Srivaralakshmi