Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-3790:CSI driver vol detach w/ non-graceful node shutdown #56093

Merged
merged 1 commit into from Apr 19, 2023
Merged

OSDOCS-3790:CSI driver vol detach w/ non-graceful node shutdown #56093

merged 1 commit into from Apr 19, 2023

Conversation

lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Feb 17, 2023 •
edited

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 17, 2023 •
edited by openshift-ci bot

@lpettyjo: This pull request references OSDOCS-3790 which is a valid jira issue.

In response to this:

Version(s): 4.13+

Issue:https://issues.redhat.com/browse/STOR-744

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 17, 2023
@lpettyjo lpettyjo added branch/enterprise-4.13 peer-review-needed Signifies that the peer review team needs to review this PR and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2023
@lpettyjo lpettyjo added this to the Planned for 4.13 GA milestone Feb 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 17, 2023 •
edited by openshift-ci bot

@lpettyjo: This pull request references OSDOCS-3790 which is a valid jira issue.

In response to this:

Version(s): 4.13+

Issue:https://issues.redhat.com/browse/STOR-744

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

PTAL: @jsafrane, @radeore, @gcharot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 17, 2023 •
edited by openshift-ci bot

@lpettyjo: This pull request references OSDOCS-3790 which is a valid jira issue.

In response to this:

Version(s): 4.13+

Issue:https://issues.redhat.com/browse/STOR-744

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

PTAL: @jsafrane, @radeore, @gcharot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 17, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 17, 2023 •
edited

🤖 Updated build preview is available at:
https://56093--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/13245

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 17, 2023 •
edited by openshift-ci bot

@lpettyjo: This pull request references OSDOCS-3790 which is a valid jira issue.

In response to this:

Version(s): 4.13+

Issue:https://issues.redhat.com/browse/STOR-744

Link to docs preview: https://56093--docspreview.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-vol-detach-non-graceful-shutdown.html

QE review:

  • QE has approved this change.

Additional information:

PTAL: @jsafrane, @radeore, @gcharot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoeAldinger
Copy link
Contributor

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 17, 2023
JoeAldinger
JoeAldinger reviewed Feb 20, 2023
View reviewed changes
Copy link
Contributor

@JoeAldinger JoeAldinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions; I hope they help. Let me know if you have any questions.

modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-overview.adoc Outdated Show resolved Hide resolved
modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc Outdated Show resolved Hide resolved
modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc Show resolved Hide resolved
modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc Outdated Show resolved Hide resolved
modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc Show resolved Hide resolved
modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc Outdated Show resolved Hide resolved
modules/persistent-storage-csi-vol-detach-non-graceful-shutdown-procedure.adoc Show resolved Hide resolved
@JoeAldinger
Copy link
Contributor

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 20, 2023
@jsafrane
Copy link
Contributor

lgtm from tech side

gcharot
gcharot reviewed Mar 31, 2023
View reviewed changes
_topic_maps/_topic_map.yml Outdated Show resolved Hide resolved
@gcharot
Copy link

gcharot commented Apr 5, 2023

LGTM

1 similar comment
@radeore
Copy link

radeore commented Apr 6, 2023

LGTM

@lpettyjo lpettyjo merged commit 98a6ab8 into openshift:main Apr 19, 2023
1 check passed
@lpettyjo
Copy link
Contributor Author

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 19, 2023
Merged
@openshift-cherrypick-robot
Copy link

@lpettyjo: new pull request created: #58997

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@lpettyjo: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.13 from head openshift-cherrypick-robot:cherry-pick-56093-to-enterprise-4.13: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-56093-to-enterprise-4.13."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@gcharot gcharot gcharot left review comments

@JoeAldinger JoeAldinger JoeAldinger left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.13 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
4.13 GA
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@lpettyjo @openshift-ci-robot @ocpdocs-previewbot @JoeAldinger @jsafrane @gcharot @radeore @openshift-cherrypick-robot