Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS#7608: iPXE for ZTP not default behaviour #56323

Merged
merged 1 commit into from
Mar 14, 2023
Merged

OCPBUGS#7608: iPXE for ZTP not default behaviour #56323

merged 1 commit into from
Mar 14, 2023

Conversation

rohennes
Copy link
Contributor

@rohennes rohennes commented Feb 22, 2023 •
edited

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 22, 2023 •
edited

🤖 Updated build preview is available at:
https://56323--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/11074

@rohennes rohennes mentioned this pull request Feb 28, 2023
Merged
1 task
@achuzhoy
Copy link

achuzhoy commented Mar 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2023
@rohennes
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 13, 2023
@lahinson
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 13, 2023
lahinson
lahinson reviewed Mar 13, 2023
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny comment. LGTM!

modules/ztp-installation-crs.adoc Outdated
@@ -22,7 +22,7 @@ The following table lists the installation CRs that are automatically applied by

|`BareMetalHost`
|Contains the connection information for the Baseboard Management Controller (BMC) of the target bare-metal host.
|Provides access to the BMC to load and boot the discovery image on the target server by using the Redfish protocol. ZTP supports iPXE and virtual media network booting.
|Provides access to the BMC to load and boot the discovery image on the target server by using the Redfish protocol.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|Provides access to the BMC to load and boot the discovery image on the target server by using the Redfish protocol.
|Provides access to the BMC to load and start the discovery image on the target server by using the Redfish protocol.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IBM Style Guide advises that we use "start" or "turn on" instead of "boot" where possible.

@lahinson
Copy link
Contributor

lahinson commented Mar 13, 2023 •
edited

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-needed Signifies that the peer review team needs to review this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 13, 2023
@lahinson
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 13, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 14, 2023

New changes are detected. LGTM label has been removed.

@rohennes
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 14, 2023
@sjhala-ccs sjhala-ccs added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.12 branch/enterprise-4.13 labels Mar 14, 2023
@sjhala-ccs sjhala-ccs added this to the Continuous Release milestone Mar 14, 2023
@sjhala-ccs sjhala-ccs removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 14, 2023
@sjhala-ccs sjhala-ccs removed the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 14, 2023
@sjhala-ccs sjhala-ccs merged commit 450c269 into openshift:main Mar 14, 2023
@sjhala-ccs
Copy link
Contributor

/cherrypick enterprise-4.12

@sjhala-ccs
Copy link
Contributor

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 14, 2023
Merged
@openshift-cherrypick-robot
Copy link

@sjhala-ccs: new pull request created: #57146

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 14, 2023
Merged
@openshift-cherrypick-robot
Copy link

@sjhala-ccs: new pull request created: #57147

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahinson lahinson lahinson left review comments

@carbonin carbonin carbonin approved these changes

Assignees

@achuzhoy achuzhoy

Labels
branch/enterprise-4.12 branch/enterprise-4.13 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rohennes @ocpdocs-previewbot @achuzhoy @lahinson @sjhala-ccs @openshift-cherrypick-robot @carbonin