Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSDOCS-5090]: GCP Confidential VM options #56348

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[OSDOCS-5090]: GCP Confidential VM options #56348

merged 1 commit into from
Mar 8, 2023

Conversation

jeana-redhat
Copy link
Contributor

@jeana-redhat jeana-redhat commented Feb 22, 2023 •
edited

Version(s):
4.13+

Issue:
OCPCLOUD-1889 | OSDOCS-5090

Link to docs preview:
Configuring Confidential VM options by using machine sets

QE review:

  • QE has approved this change.

Additional information:

  • Control plane machine set context that will use the cpmso condition version is not merged yet.
  • This covers the machineset side, Installer docs team will cover install-config setup.
  • Will squash commits after all reviews are in.

@jeana-redhat jeana-redhat added this to the Planned for 4.13 GA milestone Feb 22, 2023
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 22, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 22, 2023 •
edited

🤖 Updated build preview is available at:
https://56348--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/10612

@jeana-redhat jeana-redhat force-pushed the OSDOCS-5090-GCP-confidential-compute branch from f6830b3 to a580fae Compare February 28, 2023 10:11
eranco74
eranco74 reviewed Feb 28, 2023
View reviewed changes
Copy link

@eranco74 eranco74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Just a nit

modules/machineset-gcp-confidential-vm.adoc Outdated Show resolved Hide resolved
@jeana-redhat
Copy link
Contributor Author

@sunzhaohua2 PTAL when you can

@jeana-redhat jeana-redhat mentioned this pull request Feb 28, 2023
Merged
1 task
@sunzhaohua2
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2023
@jeana-redhat jeana-redhat added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 8, 2023
@bscott-rh
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 8, 2023
@bscott-rh
Copy link
Contributor

Content LGTM. I may come back to the creating-machineset-gcp assembly after I finish my install work and drop an xref such as "Additional resources, To enable confidential VMs during installation, see xref". WDYT?

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 8, 2023
@jeana-redhat
Copy link
Contributor Author

Thanks @bscott-rh! That sounds great to me.

@jeana-redhat jeana-redhat force-pushed the OSDOCS-5090-GCP-confidential-compute branch from 15a9ced to cc7faa4 Compare March 8, 2023 17:59
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 8, 2023

New changes are detected. LGTM label has been removed.

@jeana-redhat
Copy link
Contributor Author

squashed/refreshed for merge

@jeana-redhat jeana-redhat merged commit d8dfb15 into openshift:main Mar 8, 2023
@jeana-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 8, 2023
Merged
@openshift-cherrypick-robot
Copy link

@jeana-redhat: new pull request created: #56953

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranco74 eranco74 eranco74 left review comments

Assignees

@sunzhaohua2 sunzhaohua2

Labels
branch/enterprise-4.13 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
4.13 GA
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jeana-redhat @ocpdocs-previewbot @sunzhaohua2 @bscott-rh @openshift-cherrypick-robot @eranco74