Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-4985: Updated the matrix table to fill in identified gaps #56355

Merged
merged 1 commit into from Mar 6, 2023
Merged

RHDEVDOCS-4985: Updated the matrix table to fill in identified gaps #56355

merged 1 commit into from Mar 6, 2023

Conversation

shipsing
Copy link
Contributor

@shipsing shipsing commented Feb 23, 2023 •
edited

Aligned team: Dev Tools

Purpose: To resolve the following issues:
https://issues.redhat.com/browse/RHDEVDOCS-4985

OCP version this PR applies to: enterprise 4.9 and later

Link to docs preview: https://56355--docspreview.netlify.app/openshift-enterprise/latest/cicd/pipelines/op-release-notes.html#compatibility-support-matrix_op-release-notes

Change Management
Need an ACK from Eng: @savitaashture @concaf
Need an ACK from PM: @koustavsaha
Need an ACK from Product experience: @RickJWagner
Need an ACK from QE: @VeereshAradhya
Need an ACK from DPM: @pmkovar
Need an ACK from CS: @Preeticp

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 23, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 23, 2023 •
edited by openshift-ci bot

@shipsing: This pull request references RHDEVDOCS-4958 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools

Purpose: To resolve the following issues:
https://issues.redhat.com/browse/RHDEVDOCS-4985

OCP version this PR applies to: enterprise 4.9 and later

Link to docs preview:

Change Management
Need an ACK from Eng:
Need an ACK from PM:
Need an ACK from Product experience:
Need an ACK from QE:
Need an ACK from DPM:
Need an ACK from CS:

Peer review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 23, 2023 •
edited

🤖 Updated build preview is available at:
https://56355--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/10167

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 23, 2023 •
edited by openshift-ci bot

@shipsing: This pull request references RHDEVDOCS-4958 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools

Purpose: To resolve the following issues:
https://issues.redhat.com/browse/RHDEVDOCS-4985

OCP version this PR applies to: enterprise 4.9 and later

Link to docs preview: https://56355--docspreview.netlify.app/openshift-enterprise/latest/cicd/pipelines/op-release-notes.html#compatibility-support-matrix_op-release-notes

Change Management
Need an ACK from Eng: @vdemeester @savitaashture @concaf
Need an ACK from PM: @siamaksade
Need an ACK from Product experience: @RickJWagner
Need an ACK from QE: @VeereshAradhya @ppitonak
Need an ACK from DPM: @pmkovar
Need an ACK from CS: @Preeticp

Peer review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 23, 2023 •
edited by openshift-ci bot

@shipsing: This pull request references RHDEVDOCS-4958 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools

Purpose: To resolve the following issues:
https://issues.redhat.com/browse/RHDEVDOCS-4985

OCP version this PR applies to: enterprise 4.9 and later

Link to docs preview: https://56355--docspreview.netlify.app/openshift-enterprise/latest/cicd/pipelines/op-release-notes.html#compatibility-support-matrix_op-release-notes

Change Management
Need an ACK from Eng: @savitaashture @concaf
Need an ACK from PM: @siamaksade
Need an ACK from Product experience: @RickJWagner
Need an ACK from QE: @VeereshAradhya
Need an ACK from DPM: @pmkovar
Need an ACK from CS: @Preeticp

Peer review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shipsing
Copy link
Contributor Author

shipsing commented Feb 23, 2023 •
edited

@savitaashture @concaf @koustavsaha @RickJWagner @VeereshAradhya, Could you please review this PR and share your feedback? Thanks

shipsing
shipsing commented Feb 23, 2023
View reviewed changes
Copy link
Contributor Author

@shipsing shipsing left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipelines 1.9 entry in the matrix table shows the PAC value as 0.15.x (GA), but the page here: http://dashboard.apps.cicd.ospqa.com/releases/componentmatrix/ suggests the PAC value is 0.14.x (GA). So, the published RN and the matrix page need to be consistent. I guess we might need to update either of the two.

Also, Pipelines 1.8 is supported in OCP 4.10. So, manually cherrypicked Pipelines 1.8 RN to OCP 4.10.

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2023
@shipsing shipsing changed the title RHDEVDOCS-4958: Updated the matrix table to fill in identified gaps RHDEVDOCS-4985: Updated the matrix table to fill in identified gaps Feb 23, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 23, 2023 •
edited by openshift-ci bot

@shipsing: This pull request references RHDEVDOCS-4985 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools

Purpose: To resolve the following issues:
https://issues.redhat.com/browse/RHDEVDOCS-4985

OCP version this PR applies to: enterprise 4.9 and later

Link to docs preview: https://56355--docspreview.netlify.app/openshift-enterprise/latest/cicd/pipelines/op-release-notes.html#compatibility-support-matrix_op-release-notes

Change Management
Need an ACK from Eng: @savitaashture @concaf
Need an ACK from PM: @siamaksade
Need an ACK from Product experience: @RickJWagner
Need an ACK from QE: @VeereshAradhya
Need an ACK from DPM: @pmkovar
Need an ACK from CS: @Preeticp

Peer review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RickJWagner
Copy link

/label px-approved

Looks good.

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Feb 23, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2023
savitaashture
savitaashture reviewed Mar 2, 2023
View reviewed changes
Copy link

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 2, 2023 •
edited by openshift-ci bot

@shipsing: This pull request references RHDEVDOCS-4985 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools

Purpose: To resolve the following issues:
https://issues.redhat.com/browse/RHDEVDOCS-4985

OCP version this PR applies to: enterprise 4.9 and later

Link to docs preview: https://56355--docspreview.netlify.app/openshift-enterprise/latest/cicd/pipelines/op-release-notes.html#compatibility-support-matrix_op-release-notes

Change Management
Need an ACK from Eng: @savitaashture @concaf
Need an ACK from PM: @koustavsaha
Need an ACK from Product experience: @RickJWagner
Need an ACK from QE: @VeereshAradhya
Need an ACK from DPM: @pmkovar
Need an ACK from CS: @Preeticp

Peer review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Preeticp
Copy link
Contributor

Preeticp commented Mar 2, 2023

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 2, 2023 •
edited by openshift-ci bot

@shipsing: This pull request references RHDEVDOCS-4985 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools

Purpose: To resolve the following issues:
https://issues.redhat.com/browse/RHDEVDOCS-4985

OCP version this PR applies to: enterprise 4.9 and later

Link to docs preview: https://56355--docspreview.netlify.app/openshift-enterprise/latest/cicd/pipelines/op-release-notes.html#compatibility-support-matrix_op-release-notes

Change Management
Need an ACK from Eng: @savitaashture @concaf
Need an ACK from PM: @koustavsaha
Need an ACK from Product experience: @RickJWagner
Need an ACK from QE: @VeereshAradhya
Need an ACK from DPM: @pmkovar
Need an ACK from CS: @Preeticp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 2, 2023

New changes are detected. LGTM label has been removed.

@shipsing
Copy link
Contributor Author

shipsing commented Mar 3, 2023

@koustavsaha please review and approve the PR. Thanks

koustavsaha
koustavsaha approved these changes Mar 6, 2023
View reviewed changes
Copy link

@koustavsaha koustavsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@gabriel-rh gabriel-rh merged commit 1bae12a into openshift:main Mar 6, 2023
@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.13

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.12

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.11

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.10

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.9

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 6, 2023
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #56815

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 6, 2023
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #56816

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 6, 2023
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #56817

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@gabriel-rh: #56355 failed to apply on top of branch "enterprise-4.10":

Applying: RHDEVDOCS-4958: Updated the matrix table to fill in identified gaps
Using index info to reconstruct a base tree...
M	modules/op-release-notes-1-8.adoc
M	modules/op-tkn-pipelines-compatibility-support-matrix.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/op-tkn-pipelines-compatibility-support-matrix.adoc
CONFLICT (content): Merge conflict in modules/op-tkn-pipelines-compatibility-support-matrix.adoc
Auto-merging modules/op-release-notes-1-8.adoc
CONFLICT (content): Merge conflict in modules/op-release-notes-1-8.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHDEVDOCS-4958: Updated the matrix table to fill in identified gaps
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@gabriel-rh: #56355 failed to apply on top of branch "enterprise-4.9":

Applying: RHDEVDOCS-4958: Updated the matrix table to fill in identified gaps
Using index info to reconstruct a base tree...
A	modules/op-release-notes-1-8.adoc
M	modules/op-tkn-pipelines-compatibility-support-matrix.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/op-tkn-pipelines-compatibility-support-matrix.adoc
CONFLICT (content): Merge conflict in modules/op-tkn-pipelines-compatibility-support-matrix.adoc
CONFLICT (modify/delete): modules/op-release-notes-1-8.adoc deleted in HEAD and modified in RHDEVDOCS-4958: Updated the matrix table to fill in identified gaps. Version RHDEVDOCS-4958: Updated the matrix table to fill in identified gaps of modules/op-release-notes-1-8.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHDEVDOCS-4958: Updated the matrix table to fill in identified gaps
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 7, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@PuneetPunamiya PuneetPunamiya PuneetPunamiya left review comments

@koustavsaha koustavsaha koustavsaha approved these changes

@concaf concaf concaf approved these changes

@VeereshAradhya VeereshAradhya VeereshAradhya approved these changes

Assignees

@Preeticp Preeticp

Labels
branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. px-approved Signifies that Product Support has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet