Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-5199:AWS EFS cross account support #56409

Merged
merged 1 commit into from Apr 13, 2023
Merged

OSDOCS-5199:AWS EFS cross account support #56409

merged 1 commit into from Apr 13, 2023

Conversation

lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Feb 23, 2023 •
edited

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 23, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 23, 2023 •
edited by openshift-ci bot

@lpettyjo: This pull request references OSDOCS-5199 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 23, 2023
@lpettyjo lpettyjo added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.13 labels Feb 23, 2023
@lpettyjo lpettyjo added this to the Planned for 4.13 GA milestone Feb 23, 2023
@stevsmit stevsmit added peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 23, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 23, 2023 •
edited

🤖 Updated build preview is available at:
https://56409--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/14029

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 23, 2023 •
edited by openshift-ci bot

@lpettyjo: This pull request references OSDOCS-5199 which is a valid jira issue.

In response to this:

Version(s): 4.13+

Issue: https://issues.redhat.com/browse/STOR-990

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

PTAL: @jsafrane, @ropatil010, @gcharot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 23, 2023 •
edited by openshift-ci bot

@lpettyjo: This pull request references OSDOCS-5199 which is a valid jira issue.

In response to this:

Version(s): 4.13+

Issue: https://issues.redhat.com/browse/STOR-990

Link to docs preview: https://56409--docspreview.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-aws-efs.html#persistent-storage-csi-efs-cross-account_persistent-storage-csi-aws-efs

QE review:

  • QE has approved this change.

Additional information:

PTAL: @jsafrane, @ropatil010, @gcharot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GroceryBoyJr
Copy link
Contributor

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 23, 2023
GroceryBoyJr
GroceryBoyJr reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpettyjo only a few small nits. Great work!

modules/persistent-storage-csi-efs-cross-account.adoc Outdated Show resolved Hide resolved
modules/persistent-storage-csi-efs-cross-account.adoc Outdated Show resolved Hide resolved
modules/persistent-storage-csi-efs-cross-account.adoc Outdated Show resolved Hide resolved
modules/persistent-storage-csi-efs-cross-account.adoc Outdated Show resolved Hide resolved
@GroceryBoyJr
Copy link
Contributor

/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 23, 2023
@lpettyjo lpettyjo added the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 29, 2023
@jsafrane
Copy link
Contributor

jsafrane commented Apr 3, 2023

lgtm

@gcharot
Copy link

gcharot commented Apr 4, 2023

Need to address Rohit's comment otherwise LGTM thanks !

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 13, 2023 •
edited by openshift-ci bot

@lpettyjo: This pull request references OSDOCS-5199 which is a valid jira issue.

In response to this:

Version(s): 4.13+

Issue: https://issues.redhat.com/browse/STOR-990

Link to docs preview: https://56409--docspreview.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-aws-efs.html#persistent-storage-csi-efs-cross-account_persistent-storage-csi-aws-efs

QE review:

  • QE has approved this change.

Additional information:

PTAL: @jsafrane, @ropatil010, @gcharot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lpettyjo lpettyjo merged commit 8b3c24d into openshift:main Apr 13, 2023
1 check passed
@lpettyjo
Copy link
Contributor Author

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 13, 2023
Merged
@openshift-cherrypick-robot
Copy link

@lpettyjo: new pull request created: #58649

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@gcharot gcharot gcharot left review comments

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@ropatil010 ropatil010 ropatil010 left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.13 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
4.13 GA
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@lpettyjo @openshift-ci-robot @ocpdocs-previewbot @GroceryBoyJr @jsafrane @gcharot @openshift-cherrypick-robot @ropatil010 @stevsmit