Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHDEVDOCS-4842-how-to-configure-secrets-in-alertmanager #56427

Conversation

bburt-rh
Copy link
Contributor

@bburt-rh bburt-rh commented Feb 23, 2023

Summary: This PR explains how to configure Alertmanager to use secrets fpr authentication with endpoint receivers.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 23, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 23, 2023

🤖 Updated build preview is available at:
https://56427--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/10174

@bburt-rh bburt-rh force-pushed the RHDEVDOCS-4842-how-to-configure-secrets-in-alertmanager branch 3 times, most recently from b35a8cd to 8e28f3d Compare February 27, 2023 20:47
@bburt-rh bburt-rh force-pushed the RHDEVDOCS-4842-how-to-configure-secrets-in-alertmanager branch from 8e28f3d to b8fa0e2 Compare February 28, 2023 15:46

:_content-type: PROCEDURE
[id="monitoring-adding-a-secret-to-an-alertmanager-configuration_{context}"]
= Adding a secret to an Alertmanager configuration
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
= Adding a secret to an Alertmanager configuration
= Adding a secret to the Alertmanager configuration

Copy link

@juzhao juzhao Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the change is applied, we should also change the link in monitoring/configuring-the-monitoring-stack.adoc
except this suggestion, others are LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed per your suggestion.

@bburt-rh bburt-rh force-pushed the RHDEVDOCS-4842-how-to-configure-secrets-in-alertmanager branch from b8fa0e2 to 84c889b Compare March 1, 2023 13:56
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rolfedh rolfedh added peer-review-done Signifies that the peer review team has reviewed this PR dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs labels Mar 1, 2023
@bburt-rh bburt-rh force-pushed the RHDEVDOCS-4842-how-to-configure-secrets-in-alertmanager branch from 84c889b to e7bdc9e Compare March 2, 2023 13:17
Copy link
Member

@slashpai slashpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2023
@bburt-rh bburt-rh added the qe-approved Signifies that QE has signed off on this PR label Mar 2, 2023
@bburt-rh bburt-rh added this to the Planned for 4.13 GA milestone Mar 2, 2023
@bburt-rh bburt-rh merged commit 7464a63 into openshift:main Mar 2, 2023
@bburt-rh
Copy link
Contributor Author

bburt-rh commented Mar 2, 2023

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@bburt-rh: new pull request created: #56726

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bburt-rh bburt-rh deleted the RHDEVDOCS-4842-how-to-configure-secrets-in-alertmanager branch June 6, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.13 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants