Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-RHDEVDOCS-4304: shared resource updates for validating admission webhooks #56497

Merged
merged 1 commit into from Feb 28, 2023
Merged

OSDOCS-RHDEVDOCS-4304: shared resource updates for validating admission webhooks #56497

merged 1 commit into from Feb 28, 2023

Conversation

gabemontero
Copy link
Contributor

Version(s): 4.13

Issue:
https://issues.redhat.com/browse/RHDEVDOCS-4304
https://issues.redhat.com/browse/RHDEVDOCS-4338

/assign @rolfedh
@Preeticp FYI

per prior discussion with @Preeticp I'm tagging @rolfedh to help get my doc contributions here over the finish line

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2023 •
edited by openshift-ci bot

@gabemontero: This pull request references RHDEVDOCS-4304 which is a valid jira issue.

In response to this:

Version(s): 4.13

Issue:
https://issues.redhat.com/browse/RHDEVDOCS-4304
https://issues.redhat.com/browse/RHDEVDOCS-4338

/assign @rolfedh
@Preeticp FYI

per prior discussion with @Preeticp I'm tagging @rolfedh to help get my doc contributions here over the finish line

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 27, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 27, 2023 •
edited

🤖 Updated build preview is available at:
https://56497--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/9848

rolfedh
rolfedh approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I've offered some suggestions for minor style issues. Thanks.

@gabemontero
Copy link
Contributor Author

Looks good to me! I've offered some suggestions for minor style issues. Thanks.

thanks @rolfedh .... I accepted all the suggestions as is except for #56497 (comment) .... are you ok with my addition there?

@gabemontero
Copy link
Contributor Author

ok only added in that one spot, commits squashed @rolfedh thanks

@gabemontero
Copy link
Contributor Author

ok only added in that one spot, commits squashed @rolfedh thanks

nope forgot the only :-)

@gabemontero
Copy link
Contributor Author

now only is there @rolfedh

@gabemontero
Copy link
Contributor Author

/assign @jitendar-singh

can you sign off on this per your testing a few weeks ago? thanks

@rolfedh rolfedh added the dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs label Feb 27, 2023
@jitendar-singh
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 28, 2023
@rolfedh rolfedh added branch/enterprise-4.13 peer-review-done Signifies that the peer review team has reviewed this PR labels Feb 28, 2023
@rolfedh rolfedh merged commit 0f9689c into openshift:main Feb 28, 2023
@rolfedh
Copy link
Contributor

rolfedh commented Feb 28, 2023

/cherry-pick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 28, 2023
Merged
@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #56547

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the rhdevdocs-4304-4338 branch February 28, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfedh rolfedh rolfedh approved these changes

Assignees

@rolfedh rolfedh

@jitendar-singh jitendar-singh

Labels
branch/enterprise-4.13 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gabemontero @openshift-ci-robot @ocpdocs-previewbot @jitendar-singh @rolfedh @openshift-cherrypick-robot