Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSM-3412: Service Mesh 2.3.2 z stream release notes #56501

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2023

@gwynnemonahan: This pull request references OSSM-3412 which is a valid jira issue.

In response to this:

Version(s):
4.9+

Issue:
https://issues.redhat.com/browse/OSSM-3412

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 27, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 27, 2023

🤖 Updated build preview is available at:
https://56501--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/12040

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2023

@gwynnemonahan: This pull request references OSSM-3412 which is a valid jira issue.

In response to this:

Version(s):
4.9+

Issue:
https://issues.redhat.com/browse/OSSM-3412

Link to docs preview:
https://56501--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/servicemesh-release-notes.html#new-features-red-hat-openshift-service-mesh-version-2-3-2

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2023

@gwynnemonahan: This pull request references OSSM-3412 which is a valid jira issue.

In response to this:

Version(s):
4.9+

Issue:
https://issues.redhat.com/browse/OSSM-3412

Link to docs preview:
New Features: https://56501--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/servicemesh-release-notes.html#new-features-red-hat-openshift-service-mesh-version-2-3-2

Fixed Issues: https://56501--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/servicemesh-release-notes.html#ossm-rn-fixed-issues-ossm_ossm-release-notes

Deprecated Features: https://56501--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/servicemesh-release-notes.html#deprecated-and-removed-features-red-hat-openshift-service-mesh-2-3-2

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2023

@gwynnemonahan: This pull request references OSSM-3412 which is a valid jira issue.

In response to this:

Version(s):
4.9+

Issue:
https://issues.redhat.com/browse/OSSM-3412

Link to docs preview:
New Features: https://56501--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/servicemesh-release-notes.html#new-features-red-hat-openshift-service-mesh-version-2-3-2

Fixed Issues: https://56501--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/servicemesh-release-notes.html#ossm-rn-fixed-issues-ossm_ossm-release-notes

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2023

@gwynnemonahan: This pull request references OSSM-3412 which is a valid jira issue.

In response to this:

Version(s):
4.9+

Issue:
https://issues.redhat.com/browse/OSSM-3412

Link to docs preview:
New Features: https://56501--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/servicemesh-release-notes.html#new-features-red-hat-openshift-service-mesh-version-2-3-2

Fixed Issues: https://56501--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/servicemesh-release-notes.html#ossm-rn-fixed-issues-ossm_ossm-release-notes

Specific Fixed Issues to review for this release:

OSSM-2493
OSSM-2492
OSSM-2374
OSSM-2373
OSSM-2371

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2023

@gwynnemonahan: This pull request references OSSM-3412 which is a valid jira issue.

In response to this:

Version(s):
4.9+

Issue:
https://issues.redhat.com/browse/OSSM-3412

Link to docs preview:
New Features: https://56501--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/servicemesh-release-notes.html#new-features-red-hat-openshift-service-mesh-version-2-3-2

Fixed Issues: https://56501--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/servicemesh-release-notes.html#ossm-rn-fixed-issues-ossm_ossm-release-notes

Specific Fixed Issues to review for this release:

OSSM-2493
OSSM-2492
OSSM-2374
OSSM-2373
OSSM-2371

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gwynnemonahan gwynnemonahan force-pushed the OSSM-3412 branch 5 times, most recently from 383a3c7 to 3bc330b Compare March 16, 2023 21:07
@fjglira
Copy link

fjglira commented Mar 17, 2023

From QE LGTM

@leandroberetta
Copy link

leandroberetta commented Mar 17, 2023

Hi, @gwynnemonahan, I reviewed the Kiali issues and version and looks good to me.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 17, 2023

@gwynnemonahan: This pull request references OSSM-3412 which is a valid jira issue.

In response to this:

Version(s):
4.9+

Issue:
https://issues.redhat.com/browse/OSSM-3412

Link to docs preview:
New Features: https://56501--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/servicemesh-release-notes.html#new-features-red-hat-openshift-service-mesh-version-2-3-2

Fixed Issues: https://56501--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/servicemesh-release-notes.html#ossm-rn-fixed-issues-ossm_ossm-release-notes

Specific Fixed Issues to review for this release:

OSSM-2493
OSSM-2492
OSSM-2374
OSSM-2373
OSSM-2371

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gwynnemonahan gwynnemonahan force-pushed the OSSM-3412 branch 2 times, most recently from 83dc8d2 to 43d5394 Compare March 20, 2023 15:18
Copy link
Contributor

@luksa luksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments.

@@ -21,6 +21,18 @@ The following issues been resolved in the current release:

* https://issues.redhat.com/browse/OSSM-3025[OSSM-3025] Istiod sometimes fails to become ready. Sometimes, when a mesh contained many member namespaces, the Istiod pod did not become ready due to a deadlock within Istiod. The deadlock is now resolved and the pod now starts as expected.

* https://issues.redhat.com/browse/OSSM-2493[OSSM-2493] Default nodeSelector and tolerations in SMCP not passed to Kiali. The nodeSelector and tolerations you add to `SMCP.spec.runtime.defaults` are now passed to the Kiali resource.

* https://issues.redhat.com/browse/OSSM-2492[OSSM-2492] Default tolerations in SMCP not passed to Jaeger. The nodeSelector and tolerations you add to `SMCP.spec.runtime.defaults` are now passed to the Jaeger resource.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* https://issues.redhat.com/browse/OSSM-2492[OSSM-2492] Default tolerations in SMCP not passed to Jaeger. The nodeSelector and tolerations you add to `SMCP.spec.runtime.defaults` are now passed to the Jaeger resource.
* https://issues.redhat.com/browse/OSSM-2492[OSSM-2492] Default tolerations in SMCP not passed to Jaeger. The `nodeSelector` and `tolerations` you add to `SMCP.spec.runtime.defaults` are now passed to the Jaeger resource.


* https://issues.redhat.com/browse/OSSM-2492[OSSM-2492] Default tolerations in SMCP not passed to Jaeger. The nodeSelector and tolerations you add to `SMCP.spec.runtime.defaults` are now passed to the Jaeger resource.

* https://issues.redhat.com/browse/OSSM-2374[OSSM-2374] Deleting a SMM also deletes the SMMR in OpenShift Service Mesh. The Service Mesh operator no longer deletes the `ServiceMeshMemberRoll` resource when a `ServiceMeshMember` resource is removed manually.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be reworded. This bugfix is about an issue where the operator deleted the ServiceMeshMemberRoll when the user deleted one of the ServiceMeshMembers associated with it. While this is the expected behavior when you delete the last ServiceMeshMember, the operator erroneously deleted the ServiceMeshMemberRoll even when the deleted ServiceMeshMember wasn't the last. This is the issue that is now fixed.

@@ -15,11 +15,33 @@ Module included in the following assemblies:

This release adds improvements related to the following components and concepts.

== New features {SMProductName} version 2.3.2

This release of {SMProductName} introduces new features, addresses Common Vulnerabilities and Exposures (CVEs), contains bug fixes, and is supported on {product-title} 4.9 or later.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we introduced any new features. It's only bug and CVE fixes. But I'd like others to confirm.

Copy link
Contributor

@luksa luksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -21,6 +21,18 @@ The following issues been resolved in the current release:

* https://issues.redhat.com/browse/OSSM-3025[OSSM-3025] Istiod sometimes fails to become ready. Sometimes, when a mesh contained many member namespaces, the Istiod pod did not become ready due to a deadlock within Istiod. The deadlock is now resolved and the pod now starts as expected.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add the backticks to nodeSelector and tolerations

@@ -133,8 +133,8 @@ endif::[]
:product-dedicated: Red Hat OpenShift Dedicated
:SMProductName: Red Hat OpenShift Service Mesh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the MaistraVersion and the SMProductVersion are both content variables, they are used in different places and serve slightly different purposes. The MaistraVersion should remain 2.3 or some code examples won't work.

I know this is confusing as you're learning :)

@gwynnemonahan gwynnemonahan force-pushed the OSSM-3412 branch 6 times, most recently from f568f9d to a4fd58e Compare March 23, 2023 15:14
Rebasing after conflict resolution with v2.3.2 in common-attributes.
@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.13

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.12

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.11

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.10

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.9

@openshift-cherrypick-robot

@gabriel-rh: new pull request created: #57726

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@gabriel-rh: new pull request created: #57727

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@gabriel-rh: new pull request created: #57728

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@gabriel-rh: new pull request created: #57729

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@gabriel-rh: new pull request created: #57730

In response to this:

/cherry-pick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gwynnemonahan gwynnemonahan deleted the OSSM-3412 branch April 27, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants