-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM-3412: Service Mesh 2.3.2 z stream release notes #56501
Conversation
@gwynnemonahan: This pull request references OSSM-3412 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/12040 |
5ec5380
to
3514352
Compare
@gwynnemonahan: This pull request references OSSM-3412 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fc39a3f
to
70557d3
Compare
@gwynnemonahan: This pull request references OSSM-3412 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
72462eb
to
9d8dccd
Compare
@gwynnemonahan: This pull request references OSSM-3412 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gwynnemonahan: This pull request references OSSM-3412 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@gwynnemonahan: This pull request references OSSM-3412 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
383a3c7
to
3bc330b
Compare
From QE LGTM |
Hi, @gwynnemonahan, I reviewed the Kiali issues and version and looks good to me. |
@gwynnemonahan: This pull request references OSSM-3412 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
83dc8d2
to
43d5394
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments.
modules/ossm-rn-fixed-issues.adoc
Outdated
@@ -21,6 +21,18 @@ The following issues been resolved in the current release: | |||
|
|||
* https://issues.redhat.com/browse/OSSM-3025[OSSM-3025] Istiod sometimes fails to become ready. Sometimes, when a mesh contained many member namespaces, the Istiod pod did not become ready due to a deadlock within Istiod. The deadlock is now resolved and the pod now starts as expected. | |||
|
|||
* https://issues.redhat.com/browse/OSSM-2493[OSSM-2493] Default nodeSelector and tolerations in SMCP not passed to Kiali. The nodeSelector and tolerations you add to `SMCP.spec.runtime.defaults` are now passed to the Kiali resource. | |||
|
|||
* https://issues.redhat.com/browse/OSSM-2492[OSSM-2492] Default tolerations in SMCP not passed to Jaeger. The nodeSelector and tolerations you add to `SMCP.spec.runtime.defaults` are now passed to the Jaeger resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* https://issues.redhat.com/browse/OSSM-2492[OSSM-2492] Default tolerations in SMCP not passed to Jaeger. The nodeSelector and tolerations you add to `SMCP.spec.runtime.defaults` are now passed to the Jaeger resource. | |
* https://issues.redhat.com/browse/OSSM-2492[OSSM-2492] Default tolerations in SMCP not passed to Jaeger. The `nodeSelector` and `tolerations` you add to `SMCP.spec.runtime.defaults` are now passed to the Jaeger resource. |
modules/ossm-rn-fixed-issues.adoc
Outdated
|
||
* https://issues.redhat.com/browse/OSSM-2492[OSSM-2492] Default tolerations in SMCP not passed to Jaeger. The nodeSelector and tolerations you add to `SMCP.spec.runtime.defaults` are now passed to the Jaeger resource. | ||
|
||
* https://issues.redhat.com/browse/OSSM-2374[OSSM-2374] Deleting a SMM also deletes the SMMR in OpenShift Service Mesh. The Service Mesh operator no longer deletes the `ServiceMeshMemberRoll` resource when a `ServiceMeshMember` resource is removed manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be reworded. This bugfix is about an issue where the operator deleted the ServiceMeshMemberRoll when the user deleted one of the ServiceMeshMembers associated with it. While this is the expected behavior when you delete the last ServiceMeshMember, the operator erroneously deleted the ServiceMeshMemberRoll even when the deleted ServiceMeshMember wasn't the last. This is the issue that is now fixed.
modules/ossm-rn-new-features.adoc
Outdated
@@ -15,11 +15,33 @@ Module included in the following assemblies: | |||
|
|||
This release adds improvements related to the following components and concepts. | |||
|
|||
== New features {SMProductName} version 2.3.2 | |||
|
|||
This release of {SMProductName} introduces new features, addresses Common Vulnerabilities and Exposures (CVEs), contains bug fixes, and is supported on {product-title} 4.9 or later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we introduced any new features. It's only bug and CVE fixes. But I'd like others to confirm.
dd3ec3b
to
1974169
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -21,6 +21,18 @@ The following issues been resolved in the current release: | |||
|
|||
* https://issues.redhat.com/browse/OSSM-3025[OSSM-3025] Istiod sometimes fails to become ready. Sometimes, when a mesh contained many member namespaces, the Istiod pod did not become ready due to a deadlock within Istiod. The deadlock is now resolved and the pod now starts as expected. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add the backticks to nodeSelector and tolerations
- https://issues.redhat.com/browse/OSSM-2493[OSSM-2493] Default
nodeSelector
andtolerations
in SMCP not passed to Kiali. The nodeSelector and tolerations you add toSMCP.spec.runtime.defaults
are now passed to the Kiali resource.
@@ -133,8 +133,8 @@ endif::[] | |||
:product-dedicated: Red Hat OpenShift Dedicated | |||
:SMProductName: Red Hat OpenShift Service Mesh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the MaistraVersion and the SMProductVersion are both content variables, they are used in different places and serve slightly different purposes. The MaistraVersion should remain 2.3 or some code examples won't work.
I know this is confusing as you're learning :)
f568f9d
to
a4fd58e
Compare
Rebasing after conflict resolution with v2.3.2 in common-attributes.
a4fd58e
to
14e8abb
Compare
/cherry-pick enterprise-4.13 |
/cherry-pick enterprise-4.12 |
/cherry-pick enterprise-4.11 |
/cherry-pick enterprise-4.10 |
/cherry-pick enterprise-4.9 |
@gabriel-rh: new pull request created: #57726 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gabriel-rh: new pull request created: #57727 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gabriel-rh: new pull request created: #57728 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gabriel-rh: new pull request created: #57729 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gabriel-rh: new pull request created: #57730 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
4.9+
Issue:
https://issues.redhat.com/browse/OSSM-3412
Link to docs preview:
New Features: https://56501--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/servicemesh-release-notes.html#new-features-red-hat-openshift-service-mesh-version-2-3-2
Fixed Issues: https://56501--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/servicemesh-release-notes.html#ossm-rn-fixed-issues-ossm_ossm-release-notes
Specific Fixed Issues to review for this release:
OSSM-2493
OSSM-2492
OSSM-2374
OSSM-2373
OSSM-2371
QE review:
Additional information: