Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHDEVDOCS-4365-new: Added a procedure to customize the Argo CD link #56632

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

shipsing
Copy link
Contributor

@shipsing shipsing commented Mar 1, 2023

Purpose: To resolve this issue: https://issues.redhat.com/browse/RHDEVDOCS-4365

Aligned team: DevTools

OCP versions this PR applies to: enterprise 4.10 and later

Content for preview: https://56632--docspreview.netlify.app/openshift-enterprise/latest/cicd/gitops/setting-up-argocd-instance.html#gitops-customize-argo-cd-consolelink_setting-up-argocd-instance

SME review: @reginapizza

QE review: @varshab1210

Peer review: @gabriel-rh

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 1, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 1, 2023

🤖 Updated build preview is available at:
https://56632--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/10259

@shipsing
Copy link
Contributor Author

shipsing commented Mar 1, 2023

@reginapizza @varshab1210, could you please review this PR and share your feedback? Also, please verify the OCP versions for cherrypicking. Thanks

@shipsing shipsing force-pushed the RHDEVDOCS-4365-new branch 2 times, most recently from 9b25f30 to bc90d00 Compare March 2, 2023 07:08
@varshab1210
Copy link

varshab1210 commented Mar 3, 2023

Hi @shipsing
Could you please also incorporate this change as well:
I see in the document,

6. To open the Argo CD web UI, click the route by navigating to Networking → Routes → <instance name> → server in the project where the Argo CD instance is installed.

Here, server should be preceded with a hyphen, not an arrow mark

<instance name>-server

@shipsing
Copy link
Contributor Author

shipsing commented Mar 3, 2023

Hi @shipsing Could you please also incorporate this change as well: I see in the document,

6. To open the Argo CD web UI, click the route by navigating to Networking → Routes → <instance name> → server in the project where the Argo CD instance is installed.

Here, server should be preceded with a hyphen, not an arrow mark

<instance name>-server

Incorporated this change

@varshab1210
Copy link

Thanks
LGTM

@reginapizza
Copy link
Contributor

Also LGTM! Thanks :)

Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.13

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.12

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.11

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.10

@openshift-cherrypick-robot

@gabriel-rh: new pull request created: #56869

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@gabriel-rh: new pull request created: #56870

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@gabriel-rh: new pull request created: #56871

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@gabriel-rh: new pull request created: #56872

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants