-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating content for Troubleshooting section in the GitOps 1.8 Release #56809
Conversation
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/11046 |
23e4acd
to
91dd145
Compare
91dd145
to
78112ea
Compare
78112ea
to
3a1c5b2
Compare
195c486
to
d0a55e0
Compare
/lgtm |
LGTM. Thanks |
con_performance-challenges-in-machine-configurations-and-argo-cd.adoc
Outdated
Show resolved
Hide resolved
cicd/gitops/preventing-auto-reboot-during-argo-cd-sync-with-machine-configurations.adoc
Outdated
Show resolved
Hide resolved
modules/performance-challenges-in-machine-configurations-and-argo-cd.adoc
Outdated
Show resolved
Hide resolved
con_performance-challenges-in-machine-configurations-and-argo-cd.adoc
Outdated
Show resolved
Hide resolved
Good, except for some nitpicks. |
@Dhruv-Soni11 i want to give a suggestion on a broad level. please change the assembly name to something generic so that we can cover a wider range of topis into it in future. Can we change the assembly name to something like: |
d0a55e0
to
b59bde7
Compare
New changes are detected. LGTM label has been removed. |
18d1f4c
to
9b6f5ac
Compare
9b6f5ac
to
2312045
Compare
Hey @themr0c, I have incorporated the comments you provided for the content. I have also made slight adjustments based on the suggestions provided by @shipsing which I feel increase the overall value of the content as well. Could you please have a look and provide your LGTM if everything now is as per your expectations? |
Thank you @Dhruv-Soni11 for looking into this comment |
/cherrypick enterprise-4.11 |
/cherrypick enterprise-4.12 |
/cherrypick enterprise-4.13 |
@rolfedh: new pull request created: #57338 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rolfedh: new pull request created: #57339 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rolfedh: new pull request created: #57340 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Purpose: To resolve the following issue:
https://issues.redhat.com/browse/RHDEVDOCS-3825
Aligned team: DevTools
OCP version this PR applies to (cherrypicking): enterprise 4.11 and later
Content for preview: https://56809--docspreview.netlify.app/openshift-enterprise/latest/cicd/gitops/preventing-auto-reboot-during-argo-cd-sync-with-machine-configurations.html
SME review : @iam-veeramalla
QE review: @varshab1210
Peer review: @themr0c