Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating content for Troubleshooting section in the GitOps 1.8 Release #56809

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented Mar 6, 2023

Purpose: To resolve the following issue:

https://issues.redhat.com/browse/RHDEVDOCS-3825

Aligned team: DevTools

OCP version this PR applies to (cherrypicking): enterprise 4.11 and later

Content for preview: https://56809--docspreview.netlify.app/openshift-enterprise/latest/cicd/gitops/preventing-auto-reboot-during-argo-cd-sync-with-machine-configurations.html

SME review : @iam-veeramalla

QE review: @varshab1210

Peer review: @themr0c

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 6, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 6, 2023

🤖 Updated build preview is available at:
https://56809--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/11046

@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-3825 branch 4 times, most recently from 23e4acd to 91dd145 Compare March 7, 2023 11:52
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 7, 2023
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2023
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 7, 2023
@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-3825 branch 4 times, most recently from 195c486 to d0a55e0 Compare March 7, 2023 13:02
@Dhruv-Soni11 Dhruv-Soni11 changed the title Creating content for GitOps 1.8 Release Creating content for Troubleshooting section in the GitOps 1.8 Release Mar 7, 2023
@iam-veeramalla
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2023
@varshab1210
Copy link

LGTM. Thanks

@themr0c
Copy link

themr0c commented Mar 10, 2023

Good, except for some nitpicks.

@shipsing
Copy link
Contributor

@Dhruv-Soni11 i want to give a suggestion on a broad level. please change the assembly name to something generic so that we can cover a wider range of topis into it in future. Can we change the assembly name to something like: Troubleshooting GitOps issues.
If you keep the current title Preventing auto-reboot during Argo CD sync with Machine Configurations, you make this assembly very specific, leaving out the scope for any future additions into this assembly. An assembly is usually a collection of multiple modules. If you keep the current assembly title, then we would not be able to add anything else into this assembly later, making the assembly stagnant for future.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2023

New changes are detected. LGTM label has been removed.

@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-3825 branch 7 times, most recently from 18d1f4c to 9b6f5ac Compare March 14, 2023 08:40
@Dhruv-Soni11
Copy link
Contributor Author

Dhruv-Soni11 commented Mar 14, 2023

Hey @themr0c, I have incorporated the comments you provided for the content. I have also made slight adjustments based on the suggestions provided by @shipsing which I feel increase the overall value of the content as well. Could you please have a look and provide your LGTM if everything now is as per your expectations?

@shipsing
Copy link
Contributor

@Dhruv-Soni11 i want to give a suggestion on a broad level. please change the assembly name to something generic so that we can cover a wider range of topis into it in future. Can we change the assembly name to something like: Troubleshooting GitOps issues. If you keep the current title Preventing auto-reboot during Argo CD sync with Machine Configurations, you make this assembly very specific, leaving out the scope for any future additions into this assembly. An assembly is usually a collection of multiple modules. If you keep the current assembly title, then we would not be able to add anything else into this assembly later, making the assembly stagnant for future.

Thank you @Dhruv-Soni11 for looking into this comment

@rolfedh rolfedh merged commit ab56279 into openshift:main Mar 17, 2023
@rolfedh
Copy link
Contributor

rolfedh commented Mar 17, 2023

/cherrypick enterprise-4.11

@rolfedh
Copy link
Contributor

rolfedh commented Mar 17, 2023

/cherrypick enterprise-4.12

@rolfedh
Copy link
Contributor

rolfedh commented Mar 17, 2023

/cherrypick enterprise-4.13

@rolfedh rolfedh added peer-review-done Signifies that the peer review team has reviewed this PR dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs qe-approved Signifies that QE has signed off on this PR branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 labels Mar 17, 2023
@openshift-cherrypick-robot

@rolfedh: new pull request created: #57338

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@rolfedh: new pull request created: #57339

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@rolfedh: new pull request created: #57340

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants