Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Bug Fix for 1.9.2 Pipelines RN #56810

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Added Bug Fix for 1.9.2 Pipelines RN #56810

merged 1 commit into from
Mar 6, 2023

Conversation

Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented Mar 6, 2023 •
edited

Purpose: To resolve the following issue:

https://issues.redhat.com/browse/RHDEVDOCS-5033

Aligned team: DevTools

OCP version this PR applies to (cherrypicking): enterprise 4.11 and later

Content for preview: https://56810--docspreview.netlify.app/openshift-enterprise/latest/cicd/pipelines/op-release-notes.html#release-notes-1-9-2_op-release-notes

SME review : @concaf

QE review: @ppitonak @VeereshAradhya

Peer review: @gabriel-rh

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 6, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 6, 2023 •
edited

🤖 Updated build preview is available at:
https://56810--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/10363

concaf
concaf approved these changes Mar 6, 2023
View reviewed changes
modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-5033 branch 2 times, most recently from a9fd43e to 20e4e63 Compare March 6, 2023 10:20
@Dhruv-Soni11
Copy link
Contributor Author

Dhruv-Soni11 commented Mar 6, 2023 •
edited

After deliberating over the inclusion of the advisory of the 1.9.1 Release Notes, I have also added the advisory content in the same PR. Kindly look at it in the same peer review. This has been done to avoid possible merge conflicts that may arise in the same file for multiple PR's.

gabriel-rh
gabriel-rh approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

modules/op-release-notes-1-9.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 6, 2023

New changes are detected. LGTM label has been removed.

@rolfedh rolfedh merged commit c80ce7a into openshift:main Mar 6, 2023
@rolfedh rolfedh added peer-review-done Signifies that the peer review team has reviewed this PR dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs qe-approved Signifies that QE has signed off on this PR branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 labels Mar 6, 2023
@rolfedh
Copy link
Contributor

rolfedh commented Mar 6, 2023

/cherrypick enterprise-4.11

@rolfedh
Copy link
Contributor

rolfedh commented Mar 6, 2023

/cherrypick enterprise-4.12

@rolfedh
Copy link
Contributor

rolfedh commented Mar 6, 2023

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 6, 2023
Merged
@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #56837

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 6, 2023
Merged
@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #56838

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 6, 2023
Merged
@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #56839

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@concaf concaf concaf approved these changes

@VeereshAradhya VeereshAradhya VeereshAradhya approved these changes

@gabriel-rh gabriel-rh gabriel-rh approved these changes

Assignees

@gabriel-rh gabriel-rh

Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Dhruv-Soni11 @ocpdocs-previewbot @rolfedh @openshift-cherrypick-robot @concaf @VeereshAradhya @gabriel-rh