Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS#9218: Editing note as mirroring is available for IPI too #57271

Merged
merged 1 commit into from Mar 21, 2023
Merged

OCPBUGS#9218: Editing note as mirroring is available for IPI too #57271

merged 1 commit into from Mar 21, 2023

Conversation

rohennes
Copy link
Contributor

@rohennes rohennes commented Mar 16, 2023 •
edited

OCPBUGS-9218: Updating note as mirroring is supported for IPI too.

Version(s):
4.9+

Issue:
https://issues.redhat.com/browse/OCPBUGS-9218

Link to docs preview:
https://57271--docspreview.netlify.app/openshift-enterprise/latest/installing/install_config/installing-customizing.html#installation-special-config-mirrored-disk_installing-customizing

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 16, 2023
@openshift-ci-robot
Copy link

@rohennes: This pull request references Jira Issue OCPBUGS-9218, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.8.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-9218: Updating note as mirroring is supported for IPI too.

Version(s):
4.9+

Issue:
https://issues.redhat.com/browse/OCPBUGS-9218

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 16, 2023
@rohennes rohennes changed the title OCPBUGS-9218: Editing note as mirroring is available for IPI too OCPBUGS#9218: Editing note as mirroring is available for IPI too Mar 16, 2023
@openshift-ci-robot openshift-ci-robot removed jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 16, 2023
@openshift-ci-robot
Copy link

@rohennes: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

OCPBUGS-9218: Updating note as mirroring is supported for IPI too.

Version(s):
4.9+

Issue:
https://issues.redhat.com/browse/OCPBUGS-9218

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 16, 2023
@ocpdocs-previewbot
Copy link

🤖 Build preview is available at:
https://57271--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/11273

@pamoedom
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 17, 2023
@elfosardo
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2023
@rohennes
Copy link
Contributor Author

/label peer-review-needed
/label telco

@openshift-ci openshift-ci bot added peer-review-needed Signifies that the peer review team needs to review this PR telco Label for all Telco PRs labels Mar 21, 2023
@kelbrown20 kelbrown20 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 21, 2023
kelbrown20
kelbrown20 reviewed Mar 21, 2023
View reviewed changes
Copy link
Contributor

@kelbrown20 kelbrown20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kelbrown20 kelbrown20 added this to the Continuous Release milestone Mar 21, 2023
@kelbrown20 kelbrown20 removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 21, 2023
@kelbrown20 kelbrown20 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 21, 2023
@rohennes
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 21, 2023
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Mar 21, 2023
@stevsmit
Copy link
Member

lgtm

@stevsmit stevsmit merged commit 5a1fbf4 into openshift:main Mar 21, 2023
1 check passed
@stevsmit
Copy link
Member

/cherry-pick enterprise-4.9

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.10

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.11

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.12

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.13

@openshift-cherrypick-robot
Copy link

@stevsmit: #57271 failed to apply on top of branch "enterprise-4.9":

Applying: OCPBUGS-9218: Editing note as mirroring is available for IPI too
Using index info to reconstruct a base tree...
M	modules/installation-special-config-storage.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-special-config-storage.adoc
CONFLICT (content): Merge conflict in modules/installation-special-config-storage.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-9218: Editing note as mirroring is available for IPI too
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@stevsmit: #57271 failed to apply on top of branch "enterprise-4.10":

Applying: OCPBUGS-9218: Editing note as mirroring is available for IPI too
Using index info to reconstruct a base tree...
M	modules/installation-special-config-storage.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-special-config-storage.adoc
CONFLICT (content): Merge conflict in modules/installation-special-config-storage.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-9218: Editing note as mirroring is available for IPI too
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@stevsmit: #57271 failed to apply on top of branch "enterprise-4.11":

Applying: OCPBUGS-9218: Editing note as mirroring is available for IPI too
Using index info to reconstruct a base tree...
M	modules/installation-special-config-storage.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-special-config-storage.adoc
CONFLICT (content): Merge conflict in modules/installation-special-config-storage.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-9218: Editing note as mirroring is available for IPI too
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 21, 2023
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #57480

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 21, 2023
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #57481

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 21, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelbrown20 kelbrown20 kelbrown20 left review comments

Assignees

@elfosardo elfosardo

@kelbrown20 kelbrown20

Labels
branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. telco Label for all Telco PRs
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rohennes @openshift-ci-robot @ocpdocs-previewbot @pamoedom @elfosardo @stevsmit @openshift-cherrypick-robot @kelbrown20