Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipelines as Code documentation for Pipelines 1.9 | Peer-review comment updates #57455

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Pipelines as Code documentation for Pipelines 1.9 | Peer-review comment updates #57455

merged 1 commit into from
Mar 23, 2023

Conversation

gtrivedi88
Copy link
Contributor

@gtrivedi88 gtrivedi88 commented Mar 21, 2023 •
edited

Original PR: #53813
OCP version for cherry-picking: enterprise-4.10, enterprise-4.11, enterprise-4.12, enterprise-4.13
SME Review: Completed
QE Review: Completed

Peer-Review: Comments addressed in this PR

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 21, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 21, 2023 •
edited

🤖 Updated build preview is available at:
https://57455--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/11734

@gtrivedi88 gtrivedi88 force-pushed the pac-for-1-9 branch 2 times, most recently from 770bf07 to d601f11 Compare March 21, 2023 06:47
@gtrivedi88 gtrivedi88 changed the title Pac for 1 9 Pipelines as Code documentation for Pipelines 1.9 | Peer-review comment updates Mar 21, 2023
@shipsing
Copy link
Contributor

@gtrivedi88 I found 2 more instances of tkn-pac in the assembly preview. Please change them to tkn pac like the one you see here: https://57455--docspreview.netlify.app/openshift-enterprise/latest/cicd/pipelines/using-pipelines-as-code.html#installing-pipelines-as-code-cli_using-pipelines-as-code

Also, In this section: https://57455--docspreview.netlify.app/openshift-enterprise/latest/cicd/pipelines/using-pipelines-as-code.html#customizing-pipel[…]pipelines-as-code, the casing of an instance of Bitbucket is not correct. Please check.

@shipsing
Copy link
Contributor

@gtrivedi88 Thank you for incorporating my comments. I have provided a few suggestions. Rest all looks good :)

@gtrivedi88 gtrivedi88 force-pushed the pac-for-1-9 branch 3 times, most recently from ed13dd3 to c1a592b Compare March 21, 2023 12:12
Srivaralakshmi
Srivaralakshmi requested changes Mar 21, 2023
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gtrivedi88 There was a huge number of review comments. Thanks for your effort in addressing all the changes and suggestions requested. Some of them were missed out - PTAL at my suggestions. Thanks again!

modules/op-creating-pipeline-run-using-pipelines-as-code.adoc Outdated Show resolved Hide resolved
modules/op-using-pipelines-as-code-with-github-webhook.adoc Outdated Show resolved Hide resolved
modules/op-using-pipelines-as-code-with-github-webhook.adoc Outdated Show resolved Hide resolved
modules/op-using-pipelines-as-code-with-gitlab.adoc Outdated Show resolved Hide resolved
modules/op-using-pipelines-as-code-with-bitbucket-cloud.adoc Outdated Show resolved Hide resolved
modules/op-using-pipelines-as-code-with-bitbucket-cloud.adoc Outdated Show resolved Hide resolved
modules/op-using-pipelines-as-code-with-bitbucket-cloud.adoc Outdated Show resolved Hide resolved
modules/op-using-private-repositories-with-pipelines-as-code.adoc Outdated Show resolved Hide resolved
modules/op-using-repository-crd-with-pipelines-as-code.adoc Outdated Show resolved Hide resolved
modules/op-using-repository-crd-with-pipelines-as-code.adoc Outdated Show resolved Hide resolved
Srivaralakshmi
Srivaralakshmi approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gtrivedi88: Thanks for the changes. Approved!

@Srivaralakshmi
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2023
@shipsing
Copy link
Contributor

tkn-pac

@gtrivedi88 There is still an instance of tkn-pac in this section: https://57455--docspreview.netlify.app/openshift-enterprise/latest/cicd/pipelines/using-pipelines-as-code.html#pac-key-features.

Please check. Rest all looks good.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2023
shipsing
shipsing approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@shipsing shipsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2023
This was referenced Mar 22, 2023
Closed
Merged
Merged
@rolfedh rolfedh merged commit ff6186e into openshift:main Mar 23, 2023
@rolfedh
Copy link
Contributor

rolfedh commented Mar 23, 2023

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 23, 2023
Merged
@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #57639

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rolfedh
Copy link
Contributor

rolfedh commented Mar 23, 2023

/cherrypick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 23, 2023
Merged
@openshift-cherrypick-robot
Copy link

@rolfedh: new pull request created: #57640

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rolfedh rolfedh added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs qe-approved Signifies that QE has signed off on this PR branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.13 branch/enterprise-4.12 peer-review-done Signifies that the peer review team has reviewed this PR labels Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Srivaralakshmi Srivaralakshmi Srivaralakshmi approved these changes

@shipsing shipsing shipsing approved these changes

Assignees

@Srivaralakshmi Srivaralakshmi

@shipsing shipsing

Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gtrivedi88 @ocpdocs-previewbot @shipsing @Srivaralakshmi @rolfedh @openshift-cherrypick-robot