Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-10270: Add a note that you have to include the default channel #57487

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Mar 21, 2023

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 21, 2023
@openshift-ci-robot
Copy link

@bergerhoffer: This pull request references Jira Issue OCPBUGS-10270, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.11.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@bergerhoffer: This pull request references Jira Issue OCPBUGS-10270, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.11.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OCPBUGS-10270

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer added this to the Continuous Release milestone Mar 21, 2023
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 21, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 21, 2023

🤖 Updated build preview is available at:
https://57487--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/12668

@openshift-ci-robot
Copy link

@bergerhoffer: This pull request references Jira Issue OCPBUGS-10270, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.11.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OCPBUGS-10270

Link to docs preview:
https://57487--docspreview.netlify.app/openshift-enterprise/latest/installing/disconnected_install/installing-mirroring-disconnected.html#oc-mirror-creating-image-set-config_installing-mirroring-disconnected

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer
Copy link
Contributor Author

@bergerhoffer
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 21, 2023
@michaelryanpeter
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 21, 2023
@michaelryanpeter
Copy link
Contributor

/lgtm
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 21, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2023
Copy link

@sherine-k sherine-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bergerhoffer
Sorry for the delay. I realise I never clicked the submit button!
Luckily github saved my comment!

<7> Specify only certain Operator packages and channels to include in the image set. Remove this field to retrieve all packages in the catalog.
<8> Specify any additional images to include in image set.
<7> Specify only certain Operator packages to include in the image set. Remove this field to retrieve all packages in the catalog.
<8> Specify only certain channels of the Operator packages to include in the image set. You must always include the default channel for the Operator package.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bergerhoffer
Can we add something like (please rephrase as you see fit):
"even when the bundles (versions) included in that default channel are of no interest to you"

I dont know if the term "bundle" makes sense to users for example.

We might also add a help to find the default channel for an operator package. This may be obtained by using the list command (opm also provides similar...):

oc-mirror list operators --catalog=registry.redhat.io/redhat/redhat-operator-index:v4.12 --package=elasticsearch-operator
NAME                    DISPLAY NAME                      DEFAULT CHANNEL
elasticsearch-operator  OpenShift Elasticsearch Operator  stable

PACKAGE                 CHANNEL     HEAD
elasticsearch-operator  stable      elasticsearch-operator.v5.6.3
elasticsearch-operator  stable-5.5  elasticsearch-operator.5.5.8
elasticsearch-operator  stable-5.6  elasticsearch-operator.v5.6.3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2023
Copy link

@sherine-k sherine-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Thanks @bergerhoffer

@zhouying7780
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2023
@openshift-ci-robot
Copy link

@bergerhoffer: This pull request references Jira Issue OCPBUGS-10270, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.11.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OCPBUGS-10270

Link to docs preview:
https://57487--docspreview.netlify.app/openshift-enterprise/latest/installing/disconnected_install/installing-mirroring-disconnected.html#oc-mirror-creating-image-set-config_installing-mirroring-disconnected

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer merged commit 849f694 into openshift:main Mar 30, 2023
@openshift-ci-robot
Copy link

@bergerhoffer: Jira Issue OCPBUGS-10270 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OCPBUGS-10270

Link to docs preview:
https://57487--docspreview.netlify.app/openshift-enterprise/latest/installing/disconnected_install/installing-mirroring-disconnected.html#oc-mirror-creating-image-set-config_installing-mirroring-disconnected

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.13

@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.12

@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #58018

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #58019

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #58020

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants