-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-10270: Add a note that you have to include the default channel #57487
Conversation
@bergerhoffer: This pull request references Jira Issue OCPBUGS-10270, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bergerhoffer: This pull request references Jira Issue OCPBUGS-10270, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/12668 |
106a7f6
to
9348af1
Compare
@bergerhoffer: This pull request references Jira Issue OCPBUGS-10270, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sherine-k Can you please review and let me know if this works for the note about the default channel being required? |
/label peer-review-needed |
/label peer-review-in-progress |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bergerhoffer
Sorry for the delay. I realise I never clicked the submit button!
Luckily github saved my comment!
<7> Specify only certain Operator packages and channels to include in the image set. Remove this field to retrieve all packages in the catalog. | ||
<8> Specify any additional images to include in image set. | ||
<7> Specify only certain Operator packages to include in the image set. Remove this field to retrieve all packages in the catalog. | ||
<8> Specify only certain channels of the Operator packages to include in the image set. You must always include the default channel for the Operator package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bergerhoffer
Can we add something like (please rephrase as you see fit):
"even when the bundles (versions) included in that default channel are of no interest to you"
I dont know if the term "bundle" makes sense to users for example.
We might also add a help to find the default channel for an operator package. This may be obtained by using the list command (opm also provides similar...):
oc-mirror list operators --catalog=registry.redhat.io/redhat/redhat-operator-index:v4.12 --package=elasticsearch-operator
NAME DISPLAY NAME DEFAULT CHANNEL
elasticsearch-operator OpenShift Elasticsearch Operator stable
PACKAGE CHANNEL HEAD
elasticsearch-operator stable elasticsearch-operator.v5.6.3
elasticsearch-operator stable-5.5 elasticsearch-operator.5.5.8
elasticsearch-operator stable-5.6 elasticsearch-operator.v5.6.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9348af1
to
551427e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Thanks @bergerhoffer
/lgtm |
@bergerhoffer: This pull request references Jira Issue OCPBUGS-10270, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bergerhoffer: Jira Issue OCPBUGS-10270 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.13 |
/cherrypick enterprise-4.12 |
/cherrypick enterprise-4.11 |
@bergerhoffer: new pull request created: #58018 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bergerhoffer: new pull request created: #58019 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bergerhoffer: new pull request created: #58020 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
4.11+
Issue:
https://issues.redhat.com/browse/OCPBUGS-10270
Link to docs preview:
https://57487--docspreview.netlify.app/openshift-enterprise/latest/installing/disconnected_install/installing-mirroring-disconnected.html#oc-mirror-creating-image-set-config_installing-mirroring-disconnected
QE review:
Additional information: