[OCPBUGS-3829]: Add etcd module from KCS article #57592

tmalove · 2023-03-22T19:22:01Z

Version(s): 4.9+

Link to docs preview (updated 3/28): http://file.rdu.redhat.com/tlove/etcd-ocpbugs-3829-tlove-new/scalability_and_performance/recommended-host-practices.html#move-etcd-different-disk_recommended-host-practices

QE review:

[ x] QE has approved this change.

Additional information: access.redhat.com/solutions/6973069
This Jira is to add the content from this KCS article to the docs.

ocpdocs-previewbot · 2023-03-22T19:29:30Z

🤖 Updated build preview is available at:
https://57592--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/12477

tmalove · 2023-03-23T01:17:37Z

@geliu2016 Will you /lgtm this module update? Thanks!

michaelalang · 2023-03-23T17:54:10Z

lgtm

openshift-ci · 2023-03-23T17:54:21Z

@michaelalang: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

geliu2016 · 2023-03-24T06:13:34Z

modules/move-etcd-different-disk.adoc

+$ oc replace -f etcd-mc.yml
+----
+
+The previous step prevents the nodes from rebooting.


@tmalove what means of "The previous step prevents the nodes from rebooting."? which previous step? thanks

I suppose it's "oc replace" step, exact?

geliu2016 · 2023-03-24T06:36:24Z

/lgtm if you may double confirm my question above, thanks

michaelalang · 2023-03-24T06:46:21Z

@geliu2016 it just seems to be a mis understanding from the original KCS mapping to the Docs ...

$ oc replace -f etcd-mc.yml
this step is expected to not cause a reboot of the nodes

https://access.redhat.com/solutions/6973069

geliu2016 · 2023-03-24T06:48:09Z

@geliu2016 it just seems to be a mis understanding from the original KCS mapping to the Docs ...
$ oc replace -f etcd-mc.yml
this step is expected to not cause a reboot of the nodes
https://access.redhat.com/solutions/6973069

Great to know, thank you, Michaela

tmalove · 2023-03-24T18:02:22Z

@geliu2016 @michaelalang I will move that sentence (about ...prevents the nodes from...) into Step 4, for clarity. Thanks!

lahinson

Nice work, Tami! I made a couple of very minor suggestions. Thanks for working on this one!

lahinson · 2023-03-27T19:55:29Z

modules/move-etcd-different-disk.adoc

+*  The `MachineConfigPool` must match `metadata.labels[“machineconfiguration.openshift.io/role]`. This applies to a controller, worker, or a custom pool.
+*  The node's auxiliary storage device, such as `/dev/sdb`, must match the sdb. Change this reference in all places in the file.
+
+NOTE: This procedure does not move parts of the root filesystem, such as /var/, to another disk or partition on an installed node.


Suggested change

NOTE: This procedure does not move parts of the root filesystem, such as /var/, to another disk or partition on an installed node.

[NOTE]

====

This procedure does not move parts of the root file system, such as /var/, to another disk or partition on an installed node.

====

lahinson · 2023-03-27T20:00:20Z

modules/move-etcd-different-disk.adoc

+$ oc login -u ${ADMIN} -p ${ADMINPASSWORD} ${API} [... output omitted ...] $ oc create -f etcd-mc.yml machineconfig.machineconfiguration.openshift.io/98-var-lib-etcd created
+----
+
+The nodes update and reboot. After the reboot completes, the following events occur:


Suggested change

The nodes update and reboot. After the reboot completes, the following events occur:

The nodes are updated and rebooted. After the reboot is completed, the following events occur:

A couple of minor suggestions here. Unless the nodes update and reboot themselves, I think we need to adjust the wording to indicate that they are updated and rebooted by some other entity.

tmalove · 2023-03-28T18:10:07Z

/label peer-review-needed

jldohmann

it's looking good! left some feedback below

jldohmann · 2023-03-28T18:45:01Z

modules/move-etcd-different-disk.adoc

+
+.Prerequisites
+
+*  The `MachineConfigPool` must match `metadata.labels[“machineconfiguration.openshift.io/role]`. This applies to a controller, worker, or a custom pool.


there's is a quotation mark here that is not closed:

Suggested change

* The `MachineConfigPool` must match `metadata.labels[“machineconfiguration.openshift.io/role]`. This applies to a controller, worker, or a custom pool.

* The `MachineConfigPool` must match `metadata.labels["machineconfiguration.openshift.io/role"]`. This applies to a controller, worker, or a custom pool.

or maybe it should be removed?

Suggested change

* The `MachineConfigPool` must match `metadata.labels[“machineconfiguration.openshift.io/role]`. This applies to a controller, worker, or a custom pool.

* The `MachineConfigPool` must match `metadata.labels[machineconfiguration.openshift.io/role]`. This applies to a controller, worker, or a custom pool.

jldohmann · 2023-03-28T18:47:19Z

modules/move-etcd-different-disk.adoc

+.Prerequisites
+
+*  The `MachineConfigPool` must match `metadata.labels[“machineconfiguration.openshift.io/role]`. This applies to a controller, worker, or a custom pool.
+*  The node's auxiliary storage device, such as `/dev/sdb`, must match the sdb. Change this reference in all places in the file.


is sdb a known abbreviation? ISG says to only use abbreviations if they're well known by the audience or the full form has been stated somewhere earlier in the text

@tmalove @jldohmann makes a good point. Is "sdb" well known to our storage audience or is it an acronym that must be defined?

sdb is the block device name (/storage/disk) presented to the VM/Instance available on the path /dev/sdb.
In the last generation instances in AWS those standards have been changed to /dev/nvme{0...9}*, or nvme{0...9}*

For reference: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/block-device-mapping-concepts.html

sdb is the block device name (/storage/disk) presented to the VM/Instance available on the path

Thanks @mtulio for the explanation. I will get you merged up @tmalove.

modules/move-etcd-different-disk.adoc

tmalove · 2023-03-29T00:50:55Z

/remove-label peer-review-done
/label merge-review-needed

mjpytlak · 2023-03-29T12:31:10Z

@tmalove For future reference, please do not remove peer-review-done. The squad uses that latter to make sure the peer review is complete ahead of a merge.

tmalove · 2023-03-29T18:45:09Z

@tmalove For future reference, please do not remove peer-review-done. The squad uses that latter to make sure the peer review is complete ahead of a merge.

Apologies @mjpytlak ...I have it in my 'smart reply'. I will remove it now.

mjpytlak · 2023-03-29T19:20:03Z

No worries @tmalove. However, ahead of a merge please address https://github.com/openshift/openshift-docs/pull/57592/files#r1151029235. Not sure if you intentionally left scb without defining it or missed Jessie's comment.

mjpytlak · 2023-03-29T21:16:12Z

/cherrypick enterprise-4.13

openshift-cherrypick-robot · 2023-03-29T21:17:03Z

@mjpytlak: new pull request created: #57980

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mjpytlak · 2023-03-29T21:19:12Z

/cherrypick enterprise-4.12

openshift-cherrypick-robot · 2023-03-29T21:19:59Z

@mjpytlak: new pull request created: #57981

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mjpytlak · 2023-03-29T21:20:54Z

/cherrypick enterprise-4.11

openshift-cherrypick-robot · 2023-03-29T21:21:40Z

@mjpytlak: new pull request created: #57982

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mjpytlak · 2023-03-29T21:21:54Z

/cherrypick enterprise-4.10

openshift-cherrypick-robot · 2023-03-29T21:22:40Z

@mjpytlak: new pull request created: #57983

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mjpytlak · 2023-03-29T21:23:02Z

/cherrypick enterprise-4.9

openshift-cherrypick-robot · 2023-03-29T21:23:45Z

@mjpytlak: #57592 failed to apply on top of branch "enterprise-4.9":

Applying: add module from KCS article
.git/rebase-apply/patch:146: trailing whitespace.
 [... output omitted ...] 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	scalability_and_performance/recommended-host-practices.adoc
Falling back to patching base and 3-way merge...
Auto-merging scalability_and_performance/recommended-host-practices.adoc
CONFLICT (content): Merge conflict in scalability_and_performance/recommended-host-practices.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add module from KCS article
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mjpytlak · 2023-03-29T21:24:53Z

@tmalove Looks like you have a conflict in 4.9. Please resolve it and give me a shout when the manual CP is ready to be merged. In the interim, I would get the other branches merged.

tmalove · 2023-03-29T22:29:28Z

@tmalove Looks like you have a conflict in 4.9. Please resolve it and give me a shout when the manual CP is ready to be merged. In the interim, I would get the other branches merged.

Will do, thanks!

openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 22, 2023

tmalove mentioned this pull request Mar 22, 2023

[OCPBUGS-3829]: Move etcd to a different disk for OpenShift 4 #56417

Closed

1 task

tmalove changed the title ~~[OCPBUGS-add module from KCS article~~ [OCPBUGS-3829]: Add etcd module from KCS article Mar 23, 2023

tmalove force-pushed the etcd-ocpbugs-3829-tlove-new branch from 1a85aae to 045145f Compare March 23, 2023 17:22

geliu2016 reviewed Mar 24, 2023

View reviewed changes

lahinson reviewed Mar 27, 2023

View reviewed changes

tmalove force-pushed the etcd-ocpbugs-3829-tlove-new branch 2 times, most recently from d020905 to b0a0380 Compare March 28, 2023 17:53

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 28, 2023

jldohmann added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 labels Mar 28, 2023

jldohmann added this to the Continuous Release milestone Mar 28, 2023

jldohmann reviewed Mar 28, 2023

View reviewed changes

jldohmann added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 28, 2023

tmalove force-pushed the etcd-ocpbugs-3829-tlove-new branch from b0a0380 to abd9049 Compare March 29, 2023 00:07

add module from KCS article

62ad012

tmalove force-pushed the etcd-ocpbugs-3829-tlove-new branch from b285146 to 62ad012 Compare March 29, 2023 00:49

openshift-ci bot added merge-review-needed Signifies that the merge review team needs to review this PR and removed peer-review-done Signifies that the peer review team has reviewed this PR labels Mar 29, 2023

mjpytlak added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 29, 2023

mjpytlak merged commit 60f33d9 into openshift:main Mar 29, 2023

openshift-cherrypick-robot mentioned this pull request Mar 29, 2023

[enterprise-4.13] [OCPBUGS-3829]: Add etcd module from KCS article #57980

Merged

openshift-cherrypick-robot mentioned this pull request Mar 29, 2023

[enterprise-4.12] [OCPBUGS-3829]: Add etcd module from KCS article #57981

Merged

openshift-cherrypick-robot mentioned this pull request Mar 29, 2023

[enterprise-4.11] [OCPBUGS-3829]: Add etcd module from KCS article #57982

Merged

openshift-cherrypick-robot mentioned this pull request Mar 29, 2023

[enterprise-4.10] [OCPBUGS-3829]: Add etcd module from KCS article #57983

Merged

ahardin-rh mentioned this pull request Mar 31, 2023

[enterprise-4.9]add module from KCS article #58074

Merged

	The nodes update and reboot. After the reboot completes, the following events occur:
	The nodes are updated and rebooted. After the reboot is completed, the following events occur:


		.Prerequisites

		* The `MachineConfigPool` must match `metadata.labels[“machineconfiguration.openshift.io/role]`. This applies to a controller, worker, or a custom pool.

[OCPBUGS-3829]: Add etcd module from KCS article #57592

[OCPBUGS-3829]: Add etcd module from KCS article #57592

Conversation

tmalove commented Mar 22, 2023 • edited

ocpdocs-previewbot commented Mar 22, 2023 • edited

tmalove commented Mar 23, 2023 • edited

michaelalang commented Mar 23, 2023 • edited

openshift-ci bot commented Mar 23, 2023

geliu2016 Mar 24, 2023

Choose a reason for hiding this comment

geliu2016 Mar 24, 2023

Choose a reason for hiding this comment

geliu2016 commented Mar 24, 2023

michaelalang commented Mar 24, 2023

geliu2016 commented Mar 24, 2023

tmalove commented Mar 24, 2023

lahinson left a comment

Choose a reason for hiding this comment

lahinson Mar 27, 2023

Choose a reason for hiding this comment

lahinson Mar 27, 2023

Choose a reason for hiding this comment

tmalove commented Mar 28, 2023

jldohmann left a comment

Choose a reason for hiding this comment

jldohmann Mar 28, 2023 • edited

Choose a reason for hiding this comment

jldohmann Mar 28, 2023

Choose a reason for hiding this comment

mjpytlak Mar 29, 2023 • edited

Choose a reason for hiding this comment

mtulio Mar 29, 2023

Choose a reason for hiding this comment

mjpytlak Mar 29, 2023

Choose a reason for hiding this comment

tmalove commented Mar 29, 2023

mjpytlak commented Mar 29, 2023

tmalove commented Mar 29, 2023

mjpytlak commented Mar 29, 2023 • edited

mjpytlak commented Mar 29, 2023

openshift-cherrypick-robot commented Mar 29, 2023

mjpytlak commented Mar 29, 2023

openshift-cherrypick-robot commented Mar 29, 2023

mjpytlak commented Mar 29, 2023

openshift-cherrypick-robot commented Mar 29, 2023

mjpytlak commented Mar 29, 2023

openshift-cherrypick-robot commented Mar 29, 2023

mjpytlak commented Mar 29, 2023

openshift-cherrypick-robot commented Mar 29, 2023

mjpytlak commented Mar 29, 2023

tmalove commented Mar 29, 2023

tmalove commented Mar 22, 2023 •

edited

ocpdocs-previewbot commented Mar 22, 2023 •

edited

tmalove commented Mar 23, 2023 •

edited

michaelalang commented Mar 23, 2023 •

edited

jldohmann Mar 28, 2023 •

edited

mjpytlak Mar 29, 2023 •

edited

mjpytlak commented Mar 29, 2023 •

edited