Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-10985: Adding the --max-nested-paths flag #57878

Merged
merged 1 commit into from Apr 11, 2023

Conversation

bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Mar 28, 2023

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-10985

Link to docs preview:
https://57878--docspreview.netlify.app/openshift-enterprise/latest/installing/disconnected_install/installing-mirroring-disconnected.html#oc-mirror-command-reference_installing-mirroring-disconnected

QE review:

  • QE has approved this change.

Additional information:
This should not be merged to 4.12 until 3 April, when 4.12.10 goes out

@bergerhoffer bergerhoffer added this to the Continuous Release milestone Mar 28, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 28, 2023
@openshift-ci-robot
Copy link

@bergerhoffer: This pull request references Jira Issue OCPBUGS-10985, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.12.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-10985

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This should not be merged to 4.12 until 3 April, when 4.12.10 goes out

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2023
@ocpdocs-previewbot
Copy link

@openshift-ci-robot
Copy link

@bergerhoffer: This pull request references Jira Issue OCPBUGS-10985, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.12.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-10985

Link to docs preview:
https://57878--docspreview.netlify.app/openshift-enterprise/latest/installing/disconnected_install/installing-mirroring-disconnected.html#oc-mirror-command-reference_installing-mirroring-disconnected

QE review:

  • QE has approved this change.

Additional information:
This should not be merged to 4.12 until 3 April, when 4.12.10 goes out

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer
Copy link
Contributor Author

@sherine-k @lmzuccarelli I just added the flag to the table. I couldn't find anywhere else where it seemed like this information was needed. Let me know if this is okay or if you think we need any other mentions of it.

Preview: https://57878--docspreview.netlify.app/openshift-enterprise/latest/installing/disconnected_install/installing-mirroring-disconnected.html#oc-mirror-command-reference_installing-mirroring-disconnected

@bergerhoffer
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 28, 2023
@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 28, 2023
@mburke5678
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2023
@zhouying7780
Copy link

/lgtm

@lmzuccarelli
Copy link

/lgtm

@lmzuccarelli
Copy link

@bergerhoffer - Agreed

@sherine-k @lmzuccarelli I just added the flag to the table. I couldn't find anywhere else where it seemed like this information was needed. Let me know if this is okay or if you think we need any other mentions of it.

Preview: https://57878--docspreview.netlify.app/openshift-enterprise/latest/installing/disconnected_install/installing-mirroring-disconnected.html#oc-mirror-command-reference_installing-mirroring-disconnected

Yes correct, not needed elsewhere. Thanks for the update

@zhouying7780
Copy link

/lgtm

@bergerhoffer
Copy link
Contributor Author

4.12.11 has shipped. Merging!

@bergerhoffer bergerhoffer merged commit aa8520b into openshift:main Apr 11, 2023
1 check passed
@openshift-ci-robot
Copy link

@bergerhoffer: Jira Issue OCPBUGS-10985 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-10985

Link to docs preview:
https://57878--docspreview.netlify.app/openshift-enterprise/latest/installing/disconnected_install/installing-mirroring-disconnected.html#oc-mirror-command-reference_installing-mirroring-disconnected

QE review:

  • QE has approved this change.

Additional information:
This should not be merged to 4.12 until 3 April, when 4.12.10 goes out

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.12

@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #58535

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #58536

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@bergerhoffer: Jira Issue OCPBUGS-10985 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-10985

Link to docs preview:
https://57878--docspreview.netlify.app/openshift-enterprise/latest/installing/disconnected_install/installing-mirroring-disconnected.html#oc-mirror-command-reference_installing-mirroring-disconnected

QE review:

  • QE has approved this change.

Additional information:
This should not be merged to 4.12 until 3 April, when 4.12.10 goes out

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.12 branch/enterprise-4.13 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants