Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-11817: Removing typo referencing iPXE for ZTP #58778

Merged
merged 1 commit into from
Apr 17, 2023
Merged

OCPBUGS-11817: Removing typo referencing iPXE for ZTP #58778

merged 1 commit into from
Apr 17, 2023

Conversation

rohennes
Copy link
Contributor

@rohennes rohennes commented Apr 17, 2023 •
edited

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 17, 2023
@openshift-ci-robot
Copy link

@rohennes: This pull request references Jira Issue OCPBUGS-11817, which is invalid:

  • expected Jira Issue OCPBUGS-11817 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Removing typo that added iPXE for ZTP reference to versions of OCP earlier than 4.12, this occurred in a re-org of the content.

Version(s):
4.11

Issue:
https://issues.redhat.com/browse/OCPBUGS-11817

Link to docs preview:

No QE needed for typo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 17, 2023
@rohennes
Copy link
Contributor Author

/label telco
/label peer-review-needed

@openshift-ci openshift-ci bot added telco Label for all Telco PRs peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 17, 2023
@ocpdocs-previewbot
Copy link

🤖 Build preview is available at:
https://58778--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/14221

@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 17, 2023
@mburke5678
Copy link
Contributor

mburke5678 commented Apr 17, 2023 •
edited

/lgtm Can you add a preview for the merge review?

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 17, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2023
@openshift-ci-robot
Copy link

@rohennes: This pull request references Jira Issue OCPBUGS-11817, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
  • expected Jira Issue OCPBUGS-11817 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Removing typo that added iPXE for ZTP reference to versions of OCP earlier than 4.12, this occurred in a re-org of the content.

Version(s):
4.11

Issue:
https://issues.redhat.com/browse/OCPBUGS-11817

Link to docs preview:

No QE needed for typo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rohennes
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 17, 2023
@jldohmann jldohmann added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.11 labels Apr 17, 2023
@jldohmann jldohmann added this to the Continuous Release milestone Apr 17, 2023
jldohmann
jldohmann approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jldohmann jldohmann merged commit 5f034dd into openshift:enterprise-4.11 Apr 17, 2023
1 check passed
@openshift-ci-robot
Copy link

@rohennes: Jira Issue OCPBUGS-11817 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

Removing typo that added iPXE for ZTP reference to versions of OCP earlier than 4.12, this occurred in a re-org of the content.

Version(s):
4.11

Issue:
https://issues.redhat.com/browse/OCPBUGS-11817

Link to docs preview:

No QE needed for typo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldohmann jldohmann removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jldohmann jldohmann jldohmann approved these changes

Assignees

@mburke5678 mburke5678

Labels
branch/enterprise-4.11 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. telco Label for all Telco PRs
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rohennes @openshift-ci-robot @ocpdocs-previewbot @mburke5678 @jldohmann