Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSM-3750: Incorrect default load balancing policy #58930

Merged
merged 1 commit into from Apr 19, 2023

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Apr 18, 2023

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 18, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2023

@rh-tokeefe: This pull request references OSSM-3750 which is a valid jira issue.

In response to this:

Version(s): 4.9+

Issue: https://issues.redhat.com/browse/OSSM-3750

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2023
@rh-tokeefe rh-tokeefe force-pushed the OSSM-3750 branch 2 times, most recently from 1dc99cb to 7374e53 Compare April 18, 2023 17:57
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 18, 2023

🤖 Updated build preview is available at:
https://58930--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/14501

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2023

@rh-tokeefe: This pull request references OSSM-3750 which is a valid jira issue.

In response to this:

Version(s): 4.9+

Issue: https://issues.redhat.com/browse/OSSM-3750

Link to docs preview: https://58930--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-traffic-manage.html#ossm-routing-destination-rules_traffic-management

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rh-tokeefe
Copy link
Contributor Author

@luksa and @pbajjuri20 please review the change for this defect. Thanks!

Copy link
Contributor

@luksa luksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not completely sure about "least requests" vs "least-request".

modules/ossm-routing-destination-rules.adoc Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2023

@rh-tokeefe: This pull request references OSSM-3750 which is a valid jira issue.

In response to this:

Version(s): 4.9+

Issue: https://issues.redhat.com/browse/OSSM-3750

Link to docs preview: https://58930--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-traffic-manage.html#ossm-routing-destination-rules_traffic-management

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rh-tokeefe rh-tokeefe force-pushed the OSSM-3750 branch 2 times, most recently from c9bcef4 to b148bb3 Compare April 19, 2023 16:33
@openshift-ci
Copy link

openshift-ci bot commented Apr 19, 2023

@rh-tokeefe: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gwynnemonahan
Copy link
Contributor

LGTM

@rh-tokeefe rh-tokeefe changed the title [WIP] OSSM-3750: Incorrect default load balancing policy OSSM-3750: Incorrect default load balancing policy Apr 19, 2023
@rolfedh
Copy link
Contributor

rolfedh commented Apr 19, 2023

Petr mentioned that 4.9 is EOL as of today.
https://redhat-internal.slack.com/archives/G01Q6LPP04S/p1681849120285319?thread_ts=1681829936.301389&cid=G01Q6LPP04S
Please update your PR description to specify 4.10 and later. Thanks!

@rolfedh rolfedh added peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 19, 2023
@rolfedh rolfedh merged commit 06c715e into openshift:main Apr 19, 2023
1 check passed
@rolfedh
Copy link
Contributor

rolfedh commented Apr 19, 2023

/cherrypick enterprise-4.10

@rolfedh
Copy link
Contributor

rolfedh commented Apr 19, 2023

/cherrypick enterprise-4.11

@rolfedh
Copy link
Contributor

rolfedh commented Apr 19, 2023

/cherrypick enterprise-4.12

@rolfedh
Copy link
Contributor

rolfedh commented Apr 19, 2023

/cherrypick enterprise-4.13

@rolfedh
Copy link
Contributor

rolfedh commented Apr 19, 2023

/cherrypick enterprise-4.9

@rolfedh
Copy link
Contributor

rolfedh commented Apr 19, 2023

/cherrypick enterprise-4.10

@openshift-cherrypick-robot

@rolfedh: new pull request created: #59035

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rolfedh
Copy link
Contributor

rolfedh commented Apr 19, 2023

/cherrypick enterprise-4.11

@rolfedh
Copy link
Contributor

rolfedh commented Apr 19, 2023

/cherrypick enterprise-4.12

@rolfedh
Copy link
Contributor

rolfedh commented Apr 19, 2023

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@rolfedh: new pull request created: #59036

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rolfedh
Copy link
Contributor

rolfedh commented Apr 19, 2023

/cherrypick enterprise-4.9

@openshift-cherrypick-robot

@rolfedh: new pull request created: #59037

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@rolfedh: new pull request created: #59038

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@rolfedh: new pull request created: #59039

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants