-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-9238: moving must-gather note #59230
Conversation
@skopacz1: This pull request references Jira Issue OCPBUGS-9238, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤖 Build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/14835 |
@skopacz1: This pull request references Jira Issue OCPBUGS-9238, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @QiaolingTang would you be the correct QE to review this PR? Could you either review this PR or tag the correct QE? Thanks! |
/lgtm |
@skopacz1 i am afraid the fix here is incorrect. In the doc link given in the description of the bug the text present in the important note does not make sense because the doc is related to mirroring and does not talk any think about must-gather. In my opinion the below should be removed from the important note. "f you are in a disconnected environment, use the --image flag as part of must-gather and point to the payload image." cc: @zhouying7780 |
Hi @kasturinarra, are you saying I should remove the comment about must-gather from the important note on the disconnected mirroring page? If so, here is where that important note is in the doc preview, where I've removed the comment about must-gather. Or do you mean that it was incorrect to add the must-gather note to the support page for gathering data about your cluster? |
@skopacz1 thanks for the link. For some reason this morning i did not have the page rendered correctly and the details were completely missing. Now it looks good to me !! Thanks !! |
/lgtm |
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Merging.
@skopacz1: Jira Issue OCPBUGS-9238 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.13 |
/cherrypick enterprise-4.12 |
/cherrypick enterprise-4.11 |
/cherrypick enterprise-4.10 |
@sheriff-rh: new pull request created: #59736 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sheriff-rh: new pull request created: #59737 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sheriff-rh: new pull request created: #59738 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sheriff-rh: new pull request created: #59739 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OCPBUGS-9238
Version(s):
4.10+
This PR moves a note about must gather out of mirroring documentation for disconnected installs, and into documentation for gathering data to provide to red hat support.
Link to docs preview:
https://59230--docspreview.netlify.app/openshift-enterprise/latest/support/gathering-cluster-data.html#support_gathering_data_gathering-cluster-data
QE review: