Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-9238: moving must-gather note #59230

Merged
merged 1 commit into from
May 9, 2023

Conversation

skopacz1
Copy link
Contributor

@skopacz1 skopacz1 commented Apr 24, 2023

OCPBUGS-9238

Version(s):
4.10+

This PR moves a note about must gather out of mirroring documentation for disconnected installs, and into documentation for gathering data to provide to red hat support.

Link to docs preview:
https://59230--docspreview.netlify.app/openshift-enterprise/latest/support/gathering-cluster-data.html#support_gathering_data_gathering-cluster-data

QE review:

  • QE has approved this change.

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 24, 2023
@openshift-ci-robot
Copy link

@skopacz1: This pull request references Jira Issue OCPBUGS-9238, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.6.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-9238

Version(s):
4.10+

This PR moves a note about must gather out of mirroring documentation for disconnected installs, and into documentation for gathering data to provide to red hat support.

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 24, 2023
@ocpdocs-previewbot
Copy link

@openshift-ci-robot
Copy link

@skopacz1: This pull request references Jira Issue OCPBUGS-9238, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.6.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

OCPBUGS-9238

Version(s):
4.10+

This PR moves a note about must gather out of mirroring documentation for disconnected installs, and into documentation for gathering data to provide to red hat support.

Link to docs preview:
https://59230--docspreview.netlify.app/openshift-enterprise/latest/support/gathering-cluster-data.html#support_gathering_data_gathering-cluster-data

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skopacz1
Copy link
Contributor Author

skopacz1 commented May 5, 2023

Hi @QiaolingTang would you be the correct QE to review this PR? Could you either review this PR or tag the correct QE? Thanks!

@QiaolingTang
Copy link

@skopacz1 Sorry, I can't review this PR. You can request review from the QA Contact of OCPBUGS-9238. @gpei

@gpei
Copy link

gpei commented May 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2023
@kasturinarra
Copy link

@skopacz1 i am afraid the fix here is incorrect.

In the doc link given in the description of the bug the text present in the important note does not make sense because the doc is related to mirroring and does not talk any think about must-gather. In my opinion the below should be removed from the important note.

"f you are in a disconnected environment, use the --image flag as part of must-gather and point to the payload image."

cc: @zhouying7780

@skopacz1
Copy link
Contributor Author

skopacz1 commented May 8, 2023

Hi @kasturinarra, are you saying I should remove the comment about must-gather from the important note on the disconnected mirroring page? If so, here is where that important note is in the doc preview, where I've removed the comment about must-gather.

Or do you mean that it was incorrect to add the must-gather note to the support page for gathering data about your cluster?

@kasturinarra
Copy link

@skopacz1 thanks for the link. For some reason this morning i did not have the page rendered correctly and the details were completely missing. Now it looks good to me !! Thanks !!

@kasturinarra
Copy link

/lgtm

@skopacz1
Copy link
Contributor Author

skopacz1 commented May 8, 2023

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 8, 2023
@snarayan-redhat snarayan-redhat added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 9, 2023
Copy link
Contributor

@snarayan-redhat snarayan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

modules/support-gather-data.adoc Show resolved Hide resolved
@snarayan-redhat snarayan-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 9, 2023
@skopacz1
Copy link
Contributor Author

skopacz1 commented May 9, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 9, 2023
@sheriff-rh sheriff-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels May 9, 2023
@sheriff-rh sheriff-rh added this to the Continuous Release milestone May 9, 2023
Copy link
Contributor

@sheriff-rh sheriff-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging.

@sheriff-rh sheriff-rh merged commit 97b1615 into openshift:main May 9, 2023
1 check passed
@openshift-ci-robot
Copy link

@skopacz1: Jira Issue OCPBUGS-9238 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

OCPBUGS-9238

Version(s):
4.10+

This PR moves a note about must gather out of mirroring documentation for disconnected installs, and into documentation for gathering data to provide to red hat support.

Link to docs preview:
https://59230--docspreview.netlify.app/openshift-enterprise/latest/support/gathering-cluster-data.html#support_gathering_data_gathering-cluster-data

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.13

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.12

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.11

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.10

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #59736

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #59737

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #59738

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #59739

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skopacz1 skopacz1 deleted the OCPBUGS-9238 branch October 31, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants