Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-658: VSB cleanup for OADP 1.1 #59894

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

RichardHoch
Copy link
Contributor

@RichardHoch RichardHoch commented May 11, 2023

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 11, 2023
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2023
@RichardHoch RichardHoch marked this pull request as ready for review May 18, 2023 09:22
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 18, 2023

🤖 Updated build preview is available at:
https://59894--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/17021

@RichardHoch
Copy link
Contributor Author

@akarol please review this PR.

@PrasadJoshi12
Copy link

lgtm

@RichardHoch RichardHoch force-pushed the vsb_cleanup branch 2 times, most recently from 7b9edd1 to 00cf646 Compare May 22, 2023 07:46
@RichardHoch RichardHoch changed the title VSB cleanup for OADP 1.1 enterprise-4.10+: VSB cleanup for OADP 1.1 May 22, 2023
@RichardHoch RichardHoch changed the title enterprise-4.10+: VSB cleanup for OADP 1.1 OADP-688: VSB cleanup for OADP 1.1 May 22, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 22, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2023

@RichardHoch: This pull request references OADP-688 which is a valid jira issue.

In response to this:

OADP 1.1.x, OCP 4.10+

Resolves https://issues.redhat.com/browse/OADP-658 by adding a new section, "Cleaning up after a backup using Data Mover with OADP 1.1.x" to the OADP user guide.

Preview: https://59894--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/backing_up_and_restoring/backing-up-applications.html#oadp-cleaning-up-after-data-mover-1-1-backup_backing-up-applications

Approved by OADP QE.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RichardHoch
Copy link
Contributor Author

/label OADP
/label peer-review-needed

@openshift-ci openshift-ci bot added OADP Label for all OADP PRs peer-review-needed Signifies that the peer review team needs to review this PR labels May 22, 2023
@RichardHoch RichardHoch changed the title OADP-688: VSB cleanup for OADP 1.1 OADP-658: VSB cleanup for OADP 1.1 May 22, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2023

@RichardHoch: This pull request references OADP-658 which is a valid jira issue.

In response to this:

OADP 1.1.x, OCP 4.10+

Resolves https://issues.redhat.com/browse/OADP-658 by adding a new section, "Cleaning up after a backup using Data Mover with OADP 1.1.x" to the OADP user guide.

Preview: https://59894--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/backing_up_and_restoring/backing-up-applications.html#oadp-cleaning-up-after-data-mover-1-1-backup_backing-up-applications

Approved by OADP QE.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer
Copy link
Contributor

/label peer-review-in-progress

@RichardHoch RichardHoch force-pushed the vsb_cleanup branch 3 times, most recently from e4ecc28 to aa064d7 Compare May 29, 2023 09:53
@RichardHoch
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 31, 2023
@RichardHoch
Copy link
Contributor Author

I fixed the items that @bergerhoffer requested; GA is 13 June.

@kelbrown20 kelbrown20 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 31, 2023
Copy link
Contributor

@kelbrown20 kelbrown20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, great work! Updates LGTM!
Merging.

@kelbrown20 kelbrown20 merged commit f573b75 into openshift:main May 31, 2023
1 check passed
@kelbrown20
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@kelbrown20: new pull request created: #60722

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kelbrown20
Copy link
Contributor

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@kelbrown20: new pull request created: #60723

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kelbrown20
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@kelbrown20: new pull request created: #60724

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kelbrown20
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@kelbrown20: new pull request created: #60725

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kelbrown20
Copy link
Contributor

/cherrypick enterprise-4.10

@openshift-cherrypick-robot

@kelbrown20: new pull request created: #60731

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kelbrown20 kelbrown20 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants