Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document GitOps RN-1.8.3 #59991

Merged
merged 1 commit into from
May 19, 2023
Merged

Document GitOps RN-1.8.3 #59991

merged 1 commit into from
May 19, 2023

Conversation

Srivaralakshmi
Copy link
Member

@Srivaralakshmi Srivaralakshmi commented May 15, 2023 •
edited by rolfedh

NOTE: From GitOps 1.7.0 onwards, we are documenting security issues in a new advisory format as part of errata updates.

Aligned team: Dev Tools

Purpose: To resolve the following issues:
(https://issues.redhat.com/browse/RHDEVDOCS-5216)

OCP version this PR applies to: enterprise-4.10 and later

Link to docs preview: Download to see the preview in your browser - Release notes for Red Hat OpenShift GitOps 1.8.3

SME review: Completed by @iam-veeramalla, @jaideepr97
QE review: Completed by @varshab1210
Peer-review: Completed by @rolfedh

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 15, 2023
@Srivaralakshmi
Copy link
Member Author

Srivaralakshmi commented May 15, 2023 •
edited

@iam-veeramalla, @jaideepr97, and @varshab1210: Please review this PR and provide feedback.

Please let me know if there are any issues to be covered in this Release Notes for the 1.8.3 release. Thank you!

@Srivaralakshmi Srivaralakshmi changed the title Document GitOps RN-1.8.3 [WIP] Document GitOps RN-1.8.3 May 16, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2023
@Srivaralakshmi
Copy link
Member Author

@iam-veeramalla, @jaideepr97, @harrietgrace, and @varshab1210: Here is the revised PR.

Varsha, PTAL at the Note on stable channel.
Jaideep, I have addressed your suggestion PTAL.

  • If there is anything more to be covered in RN 1.8.3, please let me know right away.
  • If the content looks good, please provide approval. I will send the PR to peer review and keep it ready for the merge tomorrow.

@Srivaralakshmi
Copy link
Member Author

@iam-veeramalla, @jaideepr97, @harrietgrace, and @varshab1210: Here is the revised PR.

Varsha, as discussed, I have moved the admonition just before the matrix table - PTAL.
Jaideep, I have addressed your suggestion PTAL.

  • If there is anything more to be covered in RN 1.8.3, please let me know right away.
  • If the content looks good, please provide approval. I will send the PR to peer review and keep it ready for the merge tomorrow.

jaideepr97
jaideepr97 approved these changes May 16, 2023
View reviewed changes
Copy link

@jaideepr97 jaideepr97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Srivaralakshmi

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 17, 2023 •
edited

🤖 Updated build preview is available at:
https://59991--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/16251

@Srivaralakshmi
Copy link
Member Author

Srivaralakshmi commented May 17, 2023 •
edited

@varshab1210 Thanks for the LGTM, I have provided the appropriate links.

Please approve the PR and provide /lgtm.

rolfedh
rolfedh reviewed May 17, 2023
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Srivaralakshmi. I've offered a suggestion and a question. HTH! Nice work!

modules/go-compatibility-and-support-matrix.adoc Outdated Show resolved Hide resolved
@varshab1210
Copy link

varshab1210 commented May 18, 2023 •
edited

/lgtm
Thanks

@iam-veeramalla
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
rolfedh
rolfedh approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice work.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
@Srivaralakshmi
Copy link
Member Author

@varshab1210 Can you please approve the PR?

@varshab1210
Copy link

/lgtm
Thanks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
@Srivaralakshmi Srivaralakshmi changed the title [WIP] Document GitOps RN-1.8.3 Document GitOps RN-1.8.3 May 19, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 19, 2023
@Srivaralakshmi
Document GitOps RN-1.8.3
4985c0d 
Fixing SME review comments and updates to RN content

Moved the admonition above the matrix table to cover all GitOps versions supported on OCP 4.13

Fixing SME review comment on Fixed Issue for 1.8.3

Fixing the errata number

Fixing the errata title numbers and links
@gabriel-rh gabriel-rh merged commit acb85ae into openshift:main May 19, 2023
1 check passed
@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 19, 2023
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #60240

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.11

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.12

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.13

@gabriel-rh
Copy link
Contributor

/cherry-pick enterprise-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 19, 2023
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #60241

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 19, 2023
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #60242

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 19, 2023
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #60243

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 19, 2023
Merged
@openshift-cherrypick-robot
Copy link

@gabriel-rh: new pull request created: #60244

In response to this:

/cherry-pick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer added this to the Continuous Release milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfedh rolfedh rolfedh approved these changes

@jaideepr97 jaideepr97 jaideepr97 approved these changes

@iam-veeramalla iam-veeramalla iam-veeramalla approved these changes

@varshab1210 varshab1210 varshab1210 approved these changes

Assignees

@iam-veeramalla iam-veeramalla

@varshab1210 varshab1210

Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Srivaralakshmi @ocpdocs-previewbot @varshab1210 @iam-veeramalla @gabriel-rh @openshift-cherrypick-robot @rolfedh @jaideepr97 @bergerhoffer