OSDOCS-5773: Adding and updating example oc-mirror image set configs #60093
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@bergerhoffer: This pull request references OSDOCS-5773 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@bergerhoffer: This pull request references OSDOCS-5773 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/L
|
@bergerhoffer: This pull request references OSDOCS-5773 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bergerhoffer: This pull request references OSDOCS-5773 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The This is because your PR targets the If the update in your PR does NOT apply to version 4.14 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
|
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/18388 |
|
@bergerhoffer: This pull request references OSDOCS-5773 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Hi @bergerhoffer
Thanks for this update!
I added just a small clarification for the heads only use-case
bergerhoffer
force-pushed
the
OSDOCS-5773
branch
5 times, most recently
from
bf754d6
to
a993373
Compare
|
@sherine-k @aguidirh I updated this to include two more examples:
Please take a look and let me know your feedback on these ones. Thanks! Previews: |
|
/label peer-review-needed |
bergerhoffer
changed the title
openshift-ci
bot
added
peer-review-needed
There was a problem hiding this comment.
Thanks @bergerhoffer
This is going to help a lot, especially the default channel inclusion example!
|
/label peer-review-in-progress |
openshift-ci
bot
added
the
peer-review-in-progress
|
/remove-label peer-review-in-progress |
openshift-ci
bot
added
peer-review-done
|
Updated for 2 pieces of feedback, will wait for input from oc-mirror team on two open issues. |
bergerhoffer
force-pushed
the
OSDOCS-5773
branch
from
cde8dfb
to
0894709
Compare
|
@sherine-k @zhouying7780 I updated to use 'stable' for the channel of that example, and used 4.0.1 as the version. I did not make any changes to the first comment you made @zhouying7780. Let me know how this looks now, thanks! |
|
@zhouying7780 Can you PTAL? |
|
/lgtm |
|
@bergerhoffer: This pull request references OSDOCS-5773 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.13 |
|
/cherrypick enterprise-4.14 |
|
@bergerhoffer: new pull request created: #61815 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bergerhoffer: new pull request created: #61816 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
4.13+
Issue:
https://issues.redhat.com/browse/OSDOCS-5773
Link to docs preview:
https://60093--docspreview.netlify.app/openshift-enterprise/latest/installing/disconnected_install/installing-mirroring-disconnected.html#oc-mirror-image-set-examples_installing-mirroring-disconnected
QE review:
Additional information:
This will be backported to 4.12, but with changes to remove any 4.13-specific content (like targetCatalog).