Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS#9295: Updated the --insecure flag desc. in installation docs #60591

Merged
merged 1 commit into from May 30, 2023
Merged

OCPBUGS#9295: Updated the --insecure flag desc. in installation docs #60591

merged 1 commit into from May 30, 2023

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented May 26, 2023 •
edited

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 26, 2023
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-9295, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-9295, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

OCPBUGS-9295

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 26, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 26, 2023 •
edited

🤖 Updated build preview is available at:
https://60591--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/16857

@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-9295, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

OCPBUGS-9295

Version(s):
4.10 through to 4.14

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-9295, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

OCPBUGS-9295

Version(s):
4.10 through to 4.14

Link to docs preview:
coreos-installer options for ISO and PXE installations

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-9295, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

OCPBUGS-9295

Version(s):
4.10 through to 4.14

Links to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-9295, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

OCPBUGS-9295

Version(s):
4.10 through to 4.14

Links to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-9295, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

OCPBUGS-9295

Version(s):
4.10 through to 4.14

Links to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dfitzmau dfitzmau changed the title OCPBUGS-9295: Updated the --insecure flag desc. in installation docs OCPBUGS#9295: Updated the --insecure flag desc. in installation docs May 26, 2023
@openshift-ci-robot openshift-ci-robot removed jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 26, 2023
@openshift-ci-robot
Copy link

@dfitzmau: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

OCPBUGS-9295

Version(s):
4.10 through to 4.14

Links to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pawanpinjarkar
Copy link

/retitle "OCPBUGS-9295: Updated the --insecure flag desc. in installation docs"

@openshift-ci openshift-ci bot changed the title OCPBUGS#9295: Updated the --insecure flag desc. in installation docs "OCPBUGS-9295: Updated the --insecure flag desc. in installation docs" May 26, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 26, 2023
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-9295, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-9295

Version(s):
4.10 through to 4.14

Links to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pawanpinjarkar
Copy link

/retitle OCPBUGS-9295: Updated the --insecure flag desc. in installation docs

@openshift-ci openshift-ci bot changed the title "OCPBUGS-9295: Updated the --insecure flag desc. in installation docs" OCPBUGS-9295: Updated the --insecure flag desc. in installation docs May 26, 2023
@pawanpinjarkar
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2023
zaneb
zaneb reviewed May 29, 2023
View reviewed changes
modules/installation-user-infra-machines-static-network.adoc Outdated
@@ -404,7 +404,7 @@ a|`--save-partindex <id>...`
a|Save partitions with this number or range.

a|`--insecure`
a|Skip signature verification.
a|Skip RHCOS image signature verification.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be {op-system} image shouldn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @zaneb . Correct. I updated the text based on your suggestion.

snarayan-redhat
snarayan-redhat reviewed May 30, 2023
View reviewed changes
Copy link
Contributor

@snarayan-redhat snarayan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snarayan-redhat snarayan-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 30, 2023
@dfitzmau
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 30, 2023
@michaelryanpeter
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 30, 2023
@michaelryanpeter michaelryanpeter added this to the Continuous Release milestone May 30, 2023
@michaelryanpeter michaelryanpeter merged commit cc7e493 into openshift:main May 30, 2023
1 check passed
@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.14

@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.13

@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.12

@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.11

@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 30, 2023
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #60686

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 30, 2023
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #60687

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 30, 2023
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #60688

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 30, 2023
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #60689

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #60690

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaneb zaneb zaneb left review comments

@snarayan-redhat snarayan-redhat snarayan-redhat left review comments

Assignees

@zaneb zaneb

@pawanpinjarkar pawanpinjarkar

Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @pawanpinjarkar @zaneb @michaelryanpeter @openshift-cherrypick-robot @snarayan-redhat