Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document GitOps v1.9 Release Notes #60649

Merged
merged 1 commit into from Jun 12, 2023
Merged

Document GitOps v1.9 Release Notes #60649

merged 1 commit into from Jun 12, 2023

Conversation

Srivaralakshmi
Copy link
Member

@Srivaralakshmi Srivaralakshmi commented May 29, 2023 •
edited

Aligned team: Dev Tools

Purpose: To resolve the following issues:

OCP version this PR applies to: enterprise-4.12, 4.13, and 4.14

Link to docs preview:

SME review: Completed by @iam-veeramalla, @jaideepr97, @ishitasequeira, @reginapizza, @svghadi
QE review: Completed by @varshab1210
Peer-review: Completed by @deerskindoll

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 29, 2023
@Srivaralakshmi
Copy link
Member Author

@iam-veeramalla, @jaideep97, @reginapizza, @drpaneas, @jannfis, @svghadi, @ishitasequeira, @varshab1210: Please review the RN PR for v1.9.0 and provide feedback and approval. Thanks!

@Srivaralakshmi Srivaralakshmi force-pushed the GitOpsRN-1.9 branch 2 times, most recently from bb25ae5 to bde02bf Compare May 29, 2023 15:31
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 29, 2023 •
edited

🤖 Updated build preview is available at:
https://60649--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/17757

svghadi
svghadi suggested changes May 30, 2023
View reviewed changes
Copy link

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo in Deprecated and removed features section.
Rest all looks good to me. Thanks @Srivaralakshmi.

modules/gitops-release-notes-1-9-0.adoc Outdated Show resolved Hide resolved
@jaideepr97
Copy link

LGTM

ishitasequeira
ishitasequeira approved these changes May 30, 2023
View reviewed changes
Copy link

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Srivaralakshmi
Copy link
Member Author

@varshab1210 Can you please approve the PR?

varshab1210
varshab1210 approved these changes May 31, 2023
View reviewed changes
Copy link

@varshab1210 varshab1210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deerskindoll
deerskindoll reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of minor suggestions, please check them out

modules/gitops-release-notes-1-9-0.adoc Show resolved Hide resolved
modules/gitops-release-notes-1-9-0.adoc Show resolved Hide resolved
modules/gitops-release-notes-1-9-0.adoc Show resolved Hide resolved
@Srivaralakshmi
Copy link
Member Author

@deerskindoll: Thank you very much for your time, review, and suggestions. Please see my comments and approve the PR. Thank you!

deerskindoll
deerskindoll approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

iam-veeramalla
iam-veeramalla approved these changes Jun 8, 2023
View reviewed changes
Copy link

@iam-veeramalla iam-veeramalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Srivaralakshmi

iam-veeramalla
iam-veeramalla approved these changes Jun 8, 2023
View reviewed changes
Copy link

@iam-veeramalla iam-veeramalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Srivaralakshmi

iam-veeramalla
iam-veeramalla approved these changes Jun 8, 2023
View reviewed changes
Copy link

@iam-veeramalla iam-veeramalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Srivaralakshmi

@varshab1210
Copy link

lgtm, thanks @Srivaralakshmi

@Srivaralakshmi
Copy link
Member Author

@deerskindoll Can you please give a quick re-look at this PR and give your approval? An errata update came in and I included that in the doc. The release is out today:crossed_fingers:

deerskindoll
deerskindoll approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

varshab1210
varshab1210 approved these changes Jun 12, 2023
View reviewed changes
Copy link

@varshab1210 varshab1210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Srivaralakshmi
Document GitOps v1.9 Release Notes
e19488c 
Fixing SME review comments and uncommenting new assembly for Shipra's PR

Adding the  info in the Supported must-gather images table

Updated the kam CLI version

Adding CVE update and nitpick fix

updated date in RN errata
@Preeticp Preeticp added this to the Continuous Release milestone Jun 12, 2023
@Preeticp Preeticp added the dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs label Jun 12, 2023
@Preeticp
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@Preeticp Preeticp merged commit 592e924 into openshift:main Jun 12, 2023
1 check passed
@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.12

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.13

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot
Copy link

@Preeticp: #60649 failed to apply on top of branch "enterprise-4.12":

Applying: Document GitOps v1.9 Release Notes
.git/rebase-apply/patch:107: trailing whitespace.
=== RHSA-2023:112944 - {gitops-title} 1.9.0 security update advisory 
.git/rebase-apply/patch:138: trailing whitespace.
Argo Rollouts is a Technology Preview feature. 
.git/rebase-apply/patch:166: trailing whitespace.
* Before this update, users could not connect to Microsoft Team Foundation Server (TFS) type Git repositories through Argo CD deployed by the Operator. This update fixes the issue by updating the Git version to 
.git/rebase-apply/patch:205: trailing whitespace.
---- 
warning: 4 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
M	cicd/gitops/gitops-release-notes.adoc
M	modules/gathering-data-specific-features.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/gathering-data-specific-features.adoc
CONFLICT (content): Merge conflict in modules/gathering-data-specific-features.adoc
Auto-merging cicd/gitops/gitops-release-notes.adoc
Auto-merging _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Document GitOps v1.9 Release Notes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 12, 2023
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #61077

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #61078

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 12, 2023
Merged
@Srivaralakshmi Srivaralakshmi mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Preeticp Preeticp Preeticp left review comments

@jaideepr97 jaideepr97 jaideepr97 approved these changes

@iam-veeramalla iam-veeramalla iam-veeramalla approved these changes

@ishitasequeira ishitasequeira ishitasequeira approved these changes

@reginapizza reginapizza reginapizza approved these changes

@varshab1210 varshab1210 varshab1210 approved these changes

@svghadi svghadi svghadi approved these changes

@deerskindoll deerskindoll deerskindoll approved these changes

Assignees

@Preeticp Preeticp

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet