Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSM-4041: Update infrastructure node content #60744

Merged
merged 1 commit into from Jun 28, 2023
Merged

OSSM-4041: Update infrastructure node content #60744

merged 1 commit into from Jun 28, 2023

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented May 31, 2023 •
edited

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 31, 2023 •
edited by openshift-ci bot

@rh-tokeefe: This pull request references OSSM-4041 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 31, 2023
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 31, 2023 •
edited by openshift-ci bot

@rh-tokeefe: This pull request references OSSM-4041 which is a valid jira issue.

In response to this:

Version(s): 4.10+

Issue: https://issues.redhat.com/browse/OSSM-4041

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 31, 2023 •
edited

🤖 Updated build preview is available at:
https://60744--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/18829

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 31, 2023 •
edited by openshift-ci bot

@rh-tokeefe: This pull request references OSSM-4041 which is a valid jira issue.

In response to this:

Version(s): 4.10+

Issue: https://issues.redhat.com/browse/OSSM-4041

Link to docs preview: https://60744--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-create-smcp.html#ossm-about-control-plane-and-infrastructure-nodes_ossm-create-smcp

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rh-tokeefe rh-tokeefe force-pushed the OSSM-4041 branch 3 times, most recently from c93cded to 3deba6a Compare May 31, 2023 19:32
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2023
@rh-tokeefe rh-tokeefe force-pushed the OSSM-4041 branch 2 times, most recently from 2252a9d to 06cab48 Compare June 1, 2023 19:18
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 1, 2023
@rh-tokeefe rh-tokeefe force-pushed the OSSM-4041 branch 3 times, most recently from 3d199c2 to 364f4b7 Compare June 5, 2023 17:01
@rh-tokeefe rh-tokeefe force-pushed the OSSM-4041 branch 7 times, most recently from cf74b6c to da2d8e2 Compare June 12, 2023 17:51
@fjglira
Copy link

fjglira commented Jun 15, 2023

LGTM

@bburt-rh
Copy link
Contributor

lgtm. Thanks @rh-tokeefe

@bburt-rh bburt-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 28, 2023
@bburt-rh bburt-rh merged commit c7de1e0 into openshift:main Jun 28, 2023
1 check passed
@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.10

@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.11

@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.12

@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.13

@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 28, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #61819

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #61820

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jun 28, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #61821

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #61822

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 28, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #61823

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luksa luksa luksa left review comments

@shipsing shipsing shipsing requested changes

@fjglira fjglira fjglira approved these changes

@bburt-rh bburt-rh bburt-rh approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rh-tokeefe @openshift-ci-robot @ocpdocs-previewbot @fjglira @bburt-rh @openshift-cherrypick-robot @luksa @shipsing