Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS-5239: Documented AWS LZ IP auto creation of subnets #60771

Merged
merged 1 commit into from Sep 20, 2023

Conversation

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 1, 2023

@dfitzmau: This pull request references OSDOCS-5239 which is a valid jira issue.

In response to this:

OSDOCS-5239

Version(s):
4.14

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 1, 2023
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 1, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 1, 2023

🤖 Updated build preview is available at:
https://60771--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/25107

@dfitzmau dfitzmau force-pushed the OSDOCS-5239 branch 3 times, most recently from 2aff519 to 1a3c08c Compare June 1, 2023 13:20
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 1, 2023
@dfitzmau dfitzmau force-pushed the OSDOCS-5239 branch 4 times, most recently from 4479fd3 to 1f0bb91 Compare June 1, 2023 14:51
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 1, 2023

@dfitzmau: This pull request references OSDOCS-5239 which is a valid jira issue.

In response to this:

OSDOCS-5239

Version(s):
4.14

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 1, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 1, 2023

@dfitzmau: This pull request references OSDOCS-5239 which is a valid jira issue.

In response to this:

OSDOCS-5239

Version(s):
4.14

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 1, 2023

@dfitzmau: This pull request references OSDOCS-5239 which is a valid jira issue.

In response to this:

OSDOCS-5239

Version(s):
4.14

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 1, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 2, 2023

@dfitzmau: This pull request references OSDOCS-5239 which is a valid jira issue.

In response to this:

OSDOCS-5239

Version(s):
4.14

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 2, 2023
@dfitzmau dfitzmau force-pushed the OSDOCS-5239 branch 5 times, most recently from 2e9aa4f to 8556c4c Compare September 12, 2023 15:28
@dfitzmau
Copy link
Contributor Author

Hi @mtulio . Because #60222 restructured AWS and GCP install doc set, I had to pull in additional modules and sections into our Installing a cluster on AWS with worker nodes on AWS Local Zones doc book.

Hi @dfitzmau: Could you please elaborate "I had to pull in additional modules and sections" and/or point me to the sections added in the book? Is it something I need to review specifically for LZ?

Hi @mtulio . #60222 is a docs PR that was merged yesterday. This PR moved modules that were outside the install doc books to the install doc books.

Screenshot from 2023-09-12 16-46-43

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Sep 12, 2023

@mtulio , the preview link for my PR now shows the following sections now arranged with the sections we arranged:

Screenshot from 2023-09-12 16-43-43

Screenshot from 2023-09-12 16-46-06

Do these moved sections apply to Installing a cluster on AWS with worker nodes on AWS Local Zones?

@dfitzmau dfitzmau force-pushed the OSDOCS-5239 branch 5 times, most recently from 68816ee to a851bf9 Compare September 14, 2023 10:49
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 18, 2023

@dfitzmau: This pull request references OSDOCS-5239 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

OSDOCS-5239

Version(s):
4.14

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Note: Awaiting outcome on discussion https://app.slack.com/client/T027F3GAJ/C04TMSTHUHK to determine status of PR updates.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2023
@dfitzmau
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 20, 2023
@JoeAldinger JoeAldinger added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 20, 2023
@JoeAldinger JoeAldinger added this to the Planned for 4.14 GA milestone Sep 20, 2023
@JoeAldinger JoeAldinger added branch/enterprise-4.14 and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Sep 20, 2023
@JoeAldinger JoeAldinger merged commit 161bfda into openshift:main Sep 20, 2023
1 check passed
@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #64965

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtulio
Copy link
Contributor

mtulio commented Sep 20, 2023

Do these moved sections apply to Installing a cluster on AWS with worker nodes on AWS Local Zones?

Linking to the posterity the Slack discussion about the questions above: https://redhat-internal.slack.com/archives/C04TMSTHUHK/p1694698824101229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants