Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHDEVDOCS-3819: [UG] How to store and retrieve logs #60966

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented Jun 8, 2023

Aligned team: Dev Tools
OCP version for cherry-picking: enterprise-4.10 and later
JIRA issue: RHDEVDOCS-3819
Preview page: Viewing Argo CD logs
SME Review: Completed by @iam-veeramalla
QE review: Completed by @varshab1210
Peer-review: Completed by @max-cx

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 8, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 8, 2023

@ekristova: This pull request references RHDEVDOCS-3819 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools
OCP version for cherry-picking:
JIRA issue: RHDEVDOCS-3819
Preview page:
SME Review: @
QE review: @
Peer-review: @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 8, 2023

@ekristova: This pull request references RHDEVDOCS-3819 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools
OCP version for cherry-picking: enterprise-4.10 and later
JIRA issue: RHDEVDOCS-3819
Preview page:
SME Review: @
QE review: @
Peer-review: @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 8, 2023

🤖 Updated build preview is available at:
https://60966--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/21813

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 8, 2023

@ekristova: This pull request references RHDEVDOCS-3819 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools
OCP version for cherry-picking: enterprise-4.10 and later
JIRA issue: RHDEVDOCS-3819
Preview page: Viewing Argo CD logs with the Kibana dashboard
SME Review: @
QE review: @
Peer-review: @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eromanova97 eromanova97 force-pushed the RHDEVDOCS-3819 branch 9 times, most recently from 95e142f to 2738ede Compare June 12, 2023 08:40
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 12, 2023

@ekristova: This pull request references RHDEVDOCS-3819 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools
OCP version for cherry-picking: enterprise-4.10 and later
JIRA issue: RHDEVDOCS-3819
Preview page: Viewing Argo CD logs using the Kibana dashboard
SME Review: @
QE review: @
Peer-review: @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 12, 2023

@ekristova: This pull request references RHDEVDOCS-3819 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools
OCP version for cherry-picking: enterprise-4.10 and later
JIRA issue: RHDEVDOCS-3819
Preview page: Viewing Argo CD logs using the Kibana dashboard
SME Review: @iam-veeramalla
QE review: @varshab1210
Peer-review: @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eromanova97
Copy link
Contributor Author

Hello @iam-veeramalla @varshab1210 PTAL and provide feedback. Thank you!

@iam-veeramalla
Copy link

/lgtm
/approve
Thanks @ekristova

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 14, 2023

@ekristova: This pull request references RHDEVDOCS-3819 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools
OCP version for cherry-picking: enterprise-4.10 and later
JIRA issue: RHDEVDOCS-3819
Preview page: Viewing Argo CD logs using the Kibana dashboard
SME Review: Completed by @iam-veeramalla
QE review: @varshab1210
Peer-review: @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 28, 2023

@ekristova: This pull request references RHDEVDOCS-3819 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools
OCP version for cherry-picking: enterprise-4.10 and later
JIRA issue: RHDEVDOCS-3819
Preview page: Viewing Argo CD logs using the Kibana dashboard
SME Review: Completed by @iam-veeramalla
QE review: @varshab1210 @mbhalodi
Peer-review: @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 28, 2023

@ekristova: This pull request references RHDEVDOCS-3819 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools
OCP version for cherry-picking: enterprise-4.10 and later
JIRA issue: RHDEVDOCS-3819
Preview page: Viewing Argo CD logs using the Kibana dashboard
SME Review: Completed by @iam-veeramalla
QE review: @varshab1210 @mehabhalodiya
Peer-review: @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@varshab1210
Copy link

Sorry for taking so long. I was able to follow the steps as mentioned. Thanks!

LGTM

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 9, 2023

@ekristova: This pull request references RHDEVDOCS-3819 which is a valid jira issue.

In response to this:

Aligned team: Dev Tools
OCP version for cherry-picking: enterprise-4.10 and later
JIRA issue: RHDEVDOCS-3819
Preview page: Viewing Argo CD logs using the Kibana dashboard
SME Review: Completed by @iam-veeramalla
QE review: Completed by @varshab1210
Peer-review: @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@bscott-rh bscott-rh added this to the Continuous Release milestone Aug 10, 2023
@bscott-rh bscott-rh removed merge-review-needed Signifies that the merge review team needs to review this PR merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Aug 10, 2023
@bscott-rh
Copy link
Contributor

Please add a short abstract to your assembly per the contribution guidelines: https://redhat-documentation.github.io/supplementary-style-guide/#shortdesc

Let me know if you have any questions. Thanks!

@eromanova97
Copy link
Contributor Author

eromanova97 commented Aug 10, 2023

Hello @bscott-rh, I was instructed by @bburt-rh to remove the introduction from the assembly and put it into the module. Here is the comment:
#60966 (comment)

So now I am not sure how to proceed.

@bburt-rh
Copy link
Contributor

bburt-rh commented Aug 10, 2023

Hello @bscott-rh, I was instructed by @bburt-rh to remove the introduction from the assembly and put it into the module. Here is the comment: #60966 (comment)

So now I am note sure how to proceed.

My mistake @ekristova. @bscott-rh is correct. The assembly also needs a one-sentence abstract, and the procedure module needs an intro as well. So adding a short sentence to the assembly should solve the issue. I apologize for the confusion.

@eromanova97
Copy link
Contributor Author

Thank you @bburt-rh for the quick answer!

@eromanova97
Copy link
Contributor Author

@bscott-rh I readded the introductions as they were before. I hope it is good to go now after the tests pass (it seems to be stuck for now). Thank you very much!

@bscott-rh
Copy link
Contributor

Looks good to me, thank you both for your help.

@bscott-rh bscott-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Aug 10, 2023
@bscott-rh bscott-rh merged commit 5c62c29 into openshift:main Aug 10, 2023
1 check passed
@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.10

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #63440

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #63448

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #63449

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #63450

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #63451

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

merged and CP'd to 4.10-4.14.

@eromanova97 eromanova97 deleted the RHDEVDOCS-3819 branch April 18, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants