Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBSDOCS-185: changes-to-sample-code-for-repeat-interval-settings #61754

Merged
merged 1 commit into from Jun 29, 2023
Merged

OBSDOCS-185: changes-to-sample-code-for-repeat-interval-settings #61754

merged 1 commit into from Jun 29, 2023

Conversation

bburt-rh
Copy link
Contributor

@bburt-rh bburt-rh commented Jun 27, 2023 •
edited

Summary: This PR adjusts the description of the group_interval setting and to the sample code for the repeat_interval settings.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 27, 2023 •
edited by openshift-ci bot

@bburt-rh: This pull request references OBSDOCS-185 which is a valid jira issue.

In response to this:

Summary: This PR adjusts the description of the group_interval setting and to the sample code for the repeat_interval settings.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2023
@openshift openshift deleted a comment from openshift-ci-robot Jun 27, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 27, 2023 •
edited

🤖 Updated build preview is available at:
https://61754--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/18960

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 27, 2023 •
edited by openshift-ci bot

@bburt-rh: This pull request references OBSDOCS-185 which is a valid jira issue.

In response to this:

Summary: This PR adjusts the description of the group_interval setting and to the sample code for the repeat_interval settings.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 27, 2023 •
edited by openshift-ci bot

@bburt-rh: This pull request references OBSDOCS-185 which is a valid jira issue.

In response to this:

Summary: This PR adjusts the description of the group_interval setting and to the sample code for the repeat_interval settings.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bburt-rh bburt-rh force-pushed the OBSDOCS-185-adjustments-to-sample-code-for-repeat-interval-settings branch from f686f8d to 5f2e1c7 Compare June 27, 2023 16:09
@juzhao
Copy link

juzhao commented Jun 28, 2023

LGTM, waiting for others to review

simonpasquier
simonpasquier reviewed Jun 29, 2023
View reviewed changes
Copy link

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bburt-rh bburt-rh force-pushed the OBSDOCS-185-adjustments-to-sample-code-for-repeat-interval-settings branch from 5f2e1c7 to aff365b Compare June 29, 2023 15:05
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 29, 2023
gwynnemonahan
gwynnemonahan approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@gwynnemonahan gwynnemonahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rendering issues resolved. LGTM!

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 29, 2023 •
edited by openshift-ci bot

@bburt-rh: This pull request references OBSDOCS-185 which is a valid jira issue.

In response to this:

Summary: This PR adjusts the description of the group_interval setting and to the sample code for the repeat_interval settings.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 29, 2023 •
edited by openshift-ci bot

@bburt-rh: This pull request references OBSDOCS-185 which is a valid jira issue.

In response to this:

Summary: This PR adjusts the description of the group_interval setting and to the sample code for the repeat_interval settings.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bburt-rh bburt-rh added peer-review-done Signifies that the peer review team has reviewed this PR dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs qe-approved Signifies that QE has signed off on this PR branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 labels Jun 29, 2023
@bburt-rh bburt-rh added this to the Continuous Release milestone Jun 29, 2023
@bburt-rh bburt-rh merged commit 3728911 into openshift:main Jun 29, 2023
1 check passed
@bburt-rh
Copy link
Contributor Author

/cherrypick enterprise-4.10

@bburt-rh
Copy link
Contributor Author

/cherrypick enterprise-4.11

@bburt-rh
Copy link
Contributor Author

/cherrypick enterprise-4.12

@bburt-rh
Copy link
Contributor Author

/cherrypick enterprise-4.13

@bburt-rh
Copy link
Contributor Author

/cherrypick enterprise-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 29, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #61913

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 29, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #61914

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 29, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #61915

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #61916

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 29, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #61917

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmellado danielmellado danielmellado left review comments

@simonpasquier simonpasquier simonpasquier left review comments

@gwynnemonahan gwynnemonahan gwynnemonahan approved these changes

@juzhao juzhao Awaiting requested review from juzhao

Assignees

@simonpasquier simonpasquier

Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@bburt-rh @openshift-ci-robot @ocpdocs-previewbot @juzhao @openshift-cherrypick-robot @danielmellado @simonpasquier @gwynnemonahan