Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OCPBUGS-15211]: Steps to disable autoscalers #61853

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[OCPBUGS-15211]: Steps to disable autoscalers #61853

merged 1 commit into from
Oct 10, 2023

Conversation

jeana-redhat
Copy link
Contributor

@jeana-redhat jeana-redhat commented Jun 28, 2023 •
edited

Version(s):
4.10+

Issue:
OCPBUGS-15211

Link to docs preview:
Disabling autoscaling

QE review:

  • QE has approved this change.

Additional information:

  • Tidied up a few things in the assembly while I was in here

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 28, 2023
@jeana-redhat jeana-redhat force-pushed the OCPBUGS-15211-deleting-autoscaler-resources branch from 9f64a8c to 42d1c33 Compare June 28, 2023 16:30
@jeana-redhat jeana-redhat changed the title [OCPBUGS-15211]: Steps to disable autoscalers OCPBUGS-15211: Steps to disable autoscalers Jun 28, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 28, 2023
@jeana-redhat jeana-redhat changed the title OCPBUGS-15211: Steps to disable autoscalers [OCPBUGS-15211]: Steps to disable autoscalers Jun 28, 2023
@openshift-ci-robot openshift-ci-robot removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 28, 2023
@openshift openshift deleted a comment from openshift-ci-robot Jun 28, 2023
@openshift openshift deleted a comment from openshift-ci-robot Jun 28, 2023
@openshift openshift deleted a comment from openshift-ci-robot Jun 28, 2023
@jeana-redhat jeana-redhat force-pushed the OCPBUGS-15211-deleting-autoscaler-resources branch 2 times, most recently from 9e61f3b to 286a3d8 Compare June 28, 2023 16:35
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 28, 2023 •
edited

🤖 Updated build preview is available at:
https://61853--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/27289

@kalexand-rh
Copy link
Contributor

Only versions 4.11+ are still in maintenance. I am removing labels from earlier versions from this PR.

@jeana-redhat jeana-redhat force-pushed the OCPBUGS-15211-deleting-autoscaler-resources branch from 286a3d8 to 32d4586 Compare October 3, 2023 19:18
@jeana-redhat
Copy link
Contributor Author

refreshing old PR

@jeana-redhat jeana-redhat force-pushed the OCPBUGS-15211-deleting-autoscaler-resources branch from 32d4586 to 46636d2 Compare October 9, 2023 13:01
elmiko
elmiko reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instructions lgtm

@jeana-redhat
Copy link
Contributor Author

Thanks, Mike! @sunzhaohua2 let me know if my update looks alright to you - if so, I can get it published this week 🤓

@sunzhaohua2
Copy link

LGTM

@jeana-redhat jeana-redhat force-pushed the OCPBUGS-15211-deleting-autoscaler-resources branch from 46636d2 to 5ab1861 Compare October 10, 2023 13:13
@jeana-redhat jeana-redhat added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 10, 2023
@bburt-rh bburt-rh added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 10, 2023
bburt-rh
bburt-rh reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@bburt-rh bburt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tiny nitpicks for you to consider, but otherwise LGTM. I really like how this PR maintains consistency between the different (but similar) procs.

modules/deleting-cluster-autoscaler.adoc Outdated Show resolved Hide resolved
modules/deleting-machine-autoscaler.adoc Outdated Show resolved Hide resolved
modules/deleting-cluster-autoscaler.adoc Outdated Show resolved Hide resolved
@bburt-rh bburt-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 10, 2023
@bburt-rh bburt-rh added this to the Continuous Release milestone Oct 10, 2023
@jeana-redhat jeana-redhat force-pushed the OCPBUGS-15211-deleting-autoscaler-resources branch from 5ab1861 to f4b7418 Compare October 10, 2023 15:12
@jeana-redhat
Copy link
Contributor Author

A few tiny nitpicks for you to consider, but otherwise LGTM. I really like how this PR maintains consistency between the different (but similar) procs.

Good nits! thanks for the careful review 😄

Also, this made me look up the prefix preference for re-enable in ISG, and I was glad to see that they also recommend re-enable for this word instead of their usual unhyphenated stance 🤓

@jeana-redhat jeana-redhat merged commit 4a27b7f into openshift:main Oct 10, 2023
1 check passed
@jeana-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.14

@jeana-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.13

@jeana-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.12

@jeana-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 10, 2023
Merged
@openshift-cherrypick-robot
Copy link

@jeana-redhat: new pull request created: #66007

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 10, 2023
Merged
@openshift-cherrypick-robot
Copy link

@jeana-redhat: new pull request created: #66008

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 10, 2023
Merged
@openshift-cherrypick-robot
Copy link

@jeana-redhat: new pull request created: #66009

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@jeana-redhat: new pull request created: #66010

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

@sunzhaohua2 sunzhaohua2 sunzhaohua2 left review comments

@bburt-rh bburt-rh bburt-rh left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jeana-redhat @ocpdocs-previewbot @kalexand-rh @sunzhaohua2 @openshift-cherrypick-robot @elmiko @bburt-rh @openshift-ci-robot