Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSM-3661: [DOC] Document configuring OSSM with OpenShift (or external) Prometheus #61854

Merged
merged 1 commit into from Jul 27, 2023
Merged

OSSM-3661: [DOC] Document configuring OSSM with OpenShift (or external) Prometheus #61854

merged 1 commit into from Jul 27, 2023

Conversation

gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Jun 28, 2023 •
edited

OSSM-3661: [DOC] Document configuring OSSM with OpenShift (or external) Prometheus

Version(s):
4.10+

Issue:
https://issues.redhat.com/browse/OSSM-3661

Link to docs preview:
https://61854--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-observability.html#ossm-integrating-with-user-workload-monitoring_observability

QE review:

  • QE has approved this change.

Additional information:
Taking over this PR: #60922 that was started by dev

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 28, 2023 •
edited by openshift-ci bot

@gwynnemonahan: This pull request references OSSM-3661 which is a valid jira issue.

In response to this:

Version(s):
4.10+

Issue:
https://issues.redhat.com/browse/OSSM-3661

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Taking over this PR: #60922 that was started by dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 28, 2023 •
edited by openshift-ci bot

@gwynnemonahan: This pull request references OSSM-3661 which is a valid jira issue.

In response to this:

Version(s):
4.10+

Issue:
https://issues.redhat.com/browse/OSSM-3661

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Taking over this PR: #60922 that was started by dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 28, 2023 •
edited by openshift-ci bot

@gwynnemonahan: This pull request references OSSM-3661 which is a valid jira issue.

In response to this:

OSSM-3661: [DOC] Document configuring OSSM with OpenShift (or external) Prometheus

Version(s):
4.10+

Issue:
https://issues.redhat.com/browse/OSSM-3661

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Taking over this PR: #60922 that was started by dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gwynnemonahan gwynnemonahan mentioned this pull request Jun 28, 2023
Closed
1 task
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 28, 2023 •
edited

🤖 Updated build preview is available at:
https://61854--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/20618

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 28, 2023 •
edited by openshift-ci bot

@gwynnemonahan: This pull request references OSSM-3661 which is a valid jira issue.

In response to this:

OSSM-3661: [DOC] Document configuring OSSM with OpenShift (or external) Prometheus

Version(s):
4.10+

Issue:
https://issues.redhat.com/browse/OSSM-3661

Link to docs preview:
https://61854--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-observability.html#ossm-collecting-metrics_observability

QE review:

  • QE has approved this change.

Additional information:
Taking over this PR: #60922 that was started by dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gwynnemonahan gwynnemonahan force-pushed the OSSM-3661 branch 6 times, most recently from 2759327 to 395b6cd Compare June 30, 2023 18:46
@gwynnemonahan gwynnemonahan changed the title OSSM-3661: [DOC] Document configuring OSSM with OpenShift (or external) Prometheus [WIP] OSSM-3661: [DOC] Document configuring OSSM with OpenShift (or external) Prometheus Jun 30, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2023
@gwynnemonahan gwynnemonahan force-pushed the OSSM-3661 branch 13 times, most recently from 67e48a5 to 2155a6e Compare July 6, 2023 13:01
@jewertow @gwynnemonahan
OSSM-3661: Add docs for integration service mesh with monitoring stack
31099aa 
Signed-off-by: Jacek Ewertowski <jewertow@redhat.com>

[DOC] Document configuring OSSM with OpenShift (or external) Prometheus
@abrennan89
Copy link
Contributor

/lgtm

Thanks @gwynnemonahan !

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2023
@gwynnemonahan
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 27, 2023
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Jul 27, 2023
@stevsmit
Copy link
Member

Looks great to me !

@stevsmit stevsmit merged commit bed08cb into openshift:main Jul 27, 2023
1 check passed
@stevsmit
Copy link
Member

/cherrypick enterprise-4.10

@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #62872

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 27, 2023
Merged
@stevsmit
Copy link
Member

/cherrypick enterprise-4.13

@stevsmit
Copy link
Member

/cherrypick enterprise-4.14

@stevsmit
Copy link
Member

/cherrypick enterprise-4.11

@stevsmit
Copy link
Member

/cherrypick enterprise-4.12

@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #62876

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 27, 2023
Merged
@stevsmit
Copy link
Member

/cherrypick enterprise-4.11

@stevsmit
Copy link
Member

/cherrypick enterprise-4.13

@stevsmit
Copy link
Member

/cherrypick enterprise-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 27, 2023
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #62877

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #62878

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jul 27, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #62879

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jewertow jewertow jewertow approved these changes

@abrennan89 abrennan89 abrennan89 left review comments

@monroe-dylan-m monroe-dylan-m monroe-dylan-m approved these changes

Assignees

@abrennan89 abrennan89

Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@gwynnemonahan @openshift-ci-robot @ocpdocs-previewbot @abrennan89 @stevsmit @openshift-cherrypick-robot @jewertow @monroe-dylan-m