New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSDOCS-4158]: New ccoctl
steps for cluster capabilities
#62148
[OSDOCS-4158]: New ccoctl
steps for cluster capabilities
#62148
Conversation
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/27697 |
ccoctl
steps for cluster capabilities
ab1659c
to
75f1eb1
Compare
cb92b0d
to
b64d33b
Compare
f6cacda
to
2aff820
Compare
2aff820
to
8b13835
Compare
Updating cloud provider resources with the Cloud Credential Operator utility |
76ca2a9
to
888b52b
Compare
a7c584d
to
d274228
Compare
$ oc adm release extract \ | ||
--credentials-requests \ | ||
--included \// <1> | ||
--install-config=<installation_directory>/auth/kubeconfig <2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a guess based on existing docs about kubeconfig
and Jianping's comment that we need to point to that instead of install-config.yaml
. @wking or @jianping-shu please correct this since I probably guessed wrong 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can drop this line.
- Kubeconfigs are not install-configs, so
--install-config
here will fail with "hey, this file content is not an install config". - We have docs for lots and lots of
oc ...
commands that just assume the user has figured out how to access a cluster via a kubeconfig. For example, this existing docs have:
Prerequisites
- You have access to an OpenShift Container Platform account with cluster administrator permissions.
- You have installed the OpenShift CLI (oc).
and then when they tell you to use oc
, they say:
To determine the mode that the CCO is configured to use, enter the following command:
$ oc get cloudcredentials cluster -o=jsonpath={.spec.credentialsMode}
without talking about kubeconfigs or profiles or any of that stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work navigating these complex conditionals. Only a few nits inline, and 2 other suggestions not worth putting in-line:
- Not sure if I'm overthinking style guide on this, but CTRL+F the PR for "needs" and consider whether they should be "requires".
- For any of the
.Example output
or.Partial example output
blocks, consider[source,text]
instead of[source,terminal]
per latest repo guidelines (the coloring/highlighting can get funny/random when usingterminal
).
@adellape tysm for the careful review and great feedback! 🙇 |
7156bcc
to
8c34d14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content tagged azure-workload-id
in this file will not show up in the preview build for this PR. This will be viewable in #64001 when I rebase it to get the changes here into main
8c34d14
to
dc73bbb
Compare
/uncc |
dc73bbb
to
2d400a1
Compare
I can understand for cluster upgrade and "ccoctl gcp delete" cases, the KUBECONFIG is already configured to the alive cluster, so only --included is enough. https://62148--docspreview.netlify.app/openshift-enterprise/latest/installing/installing_azure/uninstalling-cluster-azure#cco-ccoctl-deleting-sts-resources_uninstall-cluster-azure LGTM for QE |
Thank you so much @jianping-shu 🙏 And yes, I think the other PR is a good place to add that Azure detail. I will go make a note of it now so I don't lose it 🙂 |
/cherrypick enterprise-4.14 |
@jeana-redhat: new pull request created: #66197 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
4.14+
Issue:
OSDOCS-4158
Link to docs preview:
--included
update in this PR when the other merges)QE review:
Additional information: