Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-4110: GitOps Operator to configure secure communication wit… #62228

Merged
merged 1 commit into from Aug 3, 2023
Merged

RHDEVDOCS-4110: GitOps Operator to configure secure communication wit… #62228

merged 1 commit into from Aug 3, 2023

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented Jul 11, 2023 •
edited

• Aligned team: Dev Tools
• OCP version for cherry-picking: enterprise-4.10 and later
• JIRA issue: RHDEVDOCS-4110
• Preview page: Configuring secure communication with Redis
• SME Review: Completed by @iam-veeramalla
• QE review: Completed by @varshab1210
• Peer-review: Completed by @Srivaralakshmi

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 11, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 11, 2023 •
edited by openshift-ci bot

@ekristova: This pull request references RHDEVDOCS-4110 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• OCP version for cherry-picking: enterprise-4.10 and later
• JIRA issue: RHDEVDOCS-4110
• Preview page:
• SME Review: @
• QE review: @
• Peer-review: @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 11, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 11, 2023 •
edited

🤖 Updated build preview is available at:
https://62228--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/21104

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 11, 2023 •
edited by openshift-ci bot

@ekristova: This pull request references RHDEVDOCS-4110 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• OCP version for cherry-picking: enterprise-4.10 and later
• JIRA issue: RHDEVDOCS-4110
• Preview page: Configuring secure communication with Redis
• SME Review: @
• QE review: @
• Peer-review: @

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 11, 2023 •
edited by openshift-ci bot

@ekristova: This pull request references RHDEVDOCS-4110 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• OCP version for cherry-picking: enterprise-4.10 and later
• JIRA issue: RHDEVDOCS-4110
• Preview page: Configuring secure communication with Redis
• SME Review: @iam-veeramalla
• QE review: @varshab1210
• Peer-review: @Srivaralakshmi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eromanova97
Copy link
Contributor Author

Hello @iam-veeramalla @varshab1210 PTAL and provide feedback. Thank you!

iam-veeramalla
iam-veeramalla approved these changes Jul 17, 2023
View reviewed changes
Copy link

@iam-veeramalla iam-veeramalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 17, 2023 •
edited by openshift-ci bot

@ekristova: This pull request references RHDEVDOCS-4110 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• OCP version for cherry-picking: enterprise-4.10 and later
• JIRA issue: RHDEVDOCS-4110
• Preview page: Configuring secure communication with Redis
• SME Review: Completed by @iam-veeramalla
• QE review: @varshab1210
• Peer-review: @Srivaralakshmi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@eromanova97 eromanova97 force-pushed the RHDEVDOCS-4110 branch 2 times, most recently from 262fb5f to 8c3b78c Compare July 18, 2023 10:08
@varshab1210
Copy link

LGTM, thanks

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 24, 2023 •
edited by openshift-ci bot

@ekristova: This pull request references RHDEVDOCS-4110 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• OCP version for cherry-picking: enterprise-4.10 and later
• JIRA issue: RHDEVDOCS-4110
• Preview page: Configuring secure communication with Redis
• SME Review: Completed by @iam-veeramalla
• QE review: Completed by @varshab1210
• Peer-review: @Srivaralakshmi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Srivaralakshmi
Srivaralakshmi requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekristova Splendid job! Excellent work! Thank you very much.

PTAL at the suggestions.

cicd/gitops/configuring-secure-communication-with-redis.adoc Outdated Show resolved Hide resolved
cicd/gitops/configuring-secure-communication-with-redis.adoc Outdated Show resolved Hide resolved
cicd/gitops/configuring-secure-communication-with-redis.adoc Show resolved Hide resolved
modules/gitops-configuring-tls-for-redis-with-autotls-disabled.adoc Show resolved Hide resolved
modules/gitops-configuring-tls-for-redis-with-autotls-disabled.adoc Outdated Show resolved Hide resolved
modules/gitops-configuring-tls-for-redis-with-autotls-enabled.adoc Outdated Show resolved Hide resolved
modules/gitops-configuring-tls-for-redis-with-autotls-enabled.adoc Outdated Show resolved Hide resolved
modules/gitops-configuring-tls-for-redis-with-autotls-enabled.adoc Outdated Show resolved Hide resolved
modules/gitops-configuring-tls-for-redis-with-autotls-enabled.adoc Outdated Show resolved Hide resolved
modules/gitops-configuring-tls-for-redis-with-autotls-enabled.adoc Outdated Show resolved Hide resolved
Srivaralakshmi
Srivaralakshmi requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekristova Please address this comment: #62228 (comment)

modules/gitops-configuring-tls-for-redis-with-autotls-disabled.adoc Outdated Show resolved Hide resolved
@eromanova97 eromanova97 force-pushed the RHDEVDOCS-4110 branch 4 times, most recently from 6afa1a1 to af2f378 Compare July 26, 2023 09:14
Srivaralakshmi
Srivaralakshmi requested changes Aug 2, 2023
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekristova PTAL at my suggestions. Thanks for the revision.

modules/gitops-configuring-tls-for-redis-with-autotls-disabled.adoc Outdated Show resolved Hide resolved
modules/gitops-configuring-tls-for-redis-with-autotls-disabled.adoc Outdated Show resolved Hide resolved
modules/gitops-configuring-tls-for-redis-with-autotls-disabled.adoc Outdated Show resolved Hide resolved
modules/gitops-configuring-tls-for-redis-with-autotls-enabled.adoc Outdated Show resolved Hide resolved
modules/gitops-configuring-tls-for-redis-with-autotls-enabled.adoc Outdated Show resolved Hide resolved
modules/gitops-configuring-tls-for-redis-with-autotls-enabled.adoc Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 3, 2023 •
edited by openshift-ci bot

@ekristova: This pull request references RHDEVDOCS-4110 which is a valid jira issue.

In response to this:

• Aligned team: Dev Tools
• OCP version for cherry-picking: enterprise-4.10 and later
• JIRA issue: RHDEVDOCS-4110
• Preview page: Configuring secure communication with Redis
• SME Review: Completed by @iam-veeramalla
• QE review: Completed by @varshab1210
• Peer-review: Completed by @Srivaralakshmi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 3, 2023
@jldohmann jldohmann added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 3, 2023
@jldohmann jldohmann added this to the Continuous Release milestone Aug 3, 2023
jldohmann
jldohmann approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jldohmann jldohmann merged commit b833622 into openshift:main Aug 3, 2023
1 check passed
@jldohmann
Copy link
Contributor

/cherrypick enterprise-4.14

@jldohmann
Copy link
Contributor

/cherrypick enterprise-4.13

@jldohmann
Copy link
Contributor

/cherrypick enterprise-4.12

@jldohmann
Copy link
Contributor

/cherrypick enterprise-4.11

@jldohmann
Copy link
Contributor

/cherrypick enterprise-4.10

@jldohmann jldohmann removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 3, 2023
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #63122

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 3, 2023
Merged
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #63123

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 3, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #63124

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #63125

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 3, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #63126

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eromanova97 eromanova97 deleted the RHDEVDOCS-4110 branch April 18, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iam-veeramalla iam-veeramalla iam-veeramalla approved these changes

@varshab1210 varshab1210 varshab1210 left review comments

@jldohmann jldohmann jldohmann approved these changes

@Srivaralakshmi Srivaralakshmi Srivaralakshmi approved these changes

Assignees

@iam-veeramalla iam-veeramalla

@Srivaralakshmi Srivaralakshmi

Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@eromanova97 @openshift-ci-robot @ocpdocs-previewbot @varshab1210 @Srivaralakshmi @jldohmann @openshift-cherrypick-robot @iam-veeramalla