Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-16184: Fix QEMU link #62430

Merged
merged 1 commit into from
Jul 18, 2023
Merged

OCPBUGS-16184: Fix QEMU link #62430

merged 1 commit into from
Jul 18, 2023

Conversation

apinnick
Copy link
Contributor

@apinnick apinnick commented Jul 16, 2023 •
edited

Version(s): 4.13+

Issue: OCPBUGS-16184

Link to docs preview: Adding VirtIO drivers container disk to a virtual machine

QE review: NA

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 16, 2023
@openshift-ci-robot
Copy link

@apinnick: This pull request references Jira Issue OCPBUGS-16184, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s): 4.13+

Issue: OCPBUGS-16184

Link to docs preview:

QE review: NA

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 16, 2023
@apinnick apinnick added this to the Continuous Release milestone Jul 16, 2023
@apinnick apinnick added CNV Label for all CNV PRs branch/enterprise-4.13 branch/enterprise-4.14 and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 16, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 16, 2023 •
edited

🤖 Updated build preview is available at:
https://62430--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/19979

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 16, 2023
@openshift-ci-robot
Copy link

@apinnick: This pull request references Jira Issue OCPBUGS-16184, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s): 4.13+

Issue: OCPBUGS-16184

Link to docs preview: Adding VirtIO drivers container disk to a virtual machine

QE review: NA

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@apinnick apinnick force-pushed the OCPBUGS-16184-fix-qemu-link branch from e756823 to dbf7d3f Compare July 16, 2023 09:53
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2023
@apinnick
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@apinnick: This pull request references Jira Issue OCPBUGS-16184, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@apinnick apinnick force-pushed the OCPBUGS-16184-fix-qemu-link branch from dbf7d3f to 1a1e0c0 Compare July 16, 2023 10:40
@apinnick apinnick added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 16, 2023
@ShaunaDiaz
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jul 17, 2023
ShaunaDiaz
ShaunaDiaz reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few thoughts. @maxwelldb Can you check me, please?

modules/virt-adding-virtio-drivers-vm-yaml.adoc Outdated Show resolved Hide resolved
modules/virt-adding-virtio-drivers-vm-yaml.adoc Outdated Show resolved Hide resolved
modules/virt-adding-virtio-drivers-vm-yaml.adoc Outdated Show resolved Hide resolved
modules/virt-adding-virtio-drivers-vm-yaml.adoc Show resolved Hide resolved
@ShaunaDiaz
Copy link
Contributor

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 17, 2023
maxwelldb
maxwelldb reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty copacetic, @ShaunaDiaz.

Added a few other things.

modules/virt-adding-virtio-drivers-vm-yaml.adoc Outdated Show resolved Hide resolved
modules/virt-adding-virtio-drivers-vm-yaml.adoc Outdated Show resolved Hide resolved
modules/virt-adding-virtio-drivers-vm-yaml.adoc Outdated Show resolved Hide resolved
@maxwelldb maxwelldb added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 17, 2023
@apinnick
OCPBUGS-16184: Fix QEMU link
08aaf8c 
Signed-off-by: Avital Pinnick <apinnick@redhat.com>
@apinnick apinnick force-pushed the OCPBUGS-16184-fix-qemu-link branch from 1a1e0c0 to 08aaf8c Compare July 18, 2023 07:29
@apinnick apinnick merged commit abc7b87 into openshift:main Jul 18, 2023
1 check passed
@apinnick apinnick deleted the OCPBUGS-16184-fix-qemu-link branch July 18, 2023 07:43
@openshift-ci-robot
Copy link

@apinnick: Jira Issue OCPBUGS-16184: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16184 has been moved to the MODIFIED state.

In response to this:

Version(s): 4.13+

Issue: OCPBUGS-16184

Link to docs preview: Adding VirtIO drivers container disk to a virtual machine

QE review: NA

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@apinnick
Copy link
Contributor Author

/cherrypick enterprise-4.14

@openshift-cherrypick-robot
Copy link

@apinnick: new pull request created: #62494

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwelldb maxwelldb maxwelldb left review comments

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.13 branch/enterprise-4.14 CNV Label for all CNV PRs jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@apinnick @openshift-ci-robot @ocpdocs-previewbot @ShaunaDiaz @openshift-cherrypick-robot @maxwelldb