Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS#15325: updates support status of K8s-NMstate on IPv6 #62465

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

JoeAldinger
Copy link
Contributor

@JoeAldinger JoeAldinger commented Jul 17, 2023

Version(s):
4.10-4.13

Issue:
https://issues.redhat.com/browse/OCPBUGS-15325

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2023
@openshift-ci-robot
Copy link

@JoeAldinger: This pull request references Jira Issue OCPBUGS-15325, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. labels Jul 17, 2023
@openshift-ci-robot
Copy link

@JoeAldinger: This pull request references Jira Issue OCPBUGS-15325, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.10+

Issue:
https://issues.redhat.com/browse/OCPBUGS-15325

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoeAldinger JoeAldinger changed the title OCPBUGS-15325: updates support status of K8s-NMstate on IPv6 OCPBUGS#15325: updates support status of K8s-NMstate on IPv6 Jul 17, 2023
@openshift-ci-robot openshift-ci-robot removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 17, 2023
@openshift-ci-robot
Copy link

@JoeAldinger: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s):
4.10+

Issue:
https://issues.redhat.com/browse/OCPBUGS-15325

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 17, 2023
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 17, 2023
@JoeAldinger JoeAldinger force-pushed the OCPBUGS-15325 branch 3 times, most recently from e48b715 to aa9e373 Compare July 17, 2023 19:53
@ocpdocs-previewbot
Copy link

@cybertron
Copy link
Member

This looks fine for older releases, but in 4.14 we should fully support ipv6: https://issues.redhat.com/browse/OPNET-227

We are hopefully going to backport that once it's been tested on 4.14 and we confirm that we've got everything working, but in the meantime this will be accurate for 4.10 to 4.13.

@zhaozhanqi
Copy link

/assign @qiowang721

@qiowang721
Copy link

yeah, lgtm for 4.10 to 4.13 at the current moment.

@JoeAldinger JoeAldinger added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 26, 2023
@opayne1 opayne1 removed the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 26, 2023
@opayne1 opayne1 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jul 26, 2023
Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@opayne1 opayne1 added peer-review-done Signifies that the peer review team has reviewed this PR lgtm Indicates that a PR is ready to be merged. and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 26, 2023
@JoeAldinger JoeAldinger merged commit 5aa0bb6 into openshift:main Jul 26, 2023
1 check passed
@JoeAldinger JoeAldinger deleted the OCPBUGS-15325 branch July 26, 2023 16:35
@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.13

@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.12

@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.11

@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.10

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #62832

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #62833

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JoeAldinger: #62465 failed to apply on top of branch "enterprise-4.11":

Applying: OCPBUGS-15325: updates support status of K8s-NMstate on IPv6
Using index info to reconstruct a base tree...
M	modules/nw-ovn-kubernetes-matrix.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-ovn-kubernetes-matrix.adoc
CONFLICT (content): Merge conflict in modules/nw-ovn-kubernetes-matrix.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-15325: updates support status of K8s-NMstate on IPv6
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JoeAldinger: #62465 failed to apply on top of branch "enterprise-4.10":

Applying: OCPBUGS-15325: updates support status of K8s-NMstate on IPv6
Using index info to reconstruct a base tree...
M	modules/nw-ovn-kubernetes-matrix.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-ovn-kubernetes-matrix.adoc
CONFLICT (content): Merge conflict in modules/nw-ovn-kubernetes-matrix.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-15325: updates support status of K8s-NMstate on IPv6
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants