Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-7621-note: Removed L2 vSphere external LB note #62749

Merged
merged 1 commit into from
Jul 27, 2023
Merged

OCPBUGS-7621-note: Removed L2 vSphere external LB note #62749

merged 1 commit into from
Jul 27, 2023

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Jul 25, 2023 •
edited

OCPBUGS-7621

Version(s):
4.14 through to 4.10

Link to docs preview:
Configuring an external load balancer

QE review:

  • QE has approved this change.

Additional information:
Clark to provide the following items:

  • Generic graphic illustration that covers the three health check resources.
  • Provide a better example for step 1 in the procedure that is more production-environment focused.
  • Revise the Configuring external LB section to ensure the content is more accurate. Information for port 1936 was removed but maybe it needs to be added back but with more accurate information.
  • Clarify if we need to point to the RHEL Cluster add-on (toolkit) that provides a better way to configure a LB. We need to be more generic as F5 is maintained by a third-party vendor.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 25, 2023
@dfitzmau dfitzmau mentioned this pull request Jul 25, 2023
Merged
1 task
@ocpdocs-previewbot
Copy link

🤖 Build preview is available at:
https://62749--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/20445

@rvanderp3
Copy link
Contributor

LGTM

@sgaoshang
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2023
@dfitzmau
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 27, 2023
@michaelryanpeter
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jul 27, 2023
@michaelryanpeter
Copy link
Contributor

LGTM!
/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 27, 2023
@dfitzmau
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 27, 2023
@JoeAldinger JoeAldinger added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 27, 2023
@JoeAldinger JoeAldinger merged commit b6647cf into openshift:main Jul 27, 2023
1 check passed
@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.14

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.13

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.12

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.11

@JoeAldinger
Copy link
Contributor

/cherrypick enterprise-4.10

@JoeAldinger JoeAldinger added this to the Continuous Release milestone Jul 27, 2023
@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.13

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.12

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.11

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 27, 2023
Merged
@openshift-cherrypick-robot
Copy link

@kalexand-rh: new pull request created: #62894

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@kalexand-rh: new pull request created: #62895

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 27, 2023
Merged
@openshift-cherrypick-robot
Copy link

@kalexand-rh: new pull request created: #62896

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 27, 2023
Merged
@openshift-cherrypick-robot
Copy link

@kalexand-rh: new pull request created: #62897

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jul 27, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@kalexand-rh: new pull request created: #62898

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sgaoshang sgaoshang

Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dfitzmau @ocpdocs-previewbot @rvanderp3 @sgaoshang @michaelryanpeter @JoeAldinger @kalexand-rh @openshift-cherrypick-robot