Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-6035: Network Observability w/o Loki #62901

Merged
merged 1 commit into from
Sep 28, 2023
Merged

OSDOCS-6035: Network Observability w/o Loki #62901

merged 1 commit into from
Sep 28, 2023

Conversation

skrthomas
Copy link
Contributor

@skrthomas skrthomas commented Jul 27, 2023 •
edited

Version(s):

4.11+
Issue:

https://issues.redhat.com/browse/OSDOCS-6035
Also addresses this bug to clarify the Secret documentation: https://issues.redhat.com/browse/OCPBUGS-17594
Link to docs preview:

https://62901--docspreview.netlify.app/openshift-enterprise/latest/networking/network_observability/installing-operators.html#network-observability-without-lokinetwork_observability

QE review:

  • QE has approved this change.

Additional information:

This PR is not to be merged until Network Observability GA 9/25/23.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 27, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-6035 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 27, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-6035 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-6035
Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 27, 2023 •
edited

🤖 Updated build preview is available at:
https://62901--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/26212

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 27, 2023
@skrthomas skrthomas force-pushed the OSDOCS-6035 branch 2 times, most recently from 8b7bd4e to 332323a Compare July 28, 2023 19:24
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 28, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-6035 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-6035
Link to docs preview:

https://62901--docspreview.netlify.app/openshift-enterprise/latest/networking/network_observability/installing-operators.html#network-observability-without-lokinetwork_observability

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas
Copy link
Contributor Author

@jpinsonneau first swipe at this, if you can PTAL and let me know your thoughts/suggestions :)

@skrthomas skrthomas force-pushed the OSDOCS-6035 branch 4 times, most recently from 4720a00 to ffea36f Compare August 1, 2023 19:45
@skrthomas skrthomas requested a review from Amoghrd August 7, 2023 20:23
@skrthomas
Copy link
Contributor Author

@Amoghrd can you PTAL at this from QE perspective? TY!

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 9, 2023
@skrthomas skrthomas force-pushed the OSDOCS-6035 branch 2 times, most recently from 4e3cdeb to e716d70 Compare August 17, 2023 20:48
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2023
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2023
@skrthomas skrthomas force-pushed the OSDOCS-6035 branch 3 times, most recently from 48aa67f to 06937d2 Compare September 25, 2023 17:19
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-6035 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s):

4.10+
Issue:

https://issues.redhat.com/browse/OSDOCS-6035
Also addresses this bug to clarify the Secret documentation: https://issues.redhat.com/browse/OCPBUGS-17594
Link to docs preview:

https://62901--docspreview.netlify.app/openshift-enterprise/latest/networking/network_observability/installing-operators.html#network-observability-without-lokinetwork_observability

QE review:

  • QE has approved this change.

Additional information:

This PR is not to be merged until Network Observability GA 9/25/23.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Amoghrd
Copy link

Amoghrd commented Sep 27, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 27, 2023
@skrthomas skrthomas force-pushed the OSDOCS-6035 branch 3 times, most recently from 0d7afbc to d87f9e0 Compare September 28, 2023 02:42
@skrthomas skrthomas merged commit 45a91fd into openshift:main Sep 28, 2023
1 check passed
@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.11

@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.12

@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.13

@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 28, 2023
Merged
@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #65369

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 28, 2023
Merged
@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #65370

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 28, 2023
Merged
@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #65371

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #65372

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 28, 2023
Merged
@skrthomas skrthomas removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adellape adellape adellape left review comments

@mburke5678 mburke5678 mburke5678 left review comments

@dfitzmau dfitzmau dfitzmau left review comments

@Amoghrd Amoghrd Amoghrd left review comments

@jpinsonneau jpinsonneau jpinsonneau approved these changes

Assignees

@Amoghrd Amoghrd

@jpinsonneau jpinsonneau

Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet