Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-5458: Update sink -> target in dev console #62975

Merged
merged 1 commit into from Aug 22, 2023
Merged

RHDEVDOCS-5458: Update sink -> target in dev console #62975

merged 1 commit into from Aug 22, 2023

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Jul 31, 2023 •
edited

Version(s):
serverless-docs-1.28
serverless-docs-1.29
serverless-docs-1.30

Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5458

Link to docs preview:

QE review:

  • QE has approved this change.

@abrennan89 abrennan89 added peer-review-needed Signifies that the peer review team needs to review this PR dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs serverless Label for all Serverless PRs labels Jul 31, 2023
@abrennan89 abrennan89 added this to the Continuous Release milestone Jul 31, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2023 •
edited by openshift-ci bot

@abrennan89: This pull request references RHDEVDOCS-5458 which is a valid jira issue.

In response to this:

Version(s):
serverless-docs-1.28
serverless-docs-1.29
serverless-docs-1.30

Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5458

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2023 •
edited by openshift-ci bot

@abrennan89: This pull request references RHDEVDOCS-5458 which is a valid jira issue.

In response to this:

Version(s):
serverless-docs-1.28
serverless-docs-1.29
serverless-docs-1.30

Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5458

Link to docs preview:
N/A - multiple small one word changes on different pages

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 31, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 31, 2023 •
edited

🤖 Updated build preview is available at:
https://62975--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/22494

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2023 •
edited by openshift-ci bot

@abrennan89: This pull request references RHDEVDOCS-5458 which is a valid jira issue.

In response to this:

Version(s):
serverless-docs-1.28
serverless-docs-1.29
serverless-docs-1.30

Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5458

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jrangelramos
Copy link
Contributor

QE Approved

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2023 •
edited by openshift-ci bot

@abrennan89: This pull request references RHDEVDOCS-5458 which is a valid jira issue.

In response to this:

Version(s):
serverless-docs-1.28
serverless-docs-1.29
serverless-docs-1.30

Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5458

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89
Copy link
Contributor Author

CC @gabriel-rh and @nainaz so they're aware of the change

vikram-raj
vikram-raj reviewed Aug 1, 2023
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

max-cx
max-cx approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@max-cx max-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some comments and suggestions.

@abrennan89 abrennan89 force-pushed the RHDEVDOCS-5458 branch 3 times, most recently from 45830d4 to 3e0da19 Compare August 2, 2023 19:29
@abrennan89 abrennan89 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 2, 2023
@abrennan89 abrennan89 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 3, 2023 •
edited by openshift-ci bot

@abrennan89: This pull request references RHDEVDOCS-5458 which is a valid jira issue.

In response to this:

Version(s):
serverless-docs-1.28
serverless-docs-1.29
serverless-docs-1.30

Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5458

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 3, 2023 •
edited by openshift-ci bot

@abrennan89: This pull request references RHDEVDOCS-5458 which is a valid jira issue.

In response to this:

Version(s):
serverless-docs-1.28
serverless-docs-1.29
serverless-docs-1.30

Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5458

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89
Copy link
Contributor Author

@jrangelramos @vikram-raj @max-cx I ended up making some changes to the PR, if you could PTAL and confirm it's still approved I'd really appreciate it. No rush. Thank you!

@abrennan89 abrennan89 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2023
@abrennan89
Copy link
Contributor Author

/cherrypick serverless-docs-1.28

@openshift-cherrypick-robot
Copy link

@abrennan89: once the present PR merges, I will cherry-pick it on top of serverless-docs-1.28 in a new PR and assign it to you.

In response to this:

/cherrypick serverless-docs-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89
Copy link
Contributor Author

/cherrypick serverless-docs-1.29

@openshift-cherrypick-robot
Copy link

@abrennan89: once the present PR merges, I will cherry-pick it on top of serverless-docs-1.29 in a new PR and assign it to you.

In response to this:

/cherrypick serverless-docs-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89
Copy link
Contributor Author

/cherrypick serverless-docs-1.30

@openshift-cherrypick-robot
Copy link

@abrennan89: once the present PR merges, I will cherry-pick it on top of serverless-docs-1.30 in a new PR and assign it to you.

In response to this:

/cherrypick serverless-docs-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 merged commit be90d36 into openshift:serverless-docs Aug 22, 2023
1 check passed
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 22, 2023
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #63796

In response to this:

/cherrypick serverless-docs-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #63797

In response to this:

/cherrypick serverless-docs-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 22, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #63798

In response to this:

/cherrypick serverless-docs-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 deleted the RHDEVDOCS-5458 branch September 18, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikram-raj vikram-raj vikram-raj left review comments

@max-cx max-cx max-cx approved these changes

@nainaz nainaz Awaiting requested review from nainaz

@gabriel-rh gabriel-rh Awaiting requested review from gabriel-rh

Assignees
No one assigned
Labels
dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR serverless Label for all Serverless PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@abrennan89 @openshift-ci-robot @ocpdocs-previewbot @jrangelramos @openshift-cherrypick-robot @vikram-raj @max-cx