Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS-6642: DNS tracking Network Observability #63031

Merged
merged 1 commit into from Sep 28, 2023

Conversation

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2023

@skrthomas: This pull request references OSDOCS-6642 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-7187
Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 1, 2023
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 1, 2023
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 1, 2023
@skrthomas skrthomas force-pushed the OSDOCS-6642 branch 6 times, most recently from b3c28c8 to 7058ba4 Compare August 2, 2023 21:27
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 2, 2023

🤖 Updated build preview is available at:
https://63031--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/26242

@skrthomas skrthomas force-pushed the OSDOCS-6642 branch 5 times, most recently from 2f50a52 to 9a1e08c Compare August 4, 2023 21:04
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 4, 2023

@skrthomas: This pull request references OSDOCS-6642 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-7187

https://issues.redhat.com/browse/OSDOCS-6273
Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 4, 2023

@skrthomas: This pull request references OSDOCS-6642 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-7187

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 4, 2023
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 7, 2023

@skrthomas: This pull request references OSDOCS-6642 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-7187

Link to docs preview:

Overview: https://63031--docspreview.netlify.app/openshift-enterprise/latest/networking/network_observability/observing-network-traffic#network-observability-dns-overview_nw-observe-network-traffic

Working with DNS tracking: https://63031--docspreview.netlify.app/openshift-enterprise/latest/networking/network_observability/observing-network-traffic#network-observability-dns-tracking_nw-observe-network-traffic
QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


* Troubleshooting: Debug DNS-related issues by tracing DNS resolution steps, tracking latency, and identifying misconfigurations.

When DNS tracking is enabled, you can see the following metrics represented in a chart in the *Overview*. See the _Additional Resources_ of this section for more information about enabling and working with this view.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When DNS tracking is enabled, you can see the following metrics represented in a chart in the *Overview*. See the _Additional Resources_ of this section for more information about enabling and working with this view.
When DNS tracking is enabled, you can see the following metrics represented in a chart in the *Overview*. See the _Additional Resources_ section for more information about enabling and working with this view.

...or another option is " See Additional Resources in this section for more information about...".

<2> Note that the `spec.agent.ebpf.privileged` specification value must be `true` for packet drop tracking to be enabled.


. When you refresh the *Network Traffic* page, there are new choices to enable in the *Overview* and *Traffic Flow* views as well as new filters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. When you refresh the *Network Traffic* page, there are new choices to enable in the *Overview* and *Traffic Flow* views as well as new filters.
. When you refresh the *Network Traffic* page, there are new choices to enable in the *Overview* and *Traffic Flow* views and new filters.

See ISG: https://www.ibm.com/docs/en/ibm-style?topic=word-usage#a

modules/network-observability-dns-tracking.adoc Outdated Show resolved Hide resolved
@tmalove
Copy link
Contributor

tmalove commented Sep 8, 2023

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Sep 8, 2023
@kalexand-rh
Copy link
Contributor

Only versions 4.11+ are still in maintenance. I am removing labels from earlier versions from this PR.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 28, 2023

@skrthomas: This pull request references OSDOCS-6642 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-7187

Link to docs preview:

Overview: https://63031--docspreview.netlify.app/openshift-enterprise/latest/networking/network_observability/observing-network-traffic#network-observability-dns-overview_nw-observe-network-traffic

Working with DNS tracking: https://63031--docspreview.netlify.app/openshift-enterprise/latest/networking/network_observability/observing-network-traffic#network-observability-dns-tracking_nw-observe-network-traffic
QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas skrthomas force-pushed the OSDOCS-6642 branch 2 times, most recently from e190586 to a6c433d Compare September 28, 2023 13:36
@skrthomas skrthomas merged commit f0c4caf into openshift:main Sep 28, 2023
1 check passed
@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.11

@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.12

@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.13

@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@skrthomas: #63031 failed to apply on top of branch "enterprise-4.11":

Applying: undoing pktdrop additions
.git/rebase-apply/patch:49: trailing whitespace.
= Working with DNS tracking 
.git/rebase-apply/patch:58: trailing whitespace.
. Under the *Provided APIs* heading for the *NetObserv Operator*, select *Flow Collector*. 
.git/rebase-apply/patch:76: trailing whitespace.
      - DNSTracking           <1>                       
warning: 3 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	networking/network_observability/observing-network-traffic.adoc
Falling back to patching base and 3-way merge...
Auto-merging networking/network_observability/observing-network-traffic.adoc
CONFLICT (content): Merge conflict in networking/network_observability/observing-network-traffic.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 undoing pktdrop additions
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@skrthomas: #63031 failed to apply on top of branch "enterprise-4.12":

Applying: undoing pktdrop additions
.git/rebase-apply/patch:49: trailing whitespace.
= Working with DNS tracking 
.git/rebase-apply/patch:58: trailing whitespace.
. Under the *Provided APIs* heading for the *NetObserv Operator*, select *Flow Collector*. 
.git/rebase-apply/patch:76: trailing whitespace.
      - DNSTracking           <1>                       
warning: 3 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	networking/network_observability/observing-network-traffic.adoc
Falling back to patching base and 3-way merge...
Auto-merging networking/network_observability/observing-network-traffic.adoc
CONFLICT (content): Merge conflict in networking/network_observability/observing-network-traffic.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 undoing pktdrop additions
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@skrthomas: new pull request created: #65416

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@skrthomas: new pull request created: #65417

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas
Copy link
Contributor Author

4.11: #65425

@skrthomas
Copy link
Contributor Author

4.12: #65427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants