Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oadp 2155 rosa sts docs hvider #63294

Closed

Conversation

HagayVider1
Copy link
Contributor

@HagayVider1 HagayVider1 commented Aug 8, 2023

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 8, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 8, 2023

🤖 Updated build preview is available at:
https://63294--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/22242

@anarnold97
Copy link
Contributor

@HagayVider1 - please can we go through this PR on Thursday.
There are a few things we have to discuss. It is not ready for QE yet, so please do not flag them for review.

Thanks


include::modules/oadp-preparing-aws-credentials.adoc[leveloffset=+1]

include::modules/oadp-installing-oadp-rosa-sts.adoc[leveloffset=+1]
Copy link
Contributor

@anarnold97 anarnold97 Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HagayVider1 - I do not think this order of modules makes much sense.

Please ensure you understand the difference between installing the OpenShift API for Data Protection (OADP) with Amazon Web Services (AWS) and Red Hat OpenShift Service on AWS (ROSA).

Let us talk about this on Thursday and see if we can improve it as people might fall between the options.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted. I'll change this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us walk through it later today

@@ -39,5 +39,6 @@ include::modules/oadp-installing-oadp-rosa-sts.adoc[leveloffset=+1]
* link:https://docs.openshift.com/rosa/rosa_getting_started/rosa-sts-getting-started-workflow.html[Getting started with ROSA STS]
* link:https://docs.openshift.com/rosa/rosa_install_access_delete_clusters/rosa-sts-creating-a-cluster-quickly.html[Creating a ROSA cluster with STS]
* link:https://docs.openshift.com/container-platform/4.13/backup_and_restore/application_backup_and_restore/installing/about-installing-oadp.html[About installing OADP]
* link:https://access.redhat.com/documentation/en-us/openshift_container_platform/4.12/html/backup_and_restore/application-backup-and-restore#installing-oadp-aws[Installing and configuring the OpenShift API for Data Protection with Amazon Web Services]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken link.... look at the end ]]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants